Rename meson_encoder_{cvbs,dsi,hdmi}_init() to meson_encoder_{cvbs,dsi,hdmi}_probe() so it's clear that these functions are used at probe time during driver initialization. Also switch all error prints inside those functions to use dev_err_probe() for consistency. This makes the code more straight forward to read and makes the error prints within those functions consistent (by logging all -EPROBE_DEFER with dev_dbg(), while actual errors are logged with dev_err() and get the error value printed). Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/20240218175035.1948165-1-martin.blumenstingl@googlemail.com Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240218175035.1948165-1-martin.blumenstingl@googlemail.com
30 lines
741 B
C
30 lines
741 B
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2016 BayLibre, SAS
|
|
* Author: Neil Armstrong <narmstrong@baylibre.com>
|
|
* Copyright (C) 2014 Endless Mobile
|
|
*
|
|
* Written by:
|
|
* Jasper St. Pierre <jstpierre@mecheye.net>
|
|
*/
|
|
|
|
#ifndef __MESON_VENC_CVBS_H
|
|
#define __MESON_VENC_CVBS_H
|
|
|
|
#include "meson_drv.h"
|
|
#include "meson_venc.h"
|
|
|
|
struct meson_cvbs_mode {
|
|
struct meson_cvbs_enci_mode *enci;
|
|
struct drm_display_mode mode;
|
|
};
|
|
|
|
#define MESON_CVBS_MODES_COUNT 2
|
|
|
|
/* Modes supported by the CVBS output */
|
|
extern struct meson_cvbs_mode meson_cvbs_modes[MESON_CVBS_MODES_COUNT];
|
|
|
|
int meson_encoder_cvbs_probe(struct meson_drm *priv);
|
|
void meson_encoder_cvbs_remove(struct meson_drm *priv);
|
|
|
|
#endif /* __MESON_VENC_CVBS_H */
|