There's only one instance of the pcode per tile, and for GT-related
accesses both the primary and media GT share the same register
interface. Since Xe was using per-GT locking, the pcode mutex wasn't
actually protecting everything that it should since concurrent accesses
related to a tile's primary GT and media GT were possible.
Fixes: dd08ebf6c3
("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240829220619.789159-5-matthew.d.roper@intel.com
32 lines
963 B
C
32 lines
963 B
C
/* SPDX-License-Identifier: MIT */
|
|
/*
|
|
* Copyright © 2022 Intel Corporation
|
|
*/
|
|
|
|
#ifndef _XE_PCODE_H_
|
|
#define _XE_PCODE_H_
|
|
|
|
#include <linux/types.h>
|
|
struct xe_tile;
|
|
struct xe_device;
|
|
|
|
void xe_pcode_init(struct xe_tile *tile);
|
|
int xe_pcode_probe_early(struct xe_device *xe);
|
|
int xe_pcode_ready(struct xe_device *xe, bool locked);
|
|
int xe_pcode_init_min_freq_table(struct xe_tile *tile, u32 min_gt_freq,
|
|
u32 max_gt_freq);
|
|
int xe_pcode_read(struct xe_tile *tile, u32 mbox, u32 *val, u32 *val1);
|
|
int xe_pcode_write_timeout(struct xe_tile *tile, u32 mbox, u32 val,
|
|
int timeout_ms);
|
|
#define xe_pcode_write(tile, mbox, val) \
|
|
xe_pcode_write_timeout(tile, mbox, val, 1)
|
|
|
|
int xe_pcode_request(struct xe_tile *tile, u32 mbox, u32 request,
|
|
u32 reply_mask, u32 reply, int timeout_ms);
|
|
|
|
#define PCODE_MBOX(mbcmd, param1, param2)\
|
|
(FIELD_PREP(PCODE_MB_COMMAND, mbcmd)\
|
|
| FIELD_PREP(PCODE_MB_PARAM1, param1)\
|
|
| FIELD_PREP(PCODE_MB_PARAM2, param2))
|
|
|
|
#endif
|