Simon Arlott 7dd9c26bd6 can: mcp251x: fix deadlock if an interrupt occurs during mcp251x_open ... The mcp251x_hw_wake() function is called with the mpc_lock mutex held and disables the interrupt handler so that no interrupts can be processed while waking the device. If an interrupt has already occurred then waiting for the interrupt handler to complete will deadlock because it will be trying to acquire the same mutex. CPU0 CPU1 ---- ---- mcp251x_open() mutex_lock(&priv->mcp_lock) request_threaded_irq() <interrupt> mcp251x_can_ist() mutex_lock(&priv->mcp_lock) mcp251x_hw_wake() disable_irq() <-- deadlock Use disable_irq_nosync() instead because the interrupt handler does everything while holding the mutex so it doesn't matter if it's still running. Fixes: 8ce8c0abcb ("can: mcp251x: only reset hardware as required") Signed-off-by: Simon Arlott <simon@octiron.net> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/all/4fc08687-1d80-43fe-9f0d-8ef8475e75f6@0882a8b5-c6c3-11e9-b005-00805fc181fe.uuid.home.arpa Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>		2024-08-22 09:47:09 +02:00
..
mcp251xfd	can: mcp251xfd: mcp251xfd_ring_init(): check TX-coalescing configuration	2024-08-06 09:52:13 +02:00
hi311x.c	can: hi311x: simplify with spi_get_device_match_data()	2024-06-21 09:46:38 +02:00
Kconfig	can: mcp251xfd: rename driver files and subdir to mcp251xfd	2020-09-30 21:54:30 +02:00
Makefile	can: mcp251xfd: rename driver files and subdir to mcp251xfd	2020-09-30 21:54:30 +02:00
mcp251x.c	can: mcp251x: fix deadlock if an interrupt occurs during mcp251x_open	2024-08-22 09:47:09 +02:00