495d2d8133
GCC's -Wall includes -Wsign-compare while clang does not. Since BPF programs are built with clang we need to add this flag explicitly to catch problematic comparisons like: int i = -1; unsigned int j = 1; if (i < j) // this is false. long i = -1; unsigned int j = 1; if (i < j) // this is true. C standard for reference: - If either operand is unsigned long the other shall be converted to unsigned long. - Otherwise, if one operand is a long int and the other unsigned int, then if a long int can represent all the values of an unsigned int, the unsigned int shall be converted to a long int; otherwise both operands shall be converted to unsigned long int. - Otherwise, if either operand is long, the other shall be converted to long. - Otherwise, if either operand is unsigned, the other shall be converted to unsigned. Unfortunately clang's -Wsign-compare is very noisy. It complains about (s32)a == (u32)b which is safe and doen't have surprising behavior. This patch fixes some of the issues. It needs a follow up to fix the rest. Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Acked-by: Jiri Olsa <jolsa@kernel.org> Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com> Link: https://lore.kernel.org/bpf/20231226191148.48536-2-alexei.starovoitov@gmail.com
89 lines
2.4 KiB
C
89 lines
2.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/* Copyright (c) 2021 Facebook */
|
|
|
|
#include "vmlinux.h"
|
|
#include <bpf/bpf_helpers.h>
|
|
#include <bpf/bpf_tracing.h>
|
|
#include <bpf/bpf_core_read.h>
|
|
#include "bpf_misc.h"
|
|
|
|
/* weak and shared between both files */
|
|
const volatile int my_tid __weak;
|
|
long syscall_id __weak;
|
|
|
|
int output_val2;
|
|
int output_ctx2;
|
|
int output_weak2; /* should stay zero */
|
|
|
|
/* same "subprog" name in all files, but it's ok because they all are static */
|
|
static __noinline int subprog(int x)
|
|
{
|
|
/* but different formula */
|
|
return x * 2;
|
|
}
|
|
|
|
/* Global functions can't be void */
|
|
int set_output_val2(int x)
|
|
{
|
|
output_val2 = 2 * x + 2 * subprog(x);
|
|
return 2 * x;
|
|
}
|
|
|
|
/* This function can't be verified as global, as it assumes raw_tp/sys_enter
|
|
* context and accesses syscall id (second argument). So we mark it as
|
|
* __hidden, so that libbpf will mark it as static in the final object file,
|
|
* right before verifying it in the kernel.
|
|
*
|
|
* But we don't mark it as __hidden here, rather at extern site. __hidden is
|
|
* "contaminating" visibility, so it will get propagated from either extern or
|
|
* actual definition (including from the losing __weak definition).
|
|
*/
|
|
void set_output_ctx2(__u64 *ctx)
|
|
{
|
|
output_ctx2 = ctx[1]; /* long id, same as in BPF_PROG below */
|
|
}
|
|
|
|
/* this weak instance should lose, because it will be processed second */
|
|
__weak int set_output_weak(int x)
|
|
{
|
|
static volatile int whatever;
|
|
|
|
/* make sure we use CO-RE relocations in a weak function, this used to
|
|
* cause problems for BPF static linker
|
|
*/
|
|
whatever = 2 * bpf_core_type_size(struct task_struct);
|
|
__sink(whatever);
|
|
|
|
output_weak2 = x;
|
|
return 2 * x;
|
|
}
|
|
|
|
extern int set_output_val1(int x);
|
|
|
|
/* here we'll force set_output_ctx1() to be __hidden in the final obj file */
|
|
__hidden extern void set_output_ctx1(__u64 *ctx);
|
|
|
|
SEC("?raw_tp/sys_enter")
|
|
int BPF_PROG(handler2, struct pt_regs *regs, long id)
|
|
{
|
|
static volatile int whatever;
|
|
|
|
if (my_tid != (s32)bpf_get_current_pid_tgid() || id != syscall_id)
|
|
return 0;
|
|
|
|
/* make sure we have CO-RE relocations in main program */
|
|
whatever = bpf_core_type_size(struct task_struct);
|
|
__sink(whatever);
|
|
|
|
set_output_val1(2000);
|
|
set_output_ctx1(ctx); /* ctx definition is hidden in BPF_PROG macro */
|
|
|
|
/* keep input value the same across both files to avoid dependency on
|
|
* handler call order; differentiate by output_weak1 vs output_weak2.
|
|
*/
|
|
set_output_weak(42);
|
|
|
|
return 0;
|
|
}
|
|
|
|
char LICENSE[] SEC("license") = "GPL";
|