1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/ethernet/intel
Ivan Vecera 36c824ca3e i40e: Fix firmware version comparison function
Helper i40e_is_fw_ver_eq() compares incorrectly given firmware version
as it returns true when the major version of running firmware is
greater than the given major version that is wrong and results in
failure during getting of DCB configuration where this helper is used.
Fix the check and return true only if the running FW version is exactly
equals to the given version.

Reproducer:
1. Load i40e driver
2. Check dmesg output

[root@host ~]# modprobe i40e
[root@host ~]# dmesg | grep 'i40e.*DCB'
[   74.750642] i40e 0000:02:00.0: Query for DCB configuration failed, err -EIO aq_err I40E_AQ_RC_EINVAL
[   74.759770] i40e 0000:02:00.0: DCB init failed -5, disabled
[   74.966550] i40e 0000:02:00.1: Query for DCB configuration failed, err -EIO aq_err I40E_AQ_RC_EINVAL
[   74.975683] i40e 0000:02:00.1: DCB init failed -5, disabled

Fixes: cf488e1322 ("i40e: Add other helpers to check version of running firmware and AQ API")
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2024-03-05 09:49:59 -08:00
..
e1000 intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000e e1000e: correct maximum frequency adjustment values 2024-01-29 10:01:08 -08:00
fm10k intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
i40e i40e: Fix firmware version comparison function 2024-03-05 09:49:59 -08:00
iavf iavf: field get conversion 2023-12-18 11:20:43 -08:00
ice ice: fix typo in assignment 2024-03-05 09:49:54 -08:00
idpf idpf: disable local BH when scheduling napi for marker packets 2024-03-05 09:47:38 -08:00
igb igb: extend PTP timestamp adjustments to i211 2024-02-28 20:16:48 -08:00
igbvf intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
igc igc: Remove temporary workaround 2024-02-14 09:43:09 -08:00
ixgbe ixgbe: {dis, en}able irqs in ixgbe_txrx_ring_{dis, en}able 2024-03-01 09:35:19 -08:00
ixgbevf net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops 2023-12-13 22:07:16 -08:00
e100.c e100: replace deprecated strncpy with strscpy 2023-10-18 18:10:17 -07:00
Kconfig ice: read internal temperature sensor 2023-12-05 11:40:12 +01:00
Makefile idpf: add SRIOV support and other ndo_ops 2023-09-13 14:59:24 -07:00