Avoid holding gpu lock when calling runpm, to avoid this lockdep splat: ====================================================== WARNING: possible circular locking dependency detected 6.4.3-debug+ #14 Not tainted ------------------------------------------------------ ring0/373 is trying to acquire lock: ffffffead86efb98 (prepare_lock){+.+.}-{3:3}, at: clk_prepare_lock+0x70/0x98 but task is already holding lock: ffffff809cd19170 (&gpu->lock){+.+.}-{3:3}, at: msm_job_run+0x7c/0x128 [msm] which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&gpu->lock){+.+.}-{3:3}: __mutex_lock+0xc8/0x388 mutex_lock_nested+0x2c/0x38 msm_job_run+0x7c/0x128 [msm] drm_sched_main+0x264/0x354 [gpu_sched] kthread+0xf0/0x100 ret_from_fork+0x10/0x20 -> #3 (dma_fence_map){++++}-{0:0}: __dma_fence_might_wait+0x74/0xc0 dma_resv_lockdep+0x1f0/0x2e8 do_one_initcall+0xb4/0x214 kernel_init_freeable+0x338/0x33c kernel_init+0x30/0x134 ret_from_fork+0x10/0x20 -> #2 (mmu_notifier_invalidate_range_start){+.+.}-{0:0}: fs_reclaim_acquire+0x7c/0x9c slab_pre_alloc_hook.constprop.0+0x40/0x250 __kmem_cache_alloc_node+0x60/0x18c kmalloc_node_trace+0x40/0x84 alloc_worker+0x2c/0x64 init_rescuer+0x34/0xe0 workqueue_init+0x168/0x1fc kernel_init_freeable+0x15c/0x33c kernel_init+0x30/0x134 ret_from_fork+0x10/0x20 -> #1 (fs_reclaim){+.+.}-{0:0}: __fs_reclaim_acquire+0x3c/0x48 fs_reclaim_acquire+0x50/0x9c slab_pre_alloc_hook.constprop.0+0x40/0x250 __kmem_cache_alloc_node+0x60/0x18c kmalloc_trace+0x44/0x88 clk_rcg2_dfs_determine_rate+0x60/0x214 clk_core_determine_round_nolock+0xb8/0xf0 clk_core_round_rate_nolock+0x84/0x118 clk_core_round_rate_nolock+0xd8/0x118 clk_round_rate+0x6c/0xd0 geni_se_clk_tbl_get+0x78/0xc0 geni_se_clk_freq_match+0x44/0xe4 get_spi_clk_cfg+0x50/0xf4 geni_spi_set_clock_and_bw+0x54/0x104 spi_geni_prepare_message+0x130/0x174 __spi_pump_transfer_message+0x200/0x4d8 __spi_sync+0x13c/0x23c spi_sync_locked+0x18/0x24 do_cros_ec_pkt_xfer_spi+0x124/0x3f0 cros_ec_xfer_high_pri_work+0x28/0x3c kthread_worker_fn+0x14c/0x27c kthread+0xf0/0x100 ret_from_fork+0x10/0x20 -> #0 (prepare_lock){+.+.}-{3:3}: __lock_acquire+0xdf8/0x109c lock_acquire+0x234/0x284 __mutex_lock+0xc8/0x388 mutex_lock_nested+0x2c/0x38 clk_prepare_lock+0x70/0x98 clk_prepare+0x24/0x50 clk_bulk_prepare+0x50/0x9c a6xx_gmu_resume+0x94/0x800 [msm] a6xx_gmu_pm_resume+0x38/0x158 [msm] adreno_runtime_resume+0x2c/0x38 [msm] pm_generic_runtime_resume+0x30/0x44 __rpm_callback+0x4c/0x134 rpm_callback+0x78/0x7c rpm_resume+0x3a4/0x46c __pm_runtime_resume+0x78/0xbc pm_runtime_get_sync.isra.0+0x14/0x20 [msm] msm_gpu_submit+0x4c/0x12c [msm] msm_job_run+0x88/0x128 [msm] drm_sched_main+0x264/0x354 [gpu_sched] kthread+0xf0/0x100 ret_from_fork+0x10/0x20 other info that might help us debug this: Chain exists of: prepare_lock --> dma_fence_map --> &gpu->lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&gpu->lock); lock(dma_fence_map); lock(&gpu->lock); lock(prepare_lock); *** DEADLOCK *** 2 locks held by ring0/373: #0: ffffffead875ae50 (dma_fence_map){++++}-{0:0}, at: drm_sched_main+0x54/0x354 [gpu_sched] #1: ffffff809cd19170 (&gpu->lock){+.+.}-{3:3}, at: msm_job_run+0x7c/0x128 [msm] stack backtrace: CPU: 2 PID: 373 Comm: ring0 Not tainted 6.4.3-debug+ #14 Hardware name: Google Villager (rev1+) with LTE (DT) Call trace: dump_backtrace+0xb4/0xf0 show_stack+0x20/0x30 dump_stack_lvl+0x60/0x84 dump_stack+0x18/0x24 print_circular_bug+0x1cc/0x234 check_noncircular+0x78/0xac __lock_acquire+0xdf8/0x109c lock_acquire+0x234/0x284 __mutex_lock+0xc8/0x388 mutex_lock_nested+0x2c/0x38 clk_prepare_lock+0x70/0x98 clk_prepare+0x24/0x50 clk_bulk_prepare+0x50/0x9c a6xx_gmu_resume+0x94/0x800 [msm] a6xx_gmu_pm_resume+0x38/0x158 [msm] adreno_runtime_resume+0x2c/0x38 [msm] pm_generic_runtime_resume+0x30/0x44 __rpm_callback+0x4c/0x134 rpm_callback+0x78/0x7c rpm_resume+0x3a4/0x46c __pm_runtime_resume+0x78/0xbc pm_runtime_get_sync.isra.0+0x14/0x20 [msm] msm_gpu_submit+0x4c/0x12c [msm] msm_job_run+0x88/0x128 [msm] drm_sched_main+0x264/0x354 [gpu_sched] kthread+0xf0/0x100 ret_from_fork+0x10/0x20 Signed-off-by: Rob Clark <robdclark@chromium.org> Patchwork: https://patchwork.freedesktop.org/patch/552298/
1023 lines
23 KiB
C
1023 lines
23 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2013 Red Hat
|
|
* Author: Rob Clark <robdclark@gmail.com>
|
|
*/
|
|
|
|
#include "drm/drm_drv.h"
|
|
|
|
#include "msm_gpu.h"
|
|
#include "msm_gem.h"
|
|
#include "msm_mmu.h"
|
|
#include "msm_fence.h"
|
|
#include "msm_gpu_trace.h"
|
|
#include "adreno/adreno_gpu.h"
|
|
|
|
#include <generated/utsrelease.h>
|
|
#include <linux/string_helpers.h>
|
|
#include <linux/devcoredump.h>
|
|
#include <linux/sched/task.h>
|
|
|
|
/*
|
|
* Power Management:
|
|
*/
|
|
|
|
static int enable_pwrrail(struct msm_gpu *gpu)
|
|
{
|
|
struct drm_device *dev = gpu->dev;
|
|
int ret = 0;
|
|
|
|
if (gpu->gpu_reg) {
|
|
ret = regulator_enable(gpu->gpu_reg);
|
|
if (ret) {
|
|
DRM_DEV_ERROR(dev->dev, "failed to enable 'gpu_reg': %d\n", ret);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
if (gpu->gpu_cx) {
|
|
ret = regulator_enable(gpu->gpu_cx);
|
|
if (ret) {
|
|
DRM_DEV_ERROR(dev->dev, "failed to enable 'gpu_cx': %d\n", ret);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int disable_pwrrail(struct msm_gpu *gpu)
|
|
{
|
|
if (gpu->gpu_cx)
|
|
regulator_disable(gpu->gpu_cx);
|
|
if (gpu->gpu_reg)
|
|
regulator_disable(gpu->gpu_reg);
|
|
return 0;
|
|
}
|
|
|
|
static int enable_clk(struct msm_gpu *gpu)
|
|
{
|
|
if (gpu->core_clk && gpu->fast_rate)
|
|
dev_pm_opp_set_rate(&gpu->pdev->dev, gpu->fast_rate);
|
|
|
|
/* Set the RBBM timer rate to 19.2Mhz */
|
|
if (gpu->rbbmtimer_clk)
|
|
clk_set_rate(gpu->rbbmtimer_clk, 19200000);
|
|
|
|
return clk_bulk_prepare_enable(gpu->nr_clocks, gpu->grp_clks);
|
|
}
|
|
|
|
static int disable_clk(struct msm_gpu *gpu)
|
|
{
|
|
clk_bulk_disable_unprepare(gpu->nr_clocks, gpu->grp_clks);
|
|
|
|
/*
|
|
* Set the clock to a deliberately low rate. On older targets the clock
|
|
* speed had to be non zero to avoid problems. On newer targets this
|
|
* will be rounded down to zero anyway so it all works out.
|
|
*/
|
|
if (gpu->core_clk)
|
|
dev_pm_opp_set_rate(&gpu->pdev->dev, 27000000);
|
|
|
|
if (gpu->rbbmtimer_clk)
|
|
clk_set_rate(gpu->rbbmtimer_clk, 0);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int enable_axi(struct msm_gpu *gpu)
|
|
{
|
|
return clk_prepare_enable(gpu->ebi1_clk);
|
|
}
|
|
|
|
static int disable_axi(struct msm_gpu *gpu)
|
|
{
|
|
clk_disable_unprepare(gpu->ebi1_clk);
|
|
return 0;
|
|
}
|
|
|
|
int msm_gpu_pm_resume(struct msm_gpu *gpu)
|
|
{
|
|
int ret;
|
|
|
|
DBG("%s", gpu->name);
|
|
trace_msm_gpu_resume(0);
|
|
|
|
ret = enable_pwrrail(gpu);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = enable_clk(gpu);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = enable_axi(gpu);
|
|
if (ret)
|
|
return ret;
|
|
|
|
msm_devfreq_resume(gpu);
|
|
|
|
gpu->needs_hw_init = true;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int msm_gpu_pm_suspend(struct msm_gpu *gpu)
|
|
{
|
|
int ret;
|
|
|
|
DBG("%s", gpu->name);
|
|
trace_msm_gpu_suspend(0);
|
|
|
|
msm_devfreq_suspend(gpu);
|
|
|
|
ret = disable_axi(gpu);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = disable_clk(gpu);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = disable_pwrrail(gpu);
|
|
if (ret)
|
|
return ret;
|
|
|
|
gpu->suspend_count++;
|
|
|
|
return 0;
|
|
}
|
|
|
|
void msm_gpu_show_fdinfo(struct msm_gpu *gpu, struct msm_file_private *ctx,
|
|
struct drm_printer *p)
|
|
{
|
|
drm_printf(p, "drm-engine-gpu:\t%llu ns\n", ctx->elapsed_ns);
|
|
drm_printf(p, "drm-cycles-gpu:\t%llu\n", ctx->cycles);
|
|
drm_printf(p, "drm-maxfreq-gpu:\t%u Hz\n", gpu->fast_rate);
|
|
}
|
|
|
|
int msm_gpu_hw_init(struct msm_gpu *gpu)
|
|
{
|
|
int ret;
|
|
|
|
WARN_ON(!mutex_is_locked(&gpu->lock));
|
|
|
|
if (!gpu->needs_hw_init)
|
|
return 0;
|
|
|
|
disable_irq(gpu->irq);
|
|
ret = gpu->funcs->hw_init(gpu);
|
|
if (!ret)
|
|
gpu->needs_hw_init = false;
|
|
enable_irq(gpu->irq);
|
|
|
|
return ret;
|
|
}
|
|
|
|
#ifdef CONFIG_DEV_COREDUMP
|
|
static ssize_t msm_gpu_devcoredump_read(char *buffer, loff_t offset,
|
|
size_t count, void *data, size_t datalen)
|
|
{
|
|
struct msm_gpu *gpu = data;
|
|
struct drm_print_iterator iter;
|
|
struct drm_printer p;
|
|
struct msm_gpu_state *state;
|
|
|
|
state = msm_gpu_crashstate_get(gpu);
|
|
if (!state)
|
|
return 0;
|
|
|
|
iter.data = buffer;
|
|
iter.offset = 0;
|
|
iter.start = offset;
|
|
iter.remain = count;
|
|
|
|
p = drm_coredump_printer(&iter);
|
|
|
|
drm_printf(&p, "---\n");
|
|
drm_printf(&p, "kernel: " UTS_RELEASE "\n");
|
|
drm_printf(&p, "module: " KBUILD_MODNAME "\n");
|
|
drm_printf(&p, "time: %lld.%09ld\n",
|
|
state->time.tv_sec, state->time.tv_nsec);
|
|
if (state->comm)
|
|
drm_printf(&p, "comm: %s\n", state->comm);
|
|
if (state->cmd)
|
|
drm_printf(&p, "cmdline: %s\n", state->cmd);
|
|
|
|
gpu->funcs->show(gpu, state, &p);
|
|
|
|
msm_gpu_crashstate_put(gpu);
|
|
|
|
return count - iter.remain;
|
|
}
|
|
|
|
static void msm_gpu_devcoredump_free(void *data)
|
|
{
|
|
struct msm_gpu *gpu = data;
|
|
|
|
msm_gpu_crashstate_put(gpu);
|
|
}
|
|
|
|
static void msm_gpu_crashstate_get_bo(struct msm_gpu_state *state,
|
|
struct drm_gem_object *obj, u64 iova, bool full)
|
|
{
|
|
struct msm_gpu_state_bo *state_bo = &state->bos[state->nr_bos];
|
|
|
|
/* Don't record write only objects */
|
|
state_bo->size = obj->size;
|
|
state_bo->iova = iova;
|
|
|
|
BUILD_BUG_ON(sizeof(state_bo->name) != sizeof(to_msm_bo(obj)->name));
|
|
|
|
memcpy(state_bo->name, to_msm_bo(obj)->name, sizeof(state_bo->name));
|
|
|
|
if (full) {
|
|
void *ptr;
|
|
|
|
state_bo->data = kvmalloc(obj->size, GFP_KERNEL);
|
|
if (!state_bo->data)
|
|
goto out;
|
|
|
|
msm_gem_lock(obj);
|
|
ptr = msm_gem_get_vaddr_active(obj);
|
|
msm_gem_unlock(obj);
|
|
if (IS_ERR(ptr)) {
|
|
kvfree(state_bo->data);
|
|
state_bo->data = NULL;
|
|
goto out;
|
|
}
|
|
|
|
memcpy(state_bo->data, ptr, obj->size);
|
|
msm_gem_put_vaddr(obj);
|
|
}
|
|
out:
|
|
state->nr_bos++;
|
|
}
|
|
|
|
static void msm_gpu_crashstate_capture(struct msm_gpu *gpu,
|
|
struct msm_gem_submit *submit, char *comm, char *cmd)
|
|
{
|
|
struct msm_gpu_state *state;
|
|
|
|
/* Check if the target supports capturing crash state */
|
|
if (!gpu->funcs->gpu_state_get)
|
|
return;
|
|
|
|
/* Only save one crash state at a time */
|
|
if (gpu->crashstate)
|
|
return;
|
|
|
|
state = gpu->funcs->gpu_state_get(gpu);
|
|
if (IS_ERR_OR_NULL(state))
|
|
return;
|
|
|
|
/* Fill in the additional crash state information */
|
|
state->comm = kstrdup(comm, GFP_KERNEL);
|
|
state->cmd = kstrdup(cmd, GFP_KERNEL);
|
|
state->fault_info = gpu->fault_info;
|
|
|
|
if (submit) {
|
|
int i;
|
|
|
|
state->bos = kcalloc(submit->nr_bos,
|
|
sizeof(struct msm_gpu_state_bo), GFP_KERNEL);
|
|
|
|
for (i = 0; state->bos && i < submit->nr_bos; i++) {
|
|
msm_gpu_crashstate_get_bo(state, submit->bos[i].obj,
|
|
submit->bos[i].iova,
|
|
should_dump(submit, i));
|
|
}
|
|
}
|
|
|
|
/* Set the active crash state to be dumped on failure */
|
|
gpu->crashstate = state;
|
|
|
|
/* FIXME: Release the crashstate if this errors out? */
|
|
dev_coredumpm(gpu->dev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL,
|
|
msm_gpu_devcoredump_read, msm_gpu_devcoredump_free);
|
|
}
|
|
#else
|
|
static void msm_gpu_crashstate_capture(struct msm_gpu *gpu,
|
|
struct msm_gem_submit *submit, char *comm, char *cmd)
|
|
{
|
|
}
|
|
#endif
|
|
|
|
/*
|
|
* Hangcheck detection for locked gpu:
|
|
*/
|
|
|
|
static struct msm_gem_submit *
|
|
find_submit(struct msm_ringbuffer *ring, uint32_t fence)
|
|
{
|
|
struct msm_gem_submit *submit;
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&ring->submit_lock, flags);
|
|
list_for_each_entry(submit, &ring->submits, node) {
|
|
if (submit->seqno == fence) {
|
|
spin_unlock_irqrestore(&ring->submit_lock, flags);
|
|
return submit;
|
|
}
|
|
}
|
|
spin_unlock_irqrestore(&ring->submit_lock, flags);
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static void retire_submits(struct msm_gpu *gpu);
|
|
|
|
static void get_comm_cmdline(struct msm_gem_submit *submit, char **comm, char **cmd)
|
|
{
|
|
struct msm_file_private *ctx = submit->queue->ctx;
|
|
struct task_struct *task;
|
|
|
|
WARN_ON(!mutex_is_locked(&submit->gpu->lock));
|
|
|
|
/* Note that kstrdup will return NULL if argument is NULL: */
|
|
*comm = kstrdup(ctx->comm, GFP_KERNEL);
|
|
*cmd = kstrdup(ctx->cmdline, GFP_KERNEL);
|
|
|
|
task = get_pid_task(submit->pid, PIDTYPE_PID);
|
|
if (!task)
|
|
return;
|
|
|
|
if (!*comm)
|
|
*comm = kstrdup(task->comm, GFP_KERNEL);
|
|
|
|
if (!*cmd)
|
|
*cmd = kstrdup_quotable_cmdline(task, GFP_KERNEL);
|
|
|
|
put_task_struct(task);
|
|
}
|
|
|
|
static void recover_worker(struct kthread_work *work)
|
|
{
|
|
struct msm_gpu *gpu = container_of(work, struct msm_gpu, recover_work);
|
|
struct drm_device *dev = gpu->dev;
|
|
struct msm_drm_private *priv = dev->dev_private;
|
|
struct msm_gem_submit *submit;
|
|
struct msm_ringbuffer *cur_ring = gpu->funcs->active_ring(gpu);
|
|
char *comm = NULL, *cmd = NULL;
|
|
int i;
|
|
|
|
mutex_lock(&gpu->lock);
|
|
|
|
DRM_DEV_ERROR(dev->dev, "%s: hangcheck recover!\n", gpu->name);
|
|
|
|
submit = find_submit(cur_ring, cur_ring->memptrs->fence + 1);
|
|
if (submit) {
|
|
/* Increment the fault counts */
|
|
submit->queue->faults++;
|
|
if (submit->aspace)
|
|
submit->aspace->faults++;
|
|
|
|
get_comm_cmdline(submit, &comm, &cmd);
|
|
|
|
if (comm && cmd) {
|
|
DRM_DEV_ERROR(dev->dev, "%s: offending task: %s (%s)\n",
|
|
gpu->name, comm, cmd);
|
|
|
|
msm_rd_dump_submit(priv->hangrd, submit,
|
|
"offending task: %s (%s)", comm, cmd);
|
|
} else {
|
|
msm_rd_dump_submit(priv->hangrd, submit, NULL);
|
|
}
|
|
} else {
|
|
/*
|
|
* We couldn't attribute this fault to any particular context,
|
|
* so increment the global fault count instead.
|
|
*/
|
|
gpu->global_faults++;
|
|
}
|
|
|
|
/* Record the crash state */
|
|
pm_runtime_get_sync(&gpu->pdev->dev);
|
|
msm_gpu_crashstate_capture(gpu, submit, comm, cmd);
|
|
|
|
kfree(cmd);
|
|
kfree(comm);
|
|
|
|
/*
|
|
* Update all the rings with the latest and greatest fence.. this
|
|
* needs to happen after msm_rd_dump_submit() to ensure that the
|
|
* bo's referenced by the offending submit are still around.
|
|
*/
|
|
for (i = 0; i < gpu->nr_rings; i++) {
|
|
struct msm_ringbuffer *ring = gpu->rb[i];
|
|
|
|
uint32_t fence = ring->memptrs->fence;
|
|
|
|
/*
|
|
* For the current (faulting?) ring/submit advance the fence by
|
|
* one more to clear the faulting submit
|
|
*/
|
|
if (ring == cur_ring)
|
|
ring->memptrs->fence = ++fence;
|
|
|
|
msm_update_fence(ring->fctx, fence);
|
|
}
|
|
|
|
if (msm_gpu_active(gpu)) {
|
|
/* retire completed submits, plus the one that hung: */
|
|
retire_submits(gpu);
|
|
|
|
gpu->funcs->recover(gpu);
|
|
|
|
/*
|
|
* Replay all remaining submits starting with highest priority
|
|
* ring
|
|
*/
|
|
for (i = 0; i < gpu->nr_rings; i++) {
|
|
struct msm_ringbuffer *ring = gpu->rb[i];
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&ring->submit_lock, flags);
|
|
list_for_each_entry(submit, &ring->submits, node)
|
|
gpu->funcs->submit(gpu, submit);
|
|
spin_unlock_irqrestore(&ring->submit_lock, flags);
|
|
}
|
|
}
|
|
|
|
pm_runtime_put(&gpu->pdev->dev);
|
|
|
|
mutex_unlock(&gpu->lock);
|
|
|
|
msm_gpu_retire(gpu);
|
|
}
|
|
|
|
static void fault_worker(struct kthread_work *work)
|
|
{
|
|
struct msm_gpu *gpu = container_of(work, struct msm_gpu, fault_work);
|
|
struct msm_gem_submit *submit;
|
|
struct msm_ringbuffer *cur_ring = gpu->funcs->active_ring(gpu);
|
|
char *comm = NULL, *cmd = NULL;
|
|
|
|
mutex_lock(&gpu->lock);
|
|
|
|
submit = find_submit(cur_ring, cur_ring->memptrs->fence + 1);
|
|
if (submit && submit->fault_dumped)
|
|
goto resume_smmu;
|
|
|
|
if (submit) {
|
|
get_comm_cmdline(submit, &comm, &cmd);
|
|
|
|
/*
|
|
* When we get GPU iova faults, we can get 1000s of them,
|
|
* but we really only want to log the first one.
|
|
*/
|
|
submit->fault_dumped = true;
|
|
}
|
|
|
|
/* Record the crash state */
|
|
pm_runtime_get_sync(&gpu->pdev->dev);
|
|
msm_gpu_crashstate_capture(gpu, submit, comm, cmd);
|
|
pm_runtime_put_sync(&gpu->pdev->dev);
|
|
|
|
kfree(cmd);
|
|
kfree(comm);
|
|
|
|
resume_smmu:
|
|
memset(&gpu->fault_info, 0, sizeof(gpu->fault_info));
|
|
gpu->aspace->mmu->funcs->resume_translation(gpu->aspace->mmu);
|
|
|
|
mutex_unlock(&gpu->lock);
|
|
}
|
|
|
|
static void hangcheck_timer_reset(struct msm_gpu *gpu)
|
|
{
|
|
struct msm_drm_private *priv = gpu->dev->dev_private;
|
|
mod_timer(&gpu->hangcheck_timer,
|
|
round_jiffies_up(jiffies + msecs_to_jiffies(priv->hangcheck_period)));
|
|
}
|
|
|
|
static bool made_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring)
|
|
{
|
|
if (ring->hangcheck_progress_retries >= DRM_MSM_HANGCHECK_PROGRESS_RETRIES)
|
|
return false;
|
|
|
|
if (!gpu->funcs->progress)
|
|
return false;
|
|
|
|
if (!gpu->funcs->progress(gpu, ring))
|
|
return false;
|
|
|
|
ring->hangcheck_progress_retries++;
|
|
return true;
|
|
}
|
|
|
|
static void hangcheck_handler(struct timer_list *t)
|
|
{
|
|
struct msm_gpu *gpu = from_timer(gpu, t, hangcheck_timer);
|
|
struct drm_device *dev = gpu->dev;
|
|
struct msm_ringbuffer *ring = gpu->funcs->active_ring(gpu);
|
|
uint32_t fence = ring->memptrs->fence;
|
|
|
|
if (fence != ring->hangcheck_fence) {
|
|
/* some progress has been made.. ya! */
|
|
ring->hangcheck_fence = fence;
|
|
ring->hangcheck_progress_retries = 0;
|
|
} else if (fence_before(fence, ring->fctx->last_fence) &&
|
|
!made_progress(gpu, ring)) {
|
|
/* no progress and not done.. hung! */
|
|
ring->hangcheck_fence = fence;
|
|
ring->hangcheck_progress_retries = 0;
|
|
DRM_DEV_ERROR(dev->dev, "%s: hangcheck detected gpu lockup rb %d!\n",
|
|
gpu->name, ring->id);
|
|
DRM_DEV_ERROR(dev->dev, "%s: completed fence: %u\n",
|
|
gpu->name, fence);
|
|
DRM_DEV_ERROR(dev->dev, "%s: submitted fence: %u\n",
|
|
gpu->name, ring->fctx->last_fence);
|
|
|
|
kthread_queue_work(gpu->worker, &gpu->recover_work);
|
|
}
|
|
|
|
/* if still more pending work, reset the hangcheck timer: */
|
|
if (fence_after(ring->fctx->last_fence, ring->hangcheck_fence))
|
|
hangcheck_timer_reset(gpu);
|
|
|
|
/* workaround for missing irq: */
|
|
msm_gpu_retire(gpu);
|
|
}
|
|
|
|
/*
|
|
* Performance Counters:
|
|
*/
|
|
|
|
/* called under perf_lock */
|
|
static int update_hw_cntrs(struct msm_gpu *gpu, uint32_t ncntrs, uint32_t *cntrs)
|
|
{
|
|
uint32_t current_cntrs[ARRAY_SIZE(gpu->last_cntrs)];
|
|
int i, n = min(ncntrs, gpu->num_perfcntrs);
|
|
|
|
/* read current values: */
|
|
for (i = 0; i < gpu->num_perfcntrs; i++)
|
|
current_cntrs[i] = gpu_read(gpu, gpu->perfcntrs[i].sample_reg);
|
|
|
|
/* update cntrs: */
|
|
for (i = 0; i < n; i++)
|
|
cntrs[i] = current_cntrs[i] - gpu->last_cntrs[i];
|
|
|
|
/* save current values: */
|
|
for (i = 0; i < gpu->num_perfcntrs; i++)
|
|
gpu->last_cntrs[i] = current_cntrs[i];
|
|
|
|
return n;
|
|
}
|
|
|
|
static void update_sw_cntrs(struct msm_gpu *gpu)
|
|
{
|
|
ktime_t time;
|
|
uint32_t elapsed;
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&gpu->perf_lock, flags);
|
|
if (!gpu->perfcntr_active)
|
|
goto out;
|
|
|
|
time = ktime_get();
|
|
elapsed = ktime_to_us(ktime_sub(time, gpu->last_sample.time));
|
|
|
|
gpu->totaltime += elapsed;
|
|
if (gpu->last_sample.active)
|
|
gpu->activetime += elapsed;
|
|
|
|
gpu->last_sample.active = msm_gpu_active(gpu);
|
|
gpu->last_sample.time = time;
|
|
|
|
out:
|
|
spin_unlock_irqrestore(&gpu->perf_lock, flags);
|
|
}
|
|
|
|
void msm_gpu_perfcntr_start(struct msm_gpu *gpu)
|
|
{
|
|
unsigned long flags;
|
|
|
|
pm_runtime_get_sync(&gpu->pdev->dev);
|
|
|
|
spin_lock_irqsave(&gpu->perf_lock, flags);
|
|
/* we could dynamically enable/disable perfcntr registers too.. */
|
|
gpu->last_sample.active = msm_gpu_active(gpu);
|
|
gpu->last_sample.time = ktime_get();
|
|
gpu->activetime = gpu->totaltime = 0;
|
|
gpu->perfcntr_active = true;
|
|
update_hw_cntrs(gpu, 0, NULL);
|
|
spin_unlock_irqrestore(&gpu->perf_lock, flags);
|
|
}
|
|
|
|
void msm_gpu_perfcntr_stop(struct msm_gpu *gpu)
|
|
{
|
|
gpu->perfcntr_active = false;
|
|
pm_runtime_put_sync(&gpu->pdev->dev);
|
|
}
|
|
|
|
/* returns -errno or # of cntrs sampled */
|
|
int msm_gpu_perfcntr_sample(struct msm_gpu *gpu, uint32_t *activetime,
|
|
uint32_t *totaltime, uint32_t ncntrs, uint32_t *cntrs)
|
|
{
|
|
unsigned long flags;
|
|
int ret;
|
|
|
|
spin_lock_irqsave(&gpu->perf_lock, flags);
|
|
|
|
if (!gpu->perfcntr_active) {
|
|
ret = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
*activetime = gpu->activetime;
|
|
*totaltime = gpu->totaltime;
|
|
|
|
gpu->activetime = gpu->totaltime = 0;
|
|
|
|
ret = update_hw_cntrs(gpu, ncntrs, cntrs);
|
|
|
|
out:
|
|
spin_unlock_irqrestore(&gpu->perf_lock, flags);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/*
|
|
* Cmdstream submission/retirement:
|
|
*/
|
|
|
|
static void retire_submit(struct msm_gpu *gpu, struct msm_ringbuffer *ring,
|
|
struct msm_gem_submit *submit)
|
|
{
|
|
int index = submit->seqno % MSM_GPU_SUBMIT_STATS_COUNT;
|
|
volatile struct msm_gpu_submit_stats *stats;
|
|
u64 elapsed, clock = 0, cycles;
|
|
unsigned long flags;
|
|
|
|
stats = &ring->memptrs->stats[index];
|
|
/* Convert 19.2Mhz alwayson ticks to nanoseconds for elapsed time */
|
|
elapsed = (stats->alwayson_end - stats->alwayson_start) * 10000;
|
|
do_div(elapsed, 192);
|
|
|
|
cycles = stats->cpcycles_end - stats->cpcycles_start;
|
|
|
|
/* Calculate the clock frequency from the number of CP cycles */
|
|
if (elapsed) {
|
|
clock = cycles * 1000;
|
|
do_div(clock, elapsed);
|
|
}
|
|
|
|
submit->queue->ctx->elapsed_ns += elapsed;
|
|
submit->queue->ctx->cycles += cycles;
|
|
|
|
trace_msm_gpu_submit_retired(submit, elapsed, clock,
|
|
stats->alwayson_start, stats->alwayson_end);
|
|
|
|
msm_submit_retire(submit);
|
|
|
|
pm_runtime_mark_last_busy(&gpu->pdev->dev);
|
|
|
|
spin_lock_irqsave(&ring->submit_lock, flags);
|
|
list_del(&submit->node);
|
|
spin_unlock_irqrestore(&ring->submit_lock, flags);
|
|
|
|
/* Update devfreq on transition from active->idle: */
|
|
mutex_lock(&gpu->active_lock);
|
|
gpu->active_submits--;
|
|
WARN_ON(gpu->active_submits < 0);
|
|
if (!gpu->active_submits) {
|
|
msm_devfreq_idle(gpu);
|
|
pm_runtime_put_autosuspend(&gpu->pdev->dev);
|
|
}
|
|
|
|
mutex_unlock(&gpu->active_lock);
|
|
|
|
msm_gem_submit_put(submit);
|
|
}
|
|
|
|
static void retire_submits(struct msm_gpu *gpu)
|
|
{
|
|
int i;
|
|
|
|
/* Retire the commits starting with highest priority */
|
|
for (i = 0; i < gpu->nr_rings; i++) {
|
|
struct msm_ringbuffer *ring = gpu->rb[i];
|
|
|
|
while (true) {
|
|
struct msm_gem_submit *submit = NULL;
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&ring->submit_lock, flags);
|
|
submit = list_first_entry_or_null(&ring->submits,
|
|
struct msm_gem_submit, node);
|
|
spin_unlock_irqrestore(&ring->submit_lock, flags);
|
|
|
|
/*
|
|
* If no submit, we are done. If submit->fence hasn't
|
|
* been signalled, then later submits are not signalled
|
|
* either, so we are also done.
|
|
*/
|
|
if (submit && dma_fence_is_signaled(submit->hw_fence)) {
|
|
retire_submit(gpu, ring, submit);
|
|
} else {
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
wake_up_all(&gpu->retire_event);
|
|
}
|
|
|
|
static void retire_worker(struct kthread_work *work)
|
|
{
|
|
struct msm_gpu *gpu = container_of(work, struct msm_gpu, retire_work);
|
|
|
|
retire_submits(gpu);
|
|
}
|
|
|
|
/* call from irq handler to schedule work to retire bo's */
|
|
void msm_gpu_retire(struct msm_gpu *gpu)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < gpu->nr_rings; i++)
|
|
msm_update_fence(gpu->rb[i]->fctx, gpu->rb[i]->memptrs->fence);
|
|
|
|
kthread_queue_work(gpu->worker, &gpu->retire_work);
|
|
update_sw_cntrs(gpu);
|
|
}
|
|
|
|
/* add bo's to gpu's ring, and kick gpu: */
|
|
void msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit)
|
|
{
|
|
struct msm_ringbuffer *ring = submit->ring;
|
|
unsigned long flags;
|
|
|
|
pm_runtime_get_sync(&gpu->pdev->dev);
|
|
|
|
mutex_lock(&gpu->lock);
|
|
|
|
msm_gpu_hw_init(gpu);
|
|
|
|
update_sw_cntrs(gpu);
|
|
|
|
/*
|
|
* ring->submits holds a ref to the submit, to deal with the case
|
|
* that a submit completes before msm_ioctl_gem_submit() returns.
|
|
*/
|
|
msm_gem_submit_get(submit);
|
|
|
|
spin_lock_irqsave(&ring->submit_lock, flags);
|
|
list_add_tail(&submit->node, &ring->submits);
|
|
spin_unlock_irqrestore(&ring->submit_lock, flags);
|
|
|
|
/* Update devfreq on transition from idle->active: */
|
|
mutex_lock(&gpu->active_lock);
|
|
if (!gpu->active_submits) {
|
|
pm_runtime_get(&gpu->pdev->dev);
|
|
msm_devfreq_active(gpu);
|
|
}
|
|
gpu->active_submits++;
|
|
mutex_unlock(&gpu->active_lock);
|
|
|
|
gpu->funcs->submit(gpu, submit);
|
|
gpu->cur_ctx_seqno = submit->queue->ctx->seqno;
|
|
|
|
hangcheck_timer_reset(gpu);
|
|
|
|
mutex_unlock(&gpu->lock);
|
|
|
|
pm_runtime_put(&gpu->pdev->dev);
|
|
}
|
|
|
|
/*
|
|
* Init/Cleanup:
|
|
*/
|
|
|
|
static irqreturn_t irq_handler(int irq, void *data)
|
|
{
|
|
struct msm_gpu *gpu = data;
|
|
return gpu->funcs->irq(gpu);
|
|
}
|
|
|
|
static int get_clocks(struct platform_device *pdev, struct msm_gpu *gpu)
|
|
{
|
|
int ret = devm_clk_bulk_get_all(&pdev->dev, &gpu->grp_clks);
|
|
|
|
if (ret < 1) {
|
|
gpu->nr_clocks = 0;
|
|
return ret;
|
|
}
|
|
|
|
gpu->nr_clocks = ret;
|
|
|
|
gpu->core_clk = msm_clk_bulk_get_clock(gpu->grp_clks,
|
|
gpu->nr_clocks, "core");
|
|
|
|
gpu->rbbmtimer_clk = msm_clk_bulk_get_clock(gpu->grp_clks,
|
|
gpu->nr_clocks, "rbbmtimer");
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* Return a new address space for a msm_drm_private instance */
|
|
struct msm_gem_address_space *
|
|
msm_gpu_create_private_address_space(struct msm_gpu *gpu, struct task_struct *task)
|
|
{
|
|
struct msm_gem_address_space *aspace = NULL;
|
|
if (!gpu)
|
|
return NULL;
|
|
|
|
/*
|
|
* If the target doesn't support private address spaces then return
|
|
* the global one
|
|
*/
|
|
if (gpu->funcs->create_private_address_space) {
|
|
aspace = gpu->funcs->create_private_address_space(gpu);
|
|
if (!IS_ERR(aspace))
|
|
aspace->pid = get_pid(task_pid(task));
|
|
}
|
|
|
|
if (IS_ERR_OR_NULL(aspace))
|
|
aspace = msm_gem_address_space_get(gpu->aspace);
|
|
|
|
return aspace;
|
|
}
|
|
|
|
int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev,
|
|
struct msm_gpu *gpu, const struct msm_gpu_funcs *funcs,
|
|
const char *name, struct msm_gpu_config *config)
|
|
{
|
|
struct msm_drm_private *priv = drm->dev_private;
|
|
int i, ret, nr_rings = config->nr_rings;
|
|
void *memptrs;
|
|
uint64_t memptrs_iova;
|
|
|
|
if (WARN_ON(gpu->num_perfcntrs > ARRAY_SIZE(gpu->last_cntrs)))
|
|
gpu->num_perfcntrs = ARRAY_SIZE(gpu->last_cntrs);
|
|
|
|
gpu->dev = drm;
|
|
gpu->funcs = funcs;
|
|
gpu->name = name;
|
|
|
|
gpu->worker = kthread_create_worker(0, "gpu-worker");
|
|
if (IS_ERR(gpu->worker)) {
|
|
ret = PTR_ERR(gpu->worker);
|
|
gpu->worker = NULL;
|
|
goto fail;
|
|
}
|
|
|
|
sched_set_fifo_low(gpu->worker->task);
|
|
|
|
mutex_init(&gpu->active_lock);
|
|
mutex_init(&gpu->lock);
|
|
init_waitqueue_head(&gpu->retire_event);
|
|
kthread_init_work(&gpu->retire_work, retire_worker);
|
|
kthread_init_work(&gpu->recover_work, recover_worker);
|
|
kthread_init_work(&gpu->fault_work, fault_worker);
|
|
|
|
priv->hangcheck_period = DRM_MSM_HANGCHECK_DEFAULT_PERIOD;
|
|
|
|
/*
|
|
* If progress detection is supported, halve the hangcheck timer
|
|
* duration, as it takes two iterations of the hangcheck handler
|
|
* to detect a hang.
|
|
*/
|
|
if (funcs->progress)
|
|
priv->hangcheck_period /= 2;
|
|
|
|
timer_setup(&gpu->hangcheck_timer, hangcheck_handler, 0);
|
|
|
|
spin_lock_init(&gpu->perf_lock);
|
|
|
|
|
|
/* Map registers: */
|
|
gpu->mmio = msm_ioremap(pdev, config->ioname);
|
|
if (IS_ERR(gpu->mmio)) {
|
|
ret = PTR_ERR(gpu->mmio);
|
|
goto fail;
|
|
}
|
|
|
|
/* Get Interrupt: */
|
|
gpu->irq = platform_get_irq(pdev, 0);
|
|
if (gpu->irq < 0) {
|
|
ret = gpu->irq;
|
|
goto fail;
|
|
}
|
|
|
|
ret = devm_request_irq(&pdev->dev, gpu->irq, irq_handler,
|
|
IRQF_TRIGGER_HIGH, "gpu-irq", gpu);
|
|
if (ret) {
|
|
DRM_DEV_ERROR(drm->dev, "failed to request IRQ%u: %d\n", gpu->irq, ret);
|
|
goto fail;
|
|
}
|
|
|
|
ret = get_clocks(pdev, gpu);
|
|
if (ret)
|
|
goto fail;
|
|
|
|
gpu->ebi1_clk = msm_clk_get(pdev, "bus");
|
|
DBG("ebi1_clk: %p", gpu->ebi1_clk);
|
|
if (IS_ERR(gpu->ebi1_clk))
|
|
gpu->ebi1_clk = NULL;
|
|
|
|
/* Acquire regulators: */
|
|
gpu->gpu_reg = devm_regulator_get(&pdev->dev, "vdd");
|
|
DBG("gpu_reg: %p", gpu->gpu_reg);
|
|
if (IS_ERR(gpu->gpu_reg))
|
|
gpu->gpu_reg = NULL;
|
|
|
|
gpu->gpu_cx = devm_regulator_get(&pdev->dev, "vddcx");
|
|
DBG("gpu_cx: %p", gpu->gpu_cx);
|
|
if (IS_ERR(gpu->gpu_cx))
|
|
gpu->gpu_cx = NULL;
|
|
|
|
gpu->pdev = pdev;
|
|
platform_set_drvdata(pdev, &gpu->adreno_smmu);
|
|
|
|
msm_devfreq_init(gpu);
|
|
|
|
|
|
gpu->aspace = gpu->funcs->create_address_space(gpu, pdev);
|
|
|
|
if (gpu->aspace == NULL)
|
|
DRM_DEV_INFO(drm->dev, "%s: no IOMMU, fallback to VRAM carveout!\n", name);
|
|
else if (IS_ERR(gpu->aspace)) {
|
|
ret = PTR_ERR(gpu->aspace);
|
|
goto fail;
|
|
}
|
|
|
|
memptrs = msm_gem_kernel_new(drm,
|
|
sizeof(struct msm_rbmemptrs) * nr_rings,
|
|
check_apriv(gpu, MSM_BO_WC), gpu->aspace, &gpu->memptrs_bo,
|
|
&memptrs_iova);
|
|
|
|
if (IS_ERR(memptrs)) {
|
|
ret = PTR_ERR(memptrs);
|
|
DRM_DEV_ERROR(drm->dev, "could not allocate memptrs: %d\n", ret);
|
|
goto fail;
|
|
}
|
|
|
|
msm_gem_object_set_name(gpu->memptrs_bo, "memptrs");
|
|
|
|
if (nr_rings > ARRAY_SIZE(gpu->rb)) {
|
|
DRM_DEV_INFO_ONCE(drm->dev, "Only creating %zu ringbuffers\n",
|
|
ARRAY_SIZE(gpu->rb));
|
|
nr_rings = ARRAY_SIZE(gpu->rb);
|
|
}
|
|
|
|
/* Create ringbuffer(s): */
|
|
for (i = 0; i < nr_rings; i++) {
|
|
gpu->rb[i] = msm_ringbuffer_new(gpu, i, memptrs, memptrs_iova);
|
|
|
|
if (IS_ERR(gpu->rb[i])) {
|
|
ret = PTR_ERR(gpu->rb[i]);
|
|
DRM_DEV_ERROR(drm->dev,
|
|
"could not create ringbuffer %d: %d\n", i, ret);
|
|
goto fail;
|
|
}
|
|
|
|
memptrs += sizeof(struct msm_rbmemptrs);
|
|
memptrs_iova += sizeof(struct msm_rbmemptrs);
|
|
}
|
|
|
|
gpu->nr_rings = nr_rings;
|
|
|
|
refcount_set(&gpu->sysprof_active, 1);
|
|
|
|
return 0;
|
|
|
|
fail:
|
|
for (i = 0; i < ARRAY_SIZE(gpu->rb); i++) {
|
|
msm_ringbuffer_destroy(gpu->rb[i]);
|
|
gpu->rb[i] = NULL;
|
|
}
|
|
|
|
msm_gem_kernel_put(gpu->memptrs_bo, gpu->aspace);
|
|
|
|
platform_set_drvdata(pdev, NULL);
|
|
return ret;
|
|
}
|
|
|
|
void msm_gpu_cleanup(struct msm_gpu *gpu)
|
|
{
|
|
int i;
|
|
|
|
DBG("%s", gpu->name);
|
|
|
|
for (i = 0; i < ARRAY_SIZE(gpu->rb); i++) {
|
|
msm_ringbuffer_destroy(gpu->rb[i]);
|
|
gpu->rb[i] = NULL;
|
|
}
|
|
|
|
msm_gem_kernel_put(gpu->memptrs_bo, gpu->aspace);
|
|
|
|
if (!IS_ERR_OR_NULL(gpu->aspace)) {
|
|
gpu->aspace->mmu->funcs->detach(gpu->aspace->mmu);
|
|
msm_gem_address_space_put(gpu->aspace);
|
|
}
|
|
|
|
if (gpu->worker) {
|
|
kthread_destroy_worker(gpu->worker);
|
|
}
|
|
|
|
msm_devfreq_cleanup(gpu);
|
|
|
|
platform_set_drvdata(gpu->pdev, NULL);
|
|
}
|