1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/hid/bpf/progs
Luis Felipe Hernandez 9e16bada92 hid: bpf: Fix grammar
* spelling fix: XBox -> Xbox, lowercase 'b' as per Microsoft branding
* rephrase: paddle -> paddles, the controller itself has more than one paddle
* rephrase: replace usage of "those" in favor of explicitly making reference
  to the paddles
* grammatical fix: report -> reports, use present tense verb.
* spelling fix: interpret
* consistency: capitalize the first word in bullet points

Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
Link: https://patch.msgid.link/20240625105553.50830-1-luis.hernandez093@gmail.com
[bentiss: renamed the file into Xbox, not XBox]
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
2024-06-27 09:21:40 +02:00
..
FR-TEC__Raptor-Mach-2.bpf.c HID: bpf: convert in-tree fixes into struct_ops 2024-06-14 11:20:20 +02:00
hid_bpf.h HID: bpf: convert in-tree fixes into struct_ops 2024-06-14 11:20:20 +02:00
hid_bpf_helpers.h HID: bpf: add first in-tree HID-BPF fix for the XPPen Artist 24 2024-05-07 15:38:53 +02:00
HP__Elite-Presenter.bpf.c HID: bpf: convert in-tree fixes into struct_ops 2024-06-14 11:20:20 +02:00
Huion__Kamvas-Pro-19.bpf.c HID: bpf: convert in-tree fixes into struct_ops 2024-06-14 11:20:20 +02:00
IOGEAR__Kaliber-MMOmentum.bpf.c HID: bpf: convert in-tree fixes into struct_ops 2024-06-14 11:20:20 +02:00
Makefile HID: bpf: error on warnings when compiling bpf objects 2024-06-14 11:20:20 +02:00
Microsoft__Xbox-Elite-2.bpf.c hid: bpf: Fix grammar 2024-06-27 09:21:40 +02:00
README HID: bpf: add first in-tree HID-BPF fix for the XPPen Artist 24 2024-05-07 15:38:53 +02:00
Wacom__ArtPen.bpf.c HID: bpf: convert in-tree fixes into struct_ops 2024-06-14 11:20:20 +02:00
XPPen__Artist24.bpf.c HID: bpf: Artist24: remove unused variable 2024-06-14 11:20:20 +02:00
XPPen__ArtistPro16Gen2.bpf.c HID: bpf: convert in-tree fixes into struct_ops 2024-06-14 11:20:20 +02:00

# HID-BPF programs

This directory contains various fixes for devices. They add new features or
fix some behaviors without being entirely mandatory. It is better to load them
when you have such a device, but they should not be a requirement for a device
to be working during the boot stage.

The .bpf.c files provided here are not automatically compiled in the kernel.
They should be loaded in the kernel by `udev-hid-bpf`:

https://gitlab.freedesktop.org/libevdev/udev-hid-bpf

The main reasons for these fixes to be here is to have a central place to
"upstream" them, but also this way we can test them thanks to the HID
selftests.

Once a .bpf.c file is accepted here, it is duplicated in `udev-hid-bpf`
in the `src/bpf/stable` directory, and distributions are encouraged to
only ship those bpf objects. So adding a file here should eventually
land in distributions when they update `udev-hid-bpf`

## Compilation

Just run `make`

## Installation

### Automated way

Just run `sudo udev-hid-bpf install ./my-awesome-fix.bpf.o`

### Manual way

- copy the `.bpf.o` you want in `/etc/udev-hid-bpf/`
- create a new udev rule to automatically load it

The following should do the trick (assuming udev-hid-bpf is available in
/usr/bin):

```
$> cp xppen-ArtistPro16Gen2.bpf.o /etc/udev-hid-bpf/
$> udev-hid-bpf inspect xppen-ArtistPro16Gen2.bpf.o
[
  {
    "name": "xppen-ArtistPro16Gen2.bpf.o",
    "devices": [
      {
        "bus": "0x0003",
        "group": "0x0001",
        "vid": "0x28BD",
        "pid": "0x095A"
      },
      {
        "bus": "0x0003",
        "group": "0x0001",
        "vid": "0x28BD",
        "pid": "0x095B"
      }
    ],
...
$> cat <EOF > /etc/udev/rules.d/99-load-hid-bpf-xppen-ArtistPro16Gen2.rules
ACTION!="add|remove", GOTO="hid_bpf_end"
SUBSYSTEM!="hid", GOTO="hid_bpf_end"

# xppen-ArtistPro16Gen2.bpf.o
ACTION=="add",ENV{MODALIAS}=="hid:b0003g0001v000028BDp0000095A", RUN{program}+="/usr/local/bin/udev-hid-bpf add $sys$devpath /etc/udev-hid-bpf/xppen-ArtistPro16Gen2.bpf.o"
ACTION=="remove",ENV{MODALIAS}=="hid:b0003g0001v000028BDp0000095A", RUN{program}+="/usr/local/bin/udev-hid-bpf remove $sys$devpath "
# xppen-ArtistPro16Gen2.bpf.o
ACTION=="add",ENV{MODALIAS}=="hid:b0003g0001v000028BDp0000095B", RUN{program}+="/usr/local/bin/udev-hid-bpf add $sys$devpath /etc/udev-hid-bpf/xppen-ArtistPro16Gen2.bpf.o"
ACTION=="remove",ENV{MODALIAS}=="hid:b0003g0001v000028BDp0000095B", RUN{program}+="/usr/local/bin/udev-hid-bpf remove $sys$devpath "

LABEL="hid_bpf_end"
EOF
$> udevadm control --reload
```

Then unplug and replug the device.

## Checks

### udev rule

You can check that the udev rule is correctly working by issuing

```
$> udevadm test /sys/bus/hid/devices/0003:28BD:095B*
...
run: '/usr/local/bin/udev-hid-bpf add /sys/devices/virtual/misc/uhid/0003:28BD:095B.0E57 /etc/udev-hid-bpf/xppen-ArtistPro16Gen2.bpf.o'
```

### program loaded

You can check that the program has been properly loaded with `bpftool`

```
$> bpftool prog
...
247: tracing  name xppen_16_fix_eraser tag 18d389353ed2ef07  gpl
	loaded_at 2024-03-28T16:02:28+0100  uid 0
	xlated 120B  jited 77B  memlock 4096B
	btf_id 487
```