0433ae556e
The GEO_TX_POWER_LIMIT command was sent although
there is no wgds table, so the fw got wrong SAR values
from the driver.
Fix this by avoiding sending the command if no wgds
tables are available.
Signed-off-by: Golan Ben Ami <golan.ben.ami@intel.com>
Fixes: 39c1a9728f ("iwlwifi: refactor the SAR tables from mvm to acpi")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Tested-By: Jonathan McDowell <noodles@earth.li>
Tested-by: Len Brown <len.brown@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/iwlwifi.20200318081237.46db40617cc6.Id5cf852ec8c5dbf20ba86bad7b165a0c828f8b2e@changeid
254 lines
7.3 KiB
C
254 lines
7.3 KiB
C
/******************************************************************************
|
|
*
|
|
* This file is provided under a dual BSD/GPLv2 license. When using or
|
|
* redistributing this file, you may do so under either license.
|
|
*
|
|
* GPL LICENSE SUMMARY
|
|
*
|
|
* Copyright(c) 2017 Intel Deutschland GmbH
|
|
* Copyright(c) 2018 - 2020 Intel Corporation
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of version 2 of the GNU General Public License as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* The full GNU General Public License is included in this distribution
|
|
* in the file called COPYING.
|
|
*
|
|
* Contact Information:
|
|
* Intel Linux Wireless <linuxwifi@intel.com>
|
|
* Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
|
|
*
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright(c) 2017 Intel Deutschland GmbH
|
|
* Copyright(c) 2018 - 2020 Intel Corporation
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
*****************************************************************************/
|
|
#ifndef __iwl_fw_acpi__
|
|
#define __iwl_fw_acpi__
|
|
|
|
#include <linux/acpi.h>
|
|
#include "fw/api/commands.h"
|
|
#include "fw/api/power.h"
|
|
#include "fw/api/phy.h"
|
|
#include "fw/img.h"
|
|
#include "iwl-trans.h"
|
|
|
|
|
|
#define ACPI_WRDS_METHOD "WRDS"
|
|
#define ACPI_EWRD_METHOD "EWRD"
|
|
#define ACPI_WGDS_METHOD "WGDS"
|
|
#define ACPI_WRDD_METHOD "WRDD"
|
|
#define ACPI_SPLC_METHOD "SPLC"
|
|
#define ACPI_ECKV_METHOD "ECKV"
|
|
#define ACPI_PPAG_METHOD "PPAG"
|
|
|
|
#define ACPI_WIFI_DOMAIN (0x07)
|
|
|
|
#define ACPI_SAR_TABLE_SIZE 10
|
|
#define ACPI_SAR_PROFILE_NUM 4
|
|
|
|
#define ACPI_GEO_TABLE_SIZE 6
|
|
#define ACPI_NUM_GEO_PROFILES 3
|
|
#define ACPI_GEO_PER_CHAIN_SIZE 3
|
|
|
|
#define ACPI_SAR_NUM_CHAIN_LIMITS 2
|
|
#define ACPI_SAR_NUM_SUB_BANDS 5
|
|
|
|
#define ACPI_WRDS_WIFI_DATA_SIZE (ACPI_SAR_TABLE_SIZE + 2)
|
|
#define ACPI_EWRD_WIFI_DATA_SIZE ((ACPI_SAR_PROFILE_NUM - 1) * \
|
|
ACPI_SAR_TABLE_SIZE + 3)
|
|
#define ACPI_WGDS_WIFI_DATA_SIZE 19
|
|
#define ACPI_WRDD_WIFI_DATA_SIZE 2
|
|
#define ACPI_SPLC_WIFI_DATA_SIZE 2
|
|
#define ACPI_ECKV_WIFI_DATA_SIZE 2
|
|
|
|
#define ACPI_WGDS_NUM_BANDS 2
|
|
#define ACPI_WGDS_TABLE_SIZE 3
|
|
|
|
#define ACPI_PPAG_NUM_CHAINS 2
|
|
#define ACPI_PPAG_NUM_SUB_BANDS 5
|
|
#define ACPI_PPAG_WIFI_DATA_SIZE ((ACPI_PPAG_NUM_CHAINS * \
|
|
ACPI_PPAG_NUM_SUB_BANDS) + 3)
|
|
|
|
/* PPAG gain value bounds in 1/8 dBm */
|
|
#define ACPI_PPAG_MIN_LB -16
|
|
#define ACPI_PPAG_MAX_LB 24
|
|
#define ACPI_PPAG_MIN_HB -16
|
|
#define ACPI_PPAG_MAX_HB 40
|
|
|
|
struct iwl_sar_profile {
|
|
bool enabled;
|
|
u8 table[ACPI_SAR_TABLE_SIZE];
|
|
};
|
|
|
|
struct iwl_geo_profile {
|
|
u8 values[ACPI_GEO_TABLE_SIZE];
|
|
};
|
|
|
|
#ifdef CONFIG_ACPI
|
|
|
|
struct iwl_fw_runtime;
|
|
|
|
void *iwl_acpi_get_object(struct device *dev, acpi_string method);
|
|
|
|
union acpi_object *iwl_acpi_get_wifi_pkg(struct device *dev,
|
|
union acpi_object *data,
|
|
int data_size, int *tbl_rev);
|
|
|
|
/**
|
|
* iwl_acpi_get_mcc - read MCC from ACPI, if available
|
|
*
|
|
* @dev: the struct device
|
|
* @mcc: output buffer (3 bytes) that will get the MCC
|
|
*
|
|
* This function tries to read the current MCC from ACPI if available.
|
|
*/
|
|
int iwl_acpi_get_mcc(struct device *dev, char *mcc);
|
|
|
|
u64 iwl_acpi_get_pwr_limit(struct device *dev);
|
|
|
|
/*
|
|
* iwl_acpi_get_eckv - read external clock validation from ACPI, if available
|
|
*
|
|
* @dev: the struct device
|
|
* @extl_clk: output var (2 bytes) that will get the clk indication.
|
|
*
|
|
* This function tries to read the external clock indication
|
|
* from ACPI if available.
|
|
*/
|
|
int iwl_acpi_get_eckv(struct device *dev, u32 *extl_clk);
|
|
|
|
int iwl_sar_set_profile(union acpi_object *table,
|
|
struct iwl_sar_profile *profile,
|
|
bool enabled);
|
|
|
|
int iwl_sar_select_profile(struct iwl_fw_runtime *fwrt,
|
|
__le16 per_chain_restriction[][IWL_NUM_SUB_BANDS],
|
|
int prof_a, int prof_b);
|
|
|
|
int iwl_sar_get_wrds_table(struct iwl_fw_runtime *fwrt);
|
|
|
|
int iwl_sar_get_ewrd_table(struct iwl_fw_runtime *fwrt);
|
|
|
|
int iwl_sar_get_wgds_table(struct iwl_fw_runtime *fwrt);
|
|
|
|
bool iwl_sar_geo_support(struct iwl_fw_runtime *fwrt);
|
|
|
|
int iwl_validate_sar_geo_profile(struct iwl_fw_runtime *fwrt,
|
|
struct iwl_host_cmd *cmd);
|
|
|
|
int iwl_sar_geo_init(struct iwl_fw_runtime *fwrt,
|
|
struct iwl_per_chain_offset_group *table);
|
|
|
|
#else /* CONFIG_ACPI */
|
|
|
|
static inline void *iwl_acpi_get_object(struct device *dev, acpi_string method)
|
|
{
|
|
return ERR_PTR(-ENOENT);
|
|
}
|
|
|
|
static inline union acpi_object *iwl_acpi_get_wifi_pkg(struct device *dev,
|
|
union acpi_object *data,
|
|
int data_size,
|
|
int *tbl_rev)
|
|
{
|
|
return ERR_PTR(-ENOENT);
|
|
}
|
|
|
|
static inline int iwl_acpi_get_mcc(struct device *dev, char *mcc)
|
|
{
|
|
return -ENOENT;
|
|
}
|
|
|
|
static inline u64 iwl_acpi_get_pwr_limit(struct device *dev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int iwl_acpi_get_eckv(struct device *dev, u32 *extl_clk)
|
|
{
|
|
return -ENOENT;
|
|
}
|
|
|
|
static inline int iwl_sar_set_profile(union acpi_object *table,
|
|
struct iwl_sar_profile *profile,
|
|
bool enabled)
|
|
{
|
|
return -ENOENT;
|
|
}
|
|
|
|
static inline int iwl_sar_select_profile(struct iwl_fw_runtime *fwrt,
|
|
__le16 per_chain_restriction[][IWL_NUM_SUB_BANDS],
|
|
int prof_a, int prof_b)
|
|
{
|
|
return -ENOENT;
|
|
}
|
|
|
|
static inline int iwl_sar_get_wrds_table(struct iwl_fw_runtime *fwrt)
|
|
{
|
|
return -ENOENT;
|
|
}
|
|
|
|
static inline int iwl_sar_get_ewrd_table(struct iwl_fw_runtime *fwrt)
|
|
{
|
|
return -ENOENT;
|
|
}
|
|
|
|
static inline int iwl_sar_get_wgds_table(struct iwl_fw_runtime *fwrt)
|
|
{
|
|
return -ENOENT;
|
|
}
|
|
|
|
static inline bool iwl_sar_geo_support(struct iwl_fw_runtime *fwrt)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
static inline int iwl_validate_sar_geo_profile(struct iwl_fw_runtime *fwrt,
|
|
struct iwl_host_cmd *cmd)
|
|
{
|
|
return -ENOENT;
|
|
}
|
|
|
|
static inline int iwl_sar_geo_init(struct iwl_fw_runtime *fwrt,
|
|
struct iwl_per_chain_offset_group *table)
|
|
{
|
|
return -ENOENT;
|
|
}
|
|
|
|
#endif /* CONFIG_ACPI */
|
|
#endif /* __iwl_fw_acpi__ */
|