The WA from commit2a50edbf10
("drm/amd/display: Apply w/a for hard hang on HPD") and commit1bd3bc745e
("drm/amd/display: Extend w/a for hard hang on HPD to dcn20") causes a regression in s0ix where the system will fail to resume properly on many laptops. Pull the workarounds out to avoid that s0ix regression in the common case. This HPD hang happens with an external device in special circumstances and a new W/A will need to be developed for this in the future. Cc: Qingqing Zhuo <qingqing.zhuo@amd.com> Reported-by: Scott Bruce <smbruce@gmail.com> Reported-by: Chris Hixon <linux-kernel-bugs@hixontech.com> Reported-by: spasswolf@web.de Link: https://bugzilla.kernel.org/show_bug.cgi?id=215436 Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1821 Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1852 Fixes:2a50edbf10
("drm/amd/display: Apply w/a for hard hang on HPD") Fixes:1bd3bc745e
("drm/amd/display: Extend w/a for hard hang on HPD to dcn20") Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
85 lines
2.4 KiB
C
85 lines
2.4 KiB
C
/*
|
|
* Copyright 2012-15 Advanced Micro Devices, Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* Authors: AMD
|
|
*
|
|
*/
|
|
|
|
#ifndef __DAL_IRQ_SERVICE_H__
|
|
#define __DAL_IRQ_SERVICE_H__
|
|
|
|
#include "include/irq_service_interface.h"
|
|
|
|
#include "irq_types.h"
|
|
|
|
struct irq_service;
|
|
struct irq_source_info;
|
|
|
|
struct irq_source_info_funcs {
|
|
bool (*set)(
|
|
struct irq_service *irq_service,
|
|
const struct irq_source_info *info,
|
|
bool enable);
|
|
bool (*ack)(
|
|
struct irq_service *irq_service,
|
|
const struct irq_source_info *info);
|
|
};
|
|
|
|
struct irq_source_info {
|
|
uint32_t src_id;
|
|
uint32_t ext_id;
|
|
uint32_t enable_reg;
|
|
uint32_t enable_mask;
|
|
uint32_t enable_value[2];
|
|
uint32_t ack_reg;
|
|
uint32_t ack_mask;
|
|
uint32_t ack_value;
|
|
uint32_t status_reg;
|
|
const struct irq_source_info_funcs *funcs;
|
|
};
|
|
|
|
struct irq_service_funcs {
|
|
enum dc_irq_source (*to_dal_irq_source)(
|
|
struct irq_service *irq_service,
|
|
uint32_t src_id,
|
|
uint32_t ext_id);
|
|
};
|
|
|
|
struct irq_service {
|
|
struct dc_context *ctx;
|
|
const struct irq_source_info *info;
|
|
const struct irq_service_funcs *funcs;
|
|
};
|
|
|
|
void dal_irq_service_construct(
|
|
struct irq_service *irq_service,
|
|
struct irq_service_init_data *init_data);
|
|
|
|
void dal_irq_service_ack_generic(
|
|
struct irq_service *irq_service,
|
|
const struct irq_source_info *info);
|
|
|
|
void dal_irq_service_set_generic(
|
|
struct irq_service *irq_service,
|
|
const struct irq_source_info *info,
|
|
bool enable);
|
|
|
|
#endif
|