4c29e80ab8
Linking an object file into multiple modules is not supported
and causes a W=1 warning:
scripts/Makefile.build:236: drivers/platform/x86/intel/int3472/Makefile: common.o is added to multiple modules: intel_skl_int3472_discrete intel_skl_int3472_tps68470
Split out the common part here into a separate module to make it
more reliable.
Fixes: a2f9fbc247 ("platform/x86: int3472: Split into 2 drivers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240529095009.1895618-1-arnd@kernel.org
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
89 lines
2.1 KiB
C
89 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/* Author: Dan Scally <djrscally@gmail.com> */
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include "common.h"
|
|
|
|
union acpi_object *skl_int3472_get_acpi_buffer(struct acpi_device *adev, char *id)
|
|
{
|
|
struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
|
|
acpi_handle handle = adev->handle;
|
|
union acpi_object *obj;
|
|
acpi_status status;
|
|
|
|
status = acpi_evaluate_object(handle, id, NULL, &buffer);
|
|
if (ACPI_FAILURE(status))
|
|
return ERR_PTR(-ENODEV);
|
|
|
|
obj = buffer.pointer;
|
|
if (!obj)
|
|
return ERR_PTR(-ENODEV);
|
|
|
|
if (obj->type != ACPI_TYPE_BUFFER) {
|
|
acpi_handle_err(handle, "%s object is not an ACPI buffer\n", id);
|
|
kfree(obj);
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
|
|
return obj;
|
|
}
|
|
EXPORT_SYMBOL_GPL(skl_int3472_get_acpi_buffer);
|
|
|
|
int skl_int3472_fill_cldb(struct acpi_device *adev, struct int3472_cldb *cldb)
|
|
{
|
|
union acpi_object *obj;
|
|
int ret;
|
|
|
|
obj = skl_int3472_get_acpi_buffer(adev, "CLDB");
|
|
if (IS_ERR(obj))
|
|
return PTR_ERR(obj);
|
|
|
|
if (obj->buffer.length > sizeof(*cldb)) {
|
|
acpi_handle_err(adev->handle, "The CLDB buffer is too large\n");
|
|
ret = -EINVAL;
|
|
goto out_free_obj;
|
|
}
|
|
|
|
memcpy(cldb, obj->buffer.pointer, obj->buffer.length);
|
|
ret = 0;
|
|
|
|
out_free_obj:
|
|
kfree(obj);
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL_GPL(skl_int3472_fill_cldb);
|
|
|
|
/* sensor_adev_ret may be NULL, name_ret must not be NULL */
|
|
int skl_int3472_get_sensor_adev_and_name(struct device *dev,
|
|
struct acpi_device **sensor_adev_ret,
|
|
const char **name_ret)
|
|
{
|
|
struct acpi_device *adev = ACPI_COMPANION(dev);
|
|
struct acpi_device *sensor;
|
|
int ret = 0;
|
|
|
|
sensor = acpi_dev_get_next_consumer_dev(adev, NULL);
|
|
if (!sensor) {
|
|
dev_err(dev, "INT3472 seems to have no dependents.\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
*name_ret = devm_kasprintf(dev, GFP_KERNEL, I2C_DEV_NAME_FORMAT,
|
|
acpi_dev_name(sensor));
|
|
if (!*name_ret)
|
|
ret = -ENOMEM;
|
|
|
|
if (ret == 0 && sensor_adev_ret)
|
|
*sensor_adev_ret = sensor;
|
|
else
|
|
acpi_dev_put(sensor);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL_GPL(skl_int3472_get_sensor_adev_and_name);
|
|
|
|
MODULE_DESCRIPTION("Intel SkyLake INT3472 ACPI Device Driver library");
|
|
MODULE_AUTHOR("Daniel Scally <djrscally@gmail.com>");
|
|
MODULE_LICENSE("GPL");
|