1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/usb/gadget/udc
Uwe Kleine-König 3d56e5aa67 usb: gadget: aspeed_udc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

ast_udc_remove() is one of these functions that return an error code
after doing only a partial cleanup. Replace the core's error message by
a more drastic one and still convert the driver to .remove_new().
Note the only semantic change here is the changed error message.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231026221701.2521483-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-10-27 12:56:02 +02:00
..
aspeed-vhub usb: gadget: aspeed: Use devm_platform_get_and_ioremap_resource() 2023-07-27 10:24:08 +02:00
bdc usb: bdc: Convert to platform remove callback returning void 2023-05-28 12:36:25 +01:00
cdns2 usb: cdns2: Fix spelling mistake in a trace message "Wakupe" -> "Wakeup" 2023-06-19 15:34:44 +02:00
amd5536udc.h USB: gadget: udc: Remove some dead code 2021-10-10 15:12:34 +02:00
amd5536udc_pci.c usb: gadget: udc: fix NULL dereference in remove() 2023-05-29 15:24:24 +01:00
aspeed_udc.c usb: gadget: aspeed_udc: Convert to platform remove callback returning void 2023-10-27 12:56:02 +02:00
at91_udc.c usb: gadget: at91-udc: Convert to use module_platform_driver() 2023-10-21 12:47:24 +02:00
at91_udc.h usb: gadget: at91_udc: Convert to GPIO descriptors 2021-11-17 14:41:15 +01:00
atmel_usba_udc.c usb: gadget/atmel_usba_udc: Use devm_platform_get_and_ioremap_resource() 2023-07-27 10:24:08 +02:00
atmel_usba_udc.h usb: gadget: udc: atmel: update endpoint allocation for sam9x60 2020-09-24 11:56:17 +03:00
bcm63xx_udc.c usb: gadget/bcm63xx_udc: Convert to platform remove callback returning void 2023-05-28 12:36:25 +01:00
core.c usb: gadget: udc: Handle gadget_connect failure during bind operation 2023-10-02 13:58:11 +02:00
dummy_hcd.c usb: gadget/dummy_hcd: Convert to platform remove callback returning void 2023-05-28 12:36:25 +01:00
fsl_qe_udc.c usb: Use device_get_match_data() 2023-10-10 08:55:23 +02:00
fsl_qe_udc.h usb: Spelling s/enpoint/endpoint/ 2019-11-04 15:53:00 +01:00
fsl_udc_core.c usb: gadget: fsl-udc: Convert to use module_platform_driver() 2023-10-21 12:47:24 +02:00
fsl_usb2_udc.h usb: gadget: fsl: properly remove remnant of MXC support 2021-06-14 10:31:51 +02:00
fusb300_udc.c usb: gadget: fusb300-udc: Convert to use module_platform_driver() 2023-10-21 12:47:24 +02:00
fusb300_udc.h USB: gadget: udc: Remove redundant license text 2017-11-07 15:45:02 +01:00
goku_udc.c usb: gadget: udc: do not clear gadget driver.bus 2023-02-02 09:41:17 +01:00
goku_udc.h usb: gadget: udc: change comparison to bitshift when dealing with a mask 2018-03-08 15:12:00 +02:00
gr_udc.c usb: gadget: udc: gr_udc: Fix deferred probing 2023-08-04 14:46:24 +02:00
gr_udc.h USB: gr_udc: remove dentry storage for debugfs file 2021-06-02 16:41:00 +02:00
Kconfig usb: cdns2: Add main part of Cadence USBHS driver 2023-06-13 11:59:29 +02:00
lpc32xx_udc.c usb: gadget: lpc32xx-udc: Convert to use module_platform_driver() 2023-10-21 12:47:24 +02:00
m66592-udc.c usb: gadget: m66592-udc: Convert to use module_platform_driver() 2023-10-21 12:47:24 +02:00
m66592-udc.h USB: gadget: udc: Remove redundant license text 2017-11-07 15:45:02 +01:00
Makefile usb: cdns2: Add main part of Cadence USBHS driver 2023-06-13 11:59:29 +02:00
max3420_udc.c usb: Explicitly include correct DT includes 2023-07-25 18:20:02 +02:00
mv_u3d.h usb: Spelling s/enpoint/endpoint/ 2019-11-04 15:53:00 +01:00
mv_u3d_core.c usb: gadget: udc: Remove unnecessary NULL values 2023-08-04 14:48:24 +02:00
mv_udc.h USB: gadget: udc: Remove redundant license text 2017-11-07 15:45:02 +01:00
mv_udc_core.c usb: gadget: udc: Remove unnecessary NULL values 2023-08-04 14:48:24 +02:00
net2272.c usb: gadget/net2272: Convert to platform remove callback returning void 2023-05-28 12:36:26 +01:00
net2272.h USB: UDC: Implement udc_async_callbacks in net2272 2021-06-04 13:52:09 +02:00
net2280.c usb: gadget: udc: do not clear gadget driver.bus 2023-02-02 09:41:17 +01:00
net2280.h USB: UDC: Implement udc_async_callbacks in net2280 2021-06-04 13:52:06 +02:00
omap_udc.c usb: gadget/omap_udc: Convert to platform remove callback returning void 2023-05-28 12:36:26 +01:00
omap_udc.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pch_udc.c usb: gadget: udc: do not clear gadget driver.bus 2023-02-02 09:41:17 +01:00
pxa25x_udc.c USB / Thunderbolt driver changes for 6.3-rc1 2023-02-24 12:07:00 -08:00
pxa25x_udc.h ARM: pxa: lubbock: pass udc irqs as resource 2022-05-07 22:55:47 +02:00
pxa27x_udc.c usb: Explicitly include correct DT includes 2023-07-25 18:20:02 +02:00
pxa27x_udc.h usb: gadget: pxa27x_udc: clean up comment 2022-04-21 19:20:42 +02:00
r8a66597-udc.c usb: gadget: r8a66597-udc: Convert to use module_platform_driver() 2023-10-21 12:47:24 +02:00
r8a66597-udc.h USB: gadget: udc: Remove redundant license text 2017-11-07 15:45:02 +01:00
renesas_usb3.c usb: Explicitly include correct DT includes 2023-07-25 18:20:02 +02:00
renesas_usbf.c usb: gadget: udc: Remove redundant initialization for udc_driver 2023-08-04 14:46:40 +02:00
rzv2m_usb3drd.c usb: gadget/rzv2m_usb3drd: Convert to platform remove callback returning void 2023-05-28 12:36:27 +01:00
snps_udc_core.c usb: gadget: udc: do not clear gadget driver.bus 2023-02-02 09:41:17 +01:00
snps_udc_plat.c usb: gadget/snps_udc_plat: Remove redundant of_match_ptr() 2023-08-12 10:03:13 +02:00
tegra-xudc.c Merge 6.5-rc4 into usb-next 2023-07-31 09:36:55 +02:00
trace.c USB: gadget: udc: fix kernel-doc syntax in file headers 2021-05-24 15:27:03 +02:00
trace.h usb: gadget: Properly configure the device for remote wakeup 2023-03-29 10:27:00 +02:00
udc-xilinx.c usb: gadget: udc-xilinx: replace memcpy with memcpy_toio 2023-10-02 14:26:36 +02:00