b3d9305e60
Ethtool extended state cannot be tested with veth pairs, resulting in
failures:
# ./ethtool_extended_state.sh
TEST: Autoneg, No partner detected [FAIL]
Expected "Autoneg", got "Link detected: no"
[...]
Fix by skipping the test when used with veth pairs.
Fixes: 7d10bcce98 ("selftests: forwarding: Add tests for ethtool extended state")
Reported-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Closes: https://lore.kernel.org/netdev/adc5e40d-d040-a65e-eb26-edf47dac5b02@alu.unizg.hr/
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Tested-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://lore.kernel.org/r/20230808141503.4060661-9-idosch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
117 lines
2.1 KiB
Bash
Executable file
117 lines
2.1 KiB
Bash
Executable file
#!/bin/bash
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
ALL_TESTS="
|
|
autoneg
|
|
autoneg_force_mode
|
|
no_cable
|
|
"
|
|
|
|
NUM_NETIFS=2
|
|
source lib.sh
|
|
source ethtool_lib.sh
|
|
|
|
TIMEOUT=$((WAIT_TIMEOUT * 1000)) # ms
|
|
|
|
setup_prepare()
|
|
{
|
|
swp1=${NETIFS[p1]}
|
|
swp2=${NETIFS[p2]}
|
|
swp3=$NETIF_NO_CABLE
|
|
}
|
|
|
|
ethtool_ext_state()
|
|
{
|
|
local dev=$1; shift
|
|
local expected_ext_state=$1; shift
|
|
local expected_ext_substate=${1:-""}; shift
|
|
|
|
local ext_state=$(ethtool $dev | grep "Link detected" \
|
|
| cut -d "(" -f2 | cut -d ")" -f1)
|
|
local ext_substate=$(echo $ext_state | cut -sd "," -f2 \
|
|
| sed -e 's/^[[:space:]]*//')
|
|
ext_state=$(echo $ext_state | cut -d "," -f1)
|
|
|
|
if [[ $ext_state != $expected_ext_state ]]; then
|
|
echo "Expected \"$expected_ext_state\", got \"$ext_state\""
|
|
return 1
|
|
fi
|
|
if [[ $ext_substate != $expected_ext_substate ]]; then
|
|
echo "Expected \"$expected_ext_substate\", got \"$ext_substate\""
|
|
return 1
|
|
fi
|
|
}
|
|
|
|
autoneg()
|
|
{
|
|
local msg
|
|
|
|
RET=0
|
|
|
|
ip link set dev $swp1 up
|
|
|
|
msg=$(busywait $TIMEOUT ethtool_ext_state $swp1 \
|
|
"Autoneg" "No partner detected")
|
|
check_err $? "$msg"
|
|
|
|
log_test "Autoneg, No partner detected"
|
|
|
|
ip link set dev $swp1 down
|
|
}
|
|
|
|
autoneg_force_mode()
|
|
{
|
|
local msg
|
|
|
|
RET=0
|
|
|
|
ip link set dev $swp1 up
|
|
ip link set dev $swp2 up
|
|
|
|
local -a speeds_arr=($(different_speeds_get $swp1 $swp2 0 0))
|
|
local speed1=${speeds_arr[0]}
|
|
local speed2=${speeds_arr[1]}
|
|
|
|
ethtool_set $swp1 speed $speed1 autoneg off
|
|
ethtool_set $swp2 speed $speed2 autoneg off
|
|
|
|
msg=$(busywait $TIMEOUT ethtool_ext_state $swp1 \
|
|
"Autoneg" "No partner detected during force mode")
|
|
check_err $? "$msg"
|
|
|
|
msg=$(busywait $TIMEOUT ethtool_ext_state $swp2 \
|
|
"Autoneg" "No partner detected during force mode")
|
|
check_err $? "$msg"
|
|
|
|
log_test "Autoneg, No partner detected during force mode"
|
|
|
|
ethtool -s $swp2 autoneg on
|
|
ethtool -s $swp1 autoneg on
|
|
|
|
ip link set dev $swp2 down
|
|
ip link set dev $swp1 down
|
|
}
|
|
|
|
no_cable()
|
|
{
|
|
local msg
|
|
|
|
RET=0
|
|
|
|
ip link set dev $swp3 up
|
|
|
|
msg=$(busywait $TIMEOUT ethtool_ext_state $swp3 "No cable")
|
|
check_err $? "$msg"
|
|
|
|
log_test "No cable"
|
|
|
|
ip link set dev $swp3 down
|
|
}
|
|
|
|
skip_on_veth
|
|
|
|
setup_prepare
|
|
|
|
tests_run
|
|
|
|
exit $EXIT_STATUS
|