Intel Platform Monitoring Technology (PMT) support is indicated by presence of an Intel defined PCIe Designated Vendor Specific Extended Capabilities (DVSEC) structure with a PMT specific ID. The current MFD implementation creates child devices for each PMT feature, currently telemetry, watcher, and crashlog. However DVSEC structures may also be used by Intel to indicate support for other features. The Out Of Band Management Services Module (OOBMSM) uses DVSEC to enumerate several features, including PMT. In order to support them it is necessary to modify the intel_pmt driver to handle the creation of the child devices more generically. To that end, modify the driver to create child devices for any VSEC/DVSEC features on supported devices (indicated by PCI ID). Additionally, move the implementation from MFD to the Auxiliary bus. VSEC/DVSEC features are really multifunctional PCI devices, not platform devices as MFD was designed for. Auxiliary bus gives more flexibility by allowing the definition of custom structures that can be shared between associated auxiliary devices and the parent device. Also, rename the driver from intel_pmt to intel_vsec to better reflect the purpose. This series also removes the current runtime pm support which was not complete to begin with. None of the current devices require runtime pm. However the support will be replaced when a device is added that requires it. Reviewed-by: Mark Gross <markgross@kernel.org> Acked-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: David E. Box <david.e.box@linux.intel.com> Link: https://lore.kernel.org/r/20211208015015.891275-4-david.e.box@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
150 lines
3.7 KiB
C
150 lines
3.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Intel Platform Monitory Technology Telemetry driver
|
|
*
|
|
* Copyright (c) 2020, Intel Corporation.
|
|
* All Rights Reserved.
|
|
*
|
|
* Author: "David E. Box" <david.e.box@linux.intel.com>
|
|
*/
|
|
|
|
#include <linux/auxiliary_bus.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/uaccess.h>
|
|
#include <linux/overflow.h>
|
|
|
|
#include "../vsec.h"
|
|
#include "class.h"
|
|
|
|
#define TELEM_SIZE_OFFSET 0x0
|
|
#define TELEM_GUID_OFFSET 0x4
|
|
#define TELEM_BASE_OFFSET 0x8
|
|
#define TELEM_ACCESS(v) ((v) & GENMASK(3, 0))
|
|
/* size is in bytes */
|
|
#define TELEM_SIZE(v) (((v) & GENMASK(27, 12)) >> 10)
|
|
|
|
/* Used by client hardware to identify a fixed telemetry entry*/
|
|
#define TELEM_CLIENT_FIXED_BLOCK_GUID 0x10000000
|
|
|
|
struct pmt_telem_priv {
|
|
int num_entries;
|
|
struct intel_pmt_entry entry[];
|
|
};
|
|
|
|
static bool pmt_telem_region_overlaps(struct intel_pmt_entry *entry,
|
|
struct device *dev)
|
|
{
|
|
u32 guid = readl(entry->disc_table + TELEM_GUID_OFFSET);
|
|
|
|
if (guid != TELEM_CLIENT_FIXED_BLOCK_GUID)
|
|
return false;
|
|
|
|
return intel_pmt_is_early_client_hw(dev);
|
|
}
|
|
|
|
static int pmt_telem_header_decode(struct intel_pmt_entry *entry,
|
|
struct intel_pmt_header *header,
|
|
struct device *dev)
|
|
{
|
|
void __iomem *disc_table = entry->disc_table;
|
|
|
|
if (pmt_telem_region_overlaps(entry, dev))
|
|
return 1;
|
|
|
|
header->access_type = TELEM_ACCESS(readl(disc_table));
|
|
header->guid = readl(disc_table + TELEM_GUID_OFFSET);
|
|
header->base_offset = readl(disc_table + TELEM_BASE_OFFSET);
|
|
|
|
/* Size is measured in DWORDS, but accessor returns bytes */
|
|
header->size = TELEM_SIZE(readl(disc_table));
|
|
|
|
/*
|
|
* Some devices may expose non-functioning entries that are
|
|
* reserved for future use. They have zero size. Do not fail
|
|
* probe for these. Just ignore them.
|
|
*/
|
|
if (header->size == 0)
|
|
return 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static DEFINE_XARRAY_ALLOC(telem_array);
|
|
static struct intel_pmt_namespace pmt_telem_ns = {
|
|
.name = "telem",
|
|
.xa = &telem_array,
|
|
.pmt_header_decode = pmt_telem_header_decode,
|
|
};
|
|
|
|
static void pmt_telem_remove(struct auxiliary_device *auxdev)
|
|
{
|
|
struct pmt_telem_priv *priv = auxiliary_get_drvdata(auxdev);
|
|
int i;
|
|
|
|
for (i = 0; i < priv->num_entries; i++)
|
|
intel_pmt_dev_destroy(&priv->entry[i], &pmt_telem_ns);
|
|
}
|
|
|
|
static int pmt_telem_probe(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id)
|
|
{
|
|
struct intel_vsec_device *intel_vsec_dev = auxdev_to_ivdev(auxdev);
|
|
struct pmt_telem_priv *priv;
|
|
size_t size;
|
|
int i, ret;
|
|
|
|
size = struct_size(priv, entry, intel_vsec_dev->num_resources);
|
|
priv = devm_kzalloc(&auxdev->dev, size, GFP_KERNEL);
|
|
if (!priv)
|
|
return -ENOMEM;
|
|
|
|
auxiliary_set_drvdata(auxdev, priv);
|
|
|
|
for (i = 0; i < intel_vsec_dev->num_resources; i++) {
|
|
struct intel_pmt_entry *entry = &priv->entry[i];
|
|
|
|
ret = intel_pmt_dev_create(entry, &pmt_telem_ns, intel_vsec_dev, i);
|
|
if (ret < 0)
|
|
goto abort_probe;
|
|
if (ret)
|
|
continue;
|
|
|
|
priv->num_entries++;
|
|
}
|
|
|
|
return 0;
|
|
abort_probe:
|
|
pmt_telem_remove(auxdev);
|
|
return ret;
|
|
}
|
|
|
|
static const struct auxiliary_device_id pmt_telem_id_table[] = {
|
|
{ .name = "intel_vsec.telemetry" },
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(auxiliary, pmt_telem_id_table);
|
|
|
|
static struct auxiliary_driver pmt_telem_aux_driver = {
|
|
.id_table = pmt_telem_id_table,
|
|
.remove = pmt_telem_remove,
|
|
.probe = pmt_telem_probe,
|
|
};
|
|
|
|
static int __init pmt_telem_init(void)
|
|
{
|
|
return auxiliary_driver_register(&pmt_telem_aux_driver);
|
|
}
|
|
module_init(pmt_telem_init);
|
|
|
|
static void __exit pmt_telem_exit(void)
|
|
{
|
|
auxiliary_driver_unregister(&pmt_telem_aux_driver);
|
|
xa_destroy(&telem_array);
|
|
}
|
|
module_exit(pmt_telem_exit);
|
|
|
|
MODULE_AUTHOR("David E. Box <david.e.box@linux.intel.com>");
|
|
MODULE_DESCRIPTION("Intel PMT Telemetry driver");
|
|
MODULE_LICENSE("GPL v2");
|