We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe. And it also uses pgoff_t as our page lookups must remain compatible with the page cache, pgoff_t is currently exactly unsigned long. v2: Move added i915_utils's macro into drm_util header (Jani N) v3: Make not use the same macro name on a function. (Mauro) For kernel-doc, macros and functions are handled in the same namespace, the same macro name on a function prevents ever adding documentation for it. v4: Add kernel-doc markups to the kAPI functions and macros (Mauoro) v5: Fix an alignment to match open parenthesis v6: Rebase v10: Use assert_typable instead of exactly_pgoff_t() macro. (Kees) v11: Change the use of assert_typable to assert_same_typable (G.G) v12: Change to use static_assert(__castable_to_type(n ,T)) style since the assert_same_typable() macro has been dropped. (G.G) v13: Change the use of __castable_to_type() to castable_to_type() Remove an unnecessary header include line. (G.G) v16: Fix "ERROR:SPACING" Checkpatch report (G.G) Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Cc: Kees Cook <keescook@chromium.org> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Co-developed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> (v2) Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org> (v3) Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> (v5) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20221228192252.917299-2-gwan-gyeong.mun@intel.com
99 lines
2 KiB
C
99 lines
2 KiB
C
/*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Copyright © 2016 Intel Corporation
|
|
*/
|
|
|
|
#include "i915_selftest.h"
|
|
|
|
#include "huge_gem_object.h"
|
|
#include "selftests/igt_flush_test.h"
|
|
#include "selftests/mock_gem_device.h"
|
|
|
|
static int igt_gem_object(void *arg)
|
|
{
|
|
struct drm_i915_private *i915 = arg;
|
|
struct drm_i915_gem_object *obj;
|
|
int err;
|
|
|
|
/* Basic test to ensure we can create an object */
|
|
|
|
obj = i915_gem_object_create_shmem(i915, PAGE_SIZE);
|
|
if (IS_ERR(obj)) {
|
|
err = PTR_ERR(obj);
|
|
pr_err("i915_gem_object_create failed, err=%d\n", err);
|
|
goto out;
|
|
}
|
|
|
|
err = 0;
|
|
i915_gem_object_put(obj);
|
|
out:
|
|
return err;
|
|
}
|
|
|
|
static int igt_gem_huge(void *arg)
|
|
{
|
|
const unsigned long nreal = 509; /* just to be awkward */
|
|
struct drm_i915_private *i915 = arg;
|
|
struct drm_i915_gem_object *obj;
|
|
unsigned long n;
|
|
int err;
|
|
|
|
/* Basic sanitycheck of our huge fake object allocation */
|
|
|
|
obj = huge_gem_object(i915,
|
|
nreal * PAGE_SIZE,
|
|
to_gt(i915)->ggtt->vm.total + PAGE_SIZE);
|
|
if (IS_ERR(obj))
|
|
return PTR_ERR(obj);
|
|
|
|
err = i915_gem_object_pin_pages_unlocked(obj);
|
|
if (err) {
|
|
pr_err("Failed to allocate %lu pages (%lu total), err=%d\n",
|
|
nreal, obj->base.size / PAGE_SIZE, err);
|
|
goto out;
|
|
}
|
|
|
|
for (n = 0; n < obj->base.size / PAGE_SIZE; n++) {
|
|
if (i915_gem_object_get_page(obj, n) !=
|
|
i915_gem_object_get_page(obj, n % nreal)) {
|
|
pr_err("Page lookup mismatch at index %lu [%lu]\n",
|
|
n, n % nreal);
|
|
err = -EINVAL;
|
|
goto out_unpin;
|
|
}
|
|
}
|
|
|
|
out_unpin:
|
|
i915_gem_object_unpin_pages(obj);
|
|
out:
|
|
i915_gem_object_put(obj);
|
|
return err;
|
|
}
|
|
|
|
int i915_gem_object_mock_selftests(void)
|
|
{
|
|
static const struct i915_subtest tests[] = {
|
|
SUBTEST(igt_gem_object),
|
|
};
|
|
struct drm_i915_private *i915;
|
|
int err;
|
|
|
|
i915 = mock_gem_device();
|
|
if (!i915)
|
|
return -ENOMEM;
|
|
|
|
err = i915_subtests(tests, i915);
|
|
|
|
mock_destroy_device(i915);
|
|
return err;
|
|
}
|
|
|
|
int i915_gem_object_live_selftests(struct drm_i915_private *i915)
|
|
{
|
|
static const struct i915_subtest tests[] = {
|
|
SUBTEST(igt_gem_huge),
|
|
};
|
|
|
|
return i915_live_subtests(tests, i915);
|
|
}
|