991544dc57
Currently the set_alt callback immediately disables the endpoint and queues the v4l2 streamoff event. However, as the streamoff event is processed asynchronously, it is possible that the video_pump thread attempts to queue requests to an already disabled endpoint. This change moves disabling usb endpoint to the end of streamoff event callback. As the endpoint's state can no longer be used, video_pump is now guarded by uvc->state as well. To be consistent with the actual streaming state, uvc->state is now toggled between CONNECTED and STREAMING from the v4l2 event callback only. Link: https://lore.kernel.org/20230615171558.GK741@pendragon.ideasonboard.com/ Link: https://lore.kernel.org/20230531085544.253363-1-dan.scally@ideasonboard.com/ Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by: Michael Grzeschik <m.grzeschik@pengutronix.de> Tested-by: Michael Grzeschik <m.grzeschik@pengutronix.de> Signed-off-by: Avichal Rakesh <arakesh@google.com> Link: https://lore.kernel.org/r/20231109004104.3467968-1-arakesh@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
20 lines
446 B
C
20 lines
446 B
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* f_uvc.h -- USB Video Class Gadget driver
|
|
*
|
|
* Copyright (C) 2009-2010
|
|
* Laurent Pinchart (laurent.pinchart@ideasonboard.com)
|
|
*/
|
|
|
|
#ifndef _F_UVC_H_
|
|
#define _F_UVC_H_
|
|
|
|
struct uvc_device;
|
|
|
|
void uvc_function_setup_continue(struct uvc_device *uvc, int disable_ep);
|
|
|
|
void uvc_function_connect(struct uvc_device *uvc);
|
|
|
|
void uvc_function_disconnect(struct uvc_device *uvc);
|
|
|
|
#endif /* _F_UVC_H_ */
|