42fd623b58
Finding a map is done under a lock, returning the map without a reference count means it can be removed without notice and causing uses after free. Grab a reference count to the map within the lock region and return this. Fix up locations that need a map__put following this. Signed-off-by: Ian Rogers <irogers@google.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: K Prateek Nayak <kprateek.nayak@amd.com> Cc: James Clark <james.clark@arm.com> Cc: Vincent Whitchurch <vincent.whitchurch@axis.com> Cc: Alexey Dobriyan <adobriyan@gmail.com> Cc: Colin Ian King <colin.i.king@gmail.com> Cc: Changbin Du <changbin.du@huawei.com> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Song Liu <song@kernel.org> Cc: Leo Yan <leo.yan@linux.dev> Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com> Cc: Liam Howlett <liam.howlett@oracle.com> Cc: Artem Savkov <asavkov@redhat.com> Cc: bpf@vger.kernel.org Signed-off-by: Namhyung Kim <namhyung@kernel.org> Link: https://lore.kernel.org/r/20240210031746.4057262-3-irogers@google.com
79 lines
1.8 KiB
C
79 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <string.h>
|
|
#include "perf_regs.h"
|
|
#include "thread.h"
|
|
#include "map.h"
|
|
#include "maps.h"
|
|
#include "event.h"
|
|
#include "debug.h"
|
|
#include "tests/tests.h"
|
|
|
|
#define STACK_SIZE 8192
|
|
|
|
static int sample_ustack(struct perf_sample *sample,
|
|
struct thread *thread, u64 *regs)
|
|
{
|
|
struct stack_dump *stack = &sample->user_stack;
|
|
struct map *map;
|
|
unsigned long sp;
|
|
u64 stack_size, *buf;
|
|
|
|
buf = malloc(STACK_SIZE);
|
|
if (!buf) {
|
|
pr_debug("failed to allocate sample uregs data\n");
|
|
return -1;
|
|
}
|
|
|
|
sp = (unsigned long) regs[PERF_REG_X86_SP];
|
|
|
|
map = maps__find(thread__maps(thread), (u64)sp);
|
|
if (!map) {
|
|
pr_debug("failed to get stack map\n");
|
|
free(buf);
|
|
return -1;
|
|
}
|
|
|
|
stack_size = map__end(map) - sp;
|
|
map__put(map);
|
|
stack_size = stack_size > STACK_SIZE ? STACK_SIZE : stack_size;
|
|
|
|
memcpy(buf, (void *) sp, stack_size);
|
|
#ifdef MEMORY_SANITIZER
|
|
/*
|
|
* Copying the stack may copy msan poison, avoid false positives in the
|
|
* unwinder by removing the poison here.
|
|
*/
|
|
__msan_unpoison(buf, stack_size);
|
|
#endif
|
|
stack->data = (char *) buf;
|
|
stack->size = stack_size;
|
|
return 0;
|
|
}
|
|
|
|
int test__arch_unwind_sample(struct perf_sample *sample,
|
|
struct thread *thread)
|
|
{
|
|
struct regs_dump *regs = &sample->user_regs;
|
|
u64 *buf;
|
|
|
|
buf = malloc(sizeof(u64) * PERF_REGS_MAX);
|
|
if (!buf) {
|
|
pr_debug("failed to allocate sample uregs data\n");
|
|
return -1;
|
|
}
|
|
|
|
#ifdef MEMORY_SANITIZER
|
|
/*
|
|
* Assignments to buf in the assembly function perf_regs_load aren't
|
|
* seen by memory sanitizer. Zero the memory to convince memory
|
|
* sanitizer the memory is initialized.
|
|
*/
|
|
memset(buf, 0, sizeof(u64) * PERF_REGS_MAX);
|
|
#endif
|
|
perf_regs_load(buf);
|
|
regs->abi = PERF_SAMPLE_REGS_ABI;
|
|
regs->regs = buf;
|
|
regs->mask = PERF_REGS_MASK;
|
|
|
|
return sample_ustack(sample, thread, buf);
|
|
}
|