Bugs in memory allocation failure paths are quite common. Add a test exercising those paths based on qstat and page pool failure hook. Running on bnxt: # ./drivers/net/hw/pp_alloc_fail.py KTAP version 1 1..1 # ethtool -G change retval: success ok 1 pp_alloc_fail.test_pp_alloc # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 I initially wrote this test to validate commitbe43b7489a
("net/mlx5e: RX, Fix page_pool allocation failure recovery for striding rq") but mlx5 still doesn't have qstat. So I run it on bnxt, and while bnxt survives I found the problem fixed in commit7301177307
("eth: bnxt: fix counting packets discarded due to OOM and netpoll"). Reviewed-by: Willem de Bruijn <willemb@google.com> Link: https://lore.kernel.org/r/20240429144426.743476-7-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
159 lines
3.8 KiB
Python
159 lines
3.8 KiB
Python
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
import builtins
|
|
import inspect
|
|
import sys
|
|
import time
|
|
import traceback
|
|
from .consts import KSFT_MAIN_NAME
|
|
|
|
KSFT_RESULT = None
|
|
KSFT_RESULT_ALL = True
|
|
|
|
|
|
class KsftFailEx(Exception):
|
|
pass
|
|
|
|
|
|
class KsftSkipEx(Exception):
|
|
pass
|
|
|
|
|
|
class KsftXfailEx(Exception):
|
|
pass
|
|
|
|
|
|
def ksft_pr(*objs, **kwargs):
|
|
print("#", *objs, **kwargs)
|
|
|
|
|
|
def _fail(*args):
|
|
global KSFT_RESULT
|
|
KSFT_RESULT = False
|
|
|
|
frame = inspect.stack()[2]
|
|
ksft_pr("At " + frame.filename + " line " + str(frame.lineno) + ":")
|
|
ksft_pr(*args)
|
|
|
|
|
|
def ksft_eq(a, b, comment=""):
|
|
global KSFT_RESULT
|
|
if a != b:
|
|
_fail("Check failed", a, "!=", b, comment)
|
|
|
|
|
|
def ksft_true(a, comment=""):
|
|
if not a:
|
|
_fail("Check failed", a, "does not eval to True", comment)
|
|
|
|
|
|
def ksft_in(a, b, comment=""):
|
|
if a not in b:
|
|
_fail("Check failed", a, "not in", b, comment)
|
|
|
|
|
|
def ksft_ge(a, b, comment=""):
|
|
if a < b:
|
|
_fail("Check failed", a, "<", b, comment)
|
|
|
|
|
|
class ksft_raises:
|
|
def __init__(self, expected_type):
|
|
self.exception = None
|
|
self.expected_type = expected_type
|
|
|
|
def __enter__(self):
|
|
return self
|
|
|
|
def __exit__(self, exc_type, exc_val, exc_tb):
|
|
if exc_type is None:
|
|
_fail(f"Expected exception {str(self.expected_type.__name__)}, none raised")
|
|
elif self.expected_type != exc_type:
|
|
_fail(f"Expected exception {str(self.expected_type.__name__)}, raised {str(exc_type.__name__)}")
|
|
self.exception = exc_val
|
|
# Suppress the exception if its the expected one
|
|
return self.expected_type == exc_type
|
|
|
|
|
|
def ksft_busy_wait(cond, sleep=0.005, deadline=1, comment=""):
|
|
end = time.monotonic() + deadline
|
|
while True:
|
|
if cond():
|
|
return
|
|
if time.monotonic() > end:
|
|
_fail("Waiting for condition timed out", comment)
|
|
return
|
|
time.sleep(sleep)
|
|
|
|
|
|
def ktap_result(ok, cnt=1, case="", comment=""):
|
|
global KSFT_RESULT_ALL
|
|
KSFT_RESULT_ALL = KSFT_RESULT_ALL and ok
|
|
|
|
res = ""
|
|
if not ok:
|
|
res += "not "
|
|
res += "ok "
|
|
res += str(cnt) + " "
|
|
res += KSFT_MAIN_NAME
|
|
if case:
|
|
res += "." + str(case.__name__)
|
|
if comment:
|
|
res += " # " + comment
|
|
print(res)
|
|
|
|
|
|
def ksft_run(cases=None, globs=None, case_pfx=None, args=()):
|
|
cases = cases or []
|
|
|
|
if globs and case_pfx:
|
|
for key, value in globs.items():
|
|
if not callable(value):
|
|
continue
|
|
for prefix in case_pfx:
|
|
if key.startswith(prefix):
|
|
cases.append(value)
|
|
break
|
|
|
|
totals = {"pass": 0, "fail": 0, "skip": 0, "xfail": 0}
|
|
|
|
print("KTAP version 1")
|
|
print("1.." + str(len(cases)))
|
|
|
|
global KSFT_RESULT
|
|
cnt = 0
|
|
for case in cases:
|
|
KSFT_RESULT = True
|
|
cnt += 1
|
|
try:
|
|
case(*args)
|
|
except KsftSkipEx as e:
|
|
ktap_result(True, cnt, case, comment="SKIP " + str(e))
|
|
totals['skip'] += 1
|
|
continue
|
|
except KsftXfailEx as e:
|
|
ktap_result(True, cnt, case, comment="XFAIL " + str(e))
|
|
totals['xfail'] += 1
|
|
continue
|
|
except Exception as e:
|
|
tb = traceback.format_exc()
|
|
for line in tb.strip().split('\n'):
|
|
ksft_pr("Exception|", line)
|
|
ktap_result(False, cnt, case)
|
|
totals['fail'] += 1
|
|
continue
|
|
|
|
ktap_result(KSFT_RESULT, cnt, case)
|
|
if KSFT_RESULT:
|
|
totals['pass'] += 1
|
|
else:
|
|
totals['fail'] += 1
|
|
|
|
print(
|
|
f"# Totals: pass:{totals['pass']} fail:{totals['fail']} xfail:{totals['xfail']} xpass:0 skip:{totals['skip']} error:0"
|
|
)
|
|
|
|
|
|
def ksft_exit():
|
|
global KSFT_RESULT_ALL
|
|
sys.exit(0 if KSFT_RESULT_ALL else 1)
|