644d0a5bcc
The pdev maybe not a platform device, e.g. c_can_pci device, in this
case, calling to_platform_device() would not make sense. Also, per the
comment in drivers/net/can/c_can/c_can_ethtool.c, @bus_info should
match dev_name() string, so I am replacing this with dev_name() to fix
this issue.
[ 1.458583] BUG: unable to handle page fault for address: 0000000100000000
[ 1.460921] RIP: 0010:strnlen+0x1a/0x30
[ 1.466336] ? c_can_get_drvinfo+0x65/0xb0 [c_can]
[ 1.466597] ethtool_get_drvinfo+0xae/0x360
[ 1.466826] dev_ethtool+0x10f8/0x2970
[ 1.467880] sock_ioctl+0xef/0x300
Fixes: 2722ac986e ("can: c_can: add ethtool support")
Link: https://lore.kernel.org/r/20210906233704.1162666-1-ztong0001@gmail.com
Cc: stable@vger.kernel.org # 5.14+
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
41 lines
1.1 KiB
C
41 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright 2021, Dario Binacchi <dariobin@libero.it>
|
|
*/
|
|
|
|
#include <linux/ethtool.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/can/dev.h>
|
|
|
|
#include "c_can.h"
|
|
|
|
static void c_can_get_drvinfo(struct net_device *netdev,
|
|
struct ethtool_drvinfo *info)
|
|
{
|
|
struct c_can_priv *priv = netdev_priv(netdev);
|
|
strscpy(info->driver, "c_can", sizeof(info->driver));
|
|
strscpy(info->bus_info, dev_name(priv->device), sizeof(info->bus_info));
|
|
}
|
|
|
|
static void c_can_get_ringparam(struct net_device *netdev,
|
|
struct ethtool_ringparam *ring)
|
|
{
|
|
struct c_can_priv *priv = netdev_priv(netdev);
|
|
|
|
ring->rx_max_pending = priv->msg_obj_num;
|
|
ring->tx_max_pending = priv->msg_obj_num;
|
|
ring->rx_pending = priv->msg_obj_rx_num;
|
|
ring->tx_pending = priv->msg_obj_tx_num;
|
|
}
|
|
|
|
static const struct ethtool_ops c_can_ethtool_ops = {
|
|
.get_drvinfo = c_can_get_drvinfo,
|
|
.get_ringparam = c_can_get_ringparam,
|
|
};
|
|
|
|
void c_can_set_ethtool_ops(struct net_device *netdev)
|
|
{
|
|
netdev->ethtool_ops = &c_can_ethtool_ops;
|
|
}
|