With preemption enabled (CONFIG_DEBUG_PREEMPT=y), the following appeared when rnbd client tries to map remote block device. BUG: using smp_processor_id() in preemptible [00000000] code: bash/1733 caller is debug_smp_processor_id+0x17/0x20 CPU: 0 PID: 1733 Comm: bash Not tainted 5.16.0-rc1 #5 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014 Call Trace: <TASK> dump_stack_lvl+0x5d/0x78 dump_stack+0x10/0x12 check_preemption_disabled+0xe4/0xf0 debug_smp_processor_id+0x17/0x20 rtrs_clt_update_all_stats+0x3b/0x70 [rtrs_client] rtrs_clt_read_req+0xc3/0x380 [rtrs_client] ? rtrs_clt_init_req+0xe3/0x120 [rtrs_client] rtrs_clt_request+0x1a7/0x320 [rtrs_client] ? 0xffffffffc0ab1000 send_usr_msg+0xbf/0x160 [rnbd_client] ? rnbd_clt_put_sess+0x60/0x60 [rnbd_client] ? send_usr_msg+0x160/0x160 [rnbd_client] ? sg_alloc_table+0x27/0xb0 ? sg_zero_buffer+0xd0/0xd0 send_msg_sess_info+0xe9/0x180 [rnbd_client] ? rnbd_clt_put_sess+0x60/0x60 [rnbd_client] ? blk_mq_alloc_tag_set+0x2ef/0x370 rnbd_clt_map_device+0xba8/0xcd0 [rnbd_client] ? send_msg_open+0x200/0x200 [rnbd_client] rnbd_clt_map_device_store+0x3e5/0x620 [rnbd_client To supress the calltrace, let's call get_cpu_ptr/put_cpu_ptr pair in rtrs_clt_update_rdma_stats to disable preemption when accessing per-cpu variable. While at it, let's make the similar change in rtrs_clt_update_wc_stats. And for rtrs_clt_inc_failover_cnt, though it was only called inside rcu section, but it still can be preempted in case CONFIG_PREEMPT_RCU is enabled, so change it to {get,put}_cpu_ptr pair either. Link: https://lore.kernel.org/r/20211128133501.38710-1-guoqing.jiang@linux.dev Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
206 lines
4.8 KiB
C
206 lines
4.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* RDMA Transport Layer
|
|
*
|
|
* Copyright (c) 2014 - 2018 ProfitBricks GmbH. All rights reserved.
|
|
* Copyright (c) 2018 - 2019 1&1 IONOS Cloud GmbH. All rights reserved.
|
|
* Copyright (c) 2019 - 2020 1&1 IONOS SE. All rights reserved.
|
|
*/
|
|
#undef pr_fmt
|
|
#define pr_fmt(fmt) KBUILD_MODNAME " L" __stringify(__LINE__) ": " fmt
|
|
|
|
#include "rtrs-clt.h"
|
|
|
|
void rtrs_clt_update_wc_stats(struct rtrs_clt_con *con)
|
|
{
|
|
struct rtrs_clt_sess *sess = to_clt_sess(con->c.sess);
|
|
struct rtrs_clt_stats *stats = sess->stats;
|
|
struct rtrs_clt_stats_pcpu *s;
|
|
int cpu;
|
|
|
|
cpu = raw_smp_processor_id();
|
|
s = get_cpu_ptr(stats->pcpu_stats);
|
|
if (con->cpu != cpu) {
|
|
s->cpu_migr.to++;
|
|
|
|
/* Careful here, override s pointer */
|
|
s = per_cpu_ptr(stats->pcpu_stats, con->cpu);
|
|
atomic_inc(&s->cpu_migr.from);
|
|
}
|
|
put_cpu_ptr(stats->pcpu_stats);
|
|
}
|
|
|
|
void rtrs_clt_inc_failover_cnt(struct rtrs_clt_stats *stats)
|
|
{
|
|
struct rtrs_clt_stats_pcpu *s;
|
|
|
|
s = get_cpu_ptr(stats->pcpu_stats);
|
|
s->rdma.failover_cnt++;
|
|
put_cpu_ptr(stats->pcpu_stats);
|
|
}
|
|
|
|
int rtrs_clt_stats_migration_from_cnt_to_str(struct rtrs_clt_stats *stats, char *buf)
|
|
{
|
|
struct rtrs_clt_stats_pcpu *s;
|
|
|
|
size_t used;
|
|
int cpu;
|
|
|
|
used = 0;
|
|
for_each_possible_cpu(cpu) {
|
|
s = per_cpu_ptr(stats->pcpu_stats, cpu);
|
|
used += sysfs_emit_at(buf, used, "%d ",
|
|
atomic_read(&s->cpu_migr.from));
|
|
}
|
|
|
|
used += sysfs_emit_at(buf, used, "\n");
|
|
|
|
return used;
|
|
}
|
|
|
|
int rtrs_clt_stats_migration_to_cnt_to_str(struct rtrs_clt_stats *stats, char *buf)
|
|
{
|
|
struct rtrs_clt_stats_pcpu *s;
|
|
|
|
size_t used;
|
|
int cpu;
|
|
|
|
used = 0;
|
|
for_each_possible_cpu(cpu) {
|
|
s = per_cpu_ptr(stats->pcpu_stats, cpu);
|
|
used += sysfs_emit_at(buf, used, "%d ", s->cpu_migr.to);
|
|
}
|
|
|
|
used += sysfs_emit_at(buf, used, "\n");
|
|
|
|
return used;
|
|
}
|
|
|
|
int rtrs_clt_stats_reconnects_to_str(struct rtrs_clt_stats *stats, char *buf)
|
|
{
|
|
return sysfs_emit(buf, "%d %d\n", stats->reconnects.successful_cnt,
|
|
stats->reconnects.fail_cnt);
|
|
}
|
|
|
|
ssize_t rtrs_clt_stats_rdma_to_str(struct rtrs_clt_stats *stats, char *page)
|
|
{
|
|
struct rtrs_clt_stats_rdma sum;
|
|
struct rtrs_clt_stats_rdma *r;
|
|
int cpu;
|
|
|
|
memset(&sum, 0, sizeof(sum));
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
r = &per_cpu_ptr(stats->pcpu_stats, cpu)->rdma;
|
|
|
|
sum.dir[READ].cnt += r->dir[READ].cnt;
|
|
sum.dir[READ].size_total += r->dir[READ].size_total;
|
|
sum.dir[WRITE].cnt += r->dir[WRITE].cnt;
|
|
sum.dir[WRITE].size_total += r->dir[WRITE].size_total;
|
|
sum.failover_cnt += r->failover_cnt;
|
|
}
|
|
|
|
return sysfs_emit(page, "%llu %llu %llu %llu %u %llu\n",
|
|
sum.dir[READ].cnt, sum.dir[READ].size_total,
|
|
sum.dir[WRITE].cnt, sum.dir[WRITE].size_total,
|
|
atomic_read(&stats->inflight), sum.failover_cnt);
|
|
}
|
|
|
|
ssize_t rtrs_clt_reset_all_help(struct rtrs_clt_stats *s, char *page)
|
|
{
|
|
return sysfs_emit(page, "echo 1 to reset all statistics\n");
|
|
}
|
|
|
|
int rtrs_clt_reset_rdma_stats(struct rtrs_clt_stats *stats, bool enable)
|
|
{
|
|
struct rtrs_clt_stats_pcpu *s;
|
|
int cpu;
|
|
|
|
if (!enable)
|
|
return -EINVAL;
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
s = per_cpu_ptr(stats->pcpu_stats, cpu);
|
|
memset(&s->rdma, 0, sizeof(s->rdma));
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int rtrs_clt_reset_cpu_migr_stats(struct rtrs_clt_stats *stats, bool enable)
|
|
{
|
|
struct rtrs_clt_stats_pcpu *s;
|
|
int cpu;
|
|
|
|
if (!enable)
|
|
return -EINVAL;
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
s = per_cpu_ptr(stats->pcpu_stats, cpu);
|
|
memset(&s->cpu_migr, 0, sizeof(s->cpu_migr));
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int rtrs_clt_reset_reconnects_stat(struct rtrs_clt_stats *stats, bool enable)
|
|
{
|
|
if (!enable)
|
|
return -EINVAL;
|
|
|
|
memset(&stats->reconnects, 0, sizeof(stats->reconnects));
|
|
|
|
return 0;
|
|
}
|
|
|
|
int rtrs_clt_reset_all_stats(struct rtrs_clt_stats *s, bool enable)
|
|
{
|
|
if (enable) {
|
|
rtrs_clt_reset_rdma_stats(s, enable);
|
|
rtrs_clt_reset_cpu_migr_stats(s, enable);
|
|
rtrs_clt_reset_reconnects_stat(s, enable);
|
|
atomic_set(&s->inflight, 0);
|
|
return 0;
|
|
}
|
|
|
|
return -EINVAL;
|
|
}
|
|
|
|
static inline void rtrs_clt_update_rdma_stats(struct rtrs_clt_stats *stats,
|
|
size_t size, int d)
|
|
{
|
|
struct rtrs_clt_stats_pcpu *s;
|
|
|
|
s = get_cpu_ptr(stats->pcpu_stats);
|
|
s->rdma.dir[d].cnt++;
|
|
s->rdma.dir[d].size_total += size;
|
|
put_cpu_ptr(stats->pcpu_stats);
|
|
}
|
|
|
|
void rtrs_clt_update_all_stats(struct rtrs_clt_io_req *req, int dir)
|
|
{
|
|
struct rtrs_clt_con *con = req->con;
|
|
struct rtrs_clt_sess *sess = to_clt_sess(con->c.sess);
|
|
struct rtrs_clt_stats *stats = sess->stats;
|
|
unsigned int len;
|
|
|
|
len = req->usr_len + req->data_len;
|
|
rtrs_clt_update_rdma_stats(stats, len, dir);
|
|
if (req->mp_policy == MP_POLICY_MIN_INFLIGHT)
|
|
atomic_inc(&stats->inflight);
|
|
}
|
|
|
|
int rtrs_clt_init_stats(struct rtrs_clt_stats *stats)
|
|
{
|
|
stats->pcpu_stats = alloc_percpu(typeof(*stats->pcpu_stats));
|
|
if (!stats->pcpu_stats)
|
|
return -ENOMEM;
|
|
|
|
/*
|
|
* successful_cnt will be set to 0 after session
|
|
* is established for the first time
|
|
*/
|
|
stats->reconnects.successful_cnt = -1;
|
|
|
|
return 0;
|
|
}
|