5ae20a8050
On some systems, e.g. the Lenovo ThinkPad X1 Yoga gen 7 and the ThinkPad X1 Nano gen 2 there is no clock-enable pin, triggering the: "No clk GPIO. The privacy LED won't work" warning and causing the privacy LED to not work. Fix this by modeling the privacy LED as a LED class device rather then integrating it with the registered clock. Note this relies on media subsys changes to actually turn the LED on/off when the sensor's v4l2_subdev's s_stream() operand gets called. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com> Link: https://lore.kernel.org/r/20230127203729.10205-4-hdegoede@redhat.com
75 lines
2.2 KiB
C
75 lines
2.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/* Author: Hans de Goede <hdegoede@redhat.com> */
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/gpio/consumer.h>
|
|
#include <linux/leds.h>
|
|
#include "common.h"
|
|
|
|
static int int3472_pled_set(struct led_classdev *led_cdev,
|
|
enum led_brightness brightness)
|
|
{
|
|
struct int3472_discrete_device *int3472 =
|
|
container_of(led_cdev, struct int3472_discrete_device, pled.classdev);
|
|
|
|
gpiod_set_value_cansleep(int3472->pled.gpio, brightness);
|
|
return 0;
|
|
}
|
|
|
|
int skl_int3472_register_pled(struct int3472_discrete_device *int3472,
|
|
struct acpi_resource_gpio *agpio, u32 polarity)
|
|
{
|
|
char *p, *path = agpio->resource_source.string_ptr;
|
|
int ret;
|
|
|
|
if (int3472->pled.classdev.dev)
|
|
return -EBUSY;
|
|
|
|
int3472->pled.gpio = acpi_get_and_request_gpiod(path, agpio->pin_table[0],
|
|
"int3472,privacy-led");
|
|
if (IS_ERR(int3472->pled.gpio))
|
|
return dev_err_probe(int3472->dev, PTR_ERR(int3472->pled.gpio),
|
|
"getting privacy LED GPIO\n");
|
|
|
|
if (polarity == GPIO_ACTIVE_LOW)
|
|
gpiod_toggle_active_low(int3472->pled.gpio);
|
|
|
|
/* Ensure the pin is in output mode and non-active state */
|
|
gpiod_direction_output(int3472->pled.gpio, 0);
|
|
|
|
/* Generate the name, replacing the ':' in the ACPI devname with '_' */
|
|
snprintf(int3472->pled.name, sizeof(int3472->pled.name),
|
|
"%s::privacy_led", acpi_dev_name(int3472->sensor));
|
|
p = strchr(int3472->pled.name, ':');
|
|
if (p)
|
|
*p = '_';
|
|
|
|
int3472->pled.classdev.name = int3472->pled.name;
|
|
int3472->pled.classdev.max_brightness = 1;
|
|
int3472->pled.classdev.brightness_set_blocking = int3472_pled_set;
|
|
|
|
ret = led_classdev_register(int3472->dev, &int3472->pled.classdev);
|
|
if (ret)
|
|
goto err_free_gpio;
|
|
|
|
int3472->pled.lookup.provider = int3472->pled.name;
|
|
int3472->pled.lookup.dev_id = int3472->sensor_name;
|
|
int3472->pled.lookup.con_id = "privacy-led";
|
|
led_add_lookup(&int3472->pled.lookup);
|
|
|
|
return 0;
|
|
|
|
err_free_gpio:
|
|
gpiod_put(int3472->pled.gpio);
|
|
return ret;
|
|
}
|
|
|
|
void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472)
|
|
{
|
|
if (IS_ERR_OR_NULL(int3472->pled.classdev.dev))
|
|
return;
|
|
|
|
led_remove_lookup(&int3472->pled.lookup);
|
|
led_classdev_unregister(&int3472->pled.classdev);
|
|
gpiod_put(int3472->pled.gpio);
|
|
}
|