887d670e29
__scif_get_port() has never taken 'port' as an argument since its inception back in 2015. Probably document the proper arguments expected 'start' and 'end'. Fixes the following W=1 kernel build warnings: drivers/misc/mic/scif/scif_ports.c:36: warning: Function parameter or member 'start' not described in '__scif_get_port drivers/misc/mic/scif/scif_ports.c:36: warning: Function parameter or member 'end' not described in '__scif_get_port' drivers/misc/mic/scif/scif_ports.c:36: warning: Excess function parameter 'port' description in '__scif_get_port' Signed-off-by: Lee Jones <lee.jones@linaro.org> Link: https://lore.kernel.org/r/20200701083118.45744-17-lee.jones@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
116 lines
2.5 KiB
C
116 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Intel MIC Platform Software Stack (MPSS)
|
|
*
|
|
* Copyright(c) 2014 Intel Corporation.
|
|
*
|
|
* Intel SCIF driver.
|
|
*/
|
|
#include <linux/idr.h>
|
|
|
|
#include "scif_main.h"
|
|
|
|
#define SCIF_PORT_COUNT 0x10000 /* Ports available */
|
|
|
|
struct idr scif_ports;
|
|
|
|
/**
|
|
* struct scif_port - SCIF port information
|
|
*
|
|
* @ref_cnt: Reference count since there can be multiple endpoints
|
|
* created via scif_accept(..) simultaneously using a port.
|
|
*/
|
|
struct scif_port {
|
|
int ref_cnt;
|
|
};
|
|
|
|
/**
|
|
* __scif_get_port - Reserve a specified port # for SCIF and add it
|
|
* to the global list.
|
|
* @start: lowest port # to be reserved (inclusive).
|
|
* @end: highest port # to be reserved (exclusive).
|
|
*
|
|
* @return : Allocated SCIF port #, or -ENOSPC if port unavailable.
|
|
* On memory allocation failure, returns -ENOMEM.
|
|
*/
|
|
static int __scif_get_port(int start, int end)
|
|
{
|
|
int id;
|
|
struct scif_port *port = kzalloc(sizeof(*port), GFP_ATOMIC);
|
|
|
|
if (!port)
|
|
return -ENOMEM;
|
|
spin_lock(&scif_info.port_lock);
|
|
id = idr_alloc(&scif_ports, port, start, end, GFP_ATOMIC);
|
|
if (id >= 0)
|
|
port->ref_cnt++;
|
|
spin_unlock(&scif_info.port_lock);
|
|
return id;
|
|
}
|
|
|
|
/**
|
|
* scif_rsrv_port - Reserve a specified port # for SCIF.
|
|
* @port : port # to be reserved.
|
|
*
|
|
* @return : Allocated SCIF port #, or -ENOSPC if port unavailable.
|
|
* On memory allocation failure, returns -ENOMEM.
|
|
*/
|
|
int scif_rsrv_port(u16 port)
|
|
{
|
|
return __scif_get_port(port, port + 1);
|
|
}
|
|
|
|
/**
|
|
* scif_get_new_port - Get and reserve any port # for SCIF in the range
|
|
* SCIF_PORT_RSVD + 1 to SCIF_PORT_COUNT - 1.
|
|
*
|
|
* @return : Allocated SCIF port #, or -ENOSPC if no ports available.
|
|
* On memory allocation failure, returns -ENOMEM.
|
|
*/
|
|
int scif_get_new_port(void)
|
|
{
|
|
return __scif_get_port(SCIF_PORT_RSVD + 1, SCIF_PORT_COUNT);
|
|
}
|
|
|
|
/**
|
|
* scif_get_port - Increment the reference count for a SCIF port
|
|
* @id : SCIF port
|
|
*
|
|
* @return : None
|
|
*/
|
|
void scif_get_port(u16 id)
|
|
{
|
|
struct scif_port *port;
|
|
|
|
if (!id)
|
|
return;
|
|
spin_lock(&scif_info.port_lock);
|
|
port = idr_find(&scif_ports, id);
|
|
if (port)
|
|
port->ref_cnt++;
|
|
spin_unlock(&scif_info.port_lock);
|
|
}
|
|
|
|
/**
|
|
* scif_put_port - Release a reserved SCIF port
|
|
* @id : SCIF port to be released.
|
|
*
|
|
* @return : None
|
|
*/
|
|
void scif_put_port(u16 id)
|
|
{
|
|
struct scif_port *port;
|
|
|
|
if (!id)
|
|
return;
|
|
spin_lock(&scif_info.port_lock);
|
|
port = idr_find(&scif_ports, id);
|
|
if (port) {
|
|
port->ref_cnt--;
|
|
if (!port->ref_cnt) {
|
|
idr_remove(&scif_ports, id);
|
|
kfree(port);
|
|
}
|
|
}
|
|
spin_unlock(&scif_info.port_lock);
|
|
}
|