f1de1c7803
Building VIDEO_ATMEL_ISC as module and VIDEO_ATMEL_XISC as built-in
(or viceversa) causes build errors:
or1k-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o: in function `isc_async_complete':
atmel-isc-base.c:(.text+0x40d0): undefined reference to `__this_module'
or1k-linux-ld: atmel-isc-base.c:(.text+0x40f0): undefined reference to `__this_module'
or1k-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o:(.rodata+0x390): undefined reference to `__this_module'
or1k-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o:(__param+0x4): undefined reference to `__this_module'
or1k-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o:(__param+0x18): undefined reference to `__this_module'
This is caused by the file atmel-isc-base.c which is common code between
the two drivers.
The solution is to create another Kconfig symbol that is automatically
selected and generates the module atmel-isc-base.ko. This module can be
loaded when both drivers are modules, or built-in when at least one of them
is built-in.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: c9aa973884 ("media: atmel: atmel-isc: add microchip-xisc driver")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
42 lines
1.2 KiB
Text
42 lines
1.2 KiB
Text
# SPDX-License-Identifier: GPL-2.0-only
|
|
config VIDEO_ATMEL_ISC
|
|
tristate "ATMEL Image Sensor Controller (ISC) support"
|
|
depends on VIDEO_V4L2 && COMMON_CLK
|
|
depends on ARCH_AT91 || COMPILE_TEST
|
|
select MEDIA_CONTROLLER
|
|
select VIDEO_V4L2_SUBDEV_API
|
|
select VIDEOBUF2_DMA_CONTIG
|
|
select REGMAP_MMIO
|
|
select V4L2_FWNODE
|
|
select VIDEO_ATMEL_ISC_BASE
|
|
help
|
|
This module makes the ATMEL Image Sensor Controller available
|
|
as a v4l2 device.
|
|
|
|
config VIDEO_ATMEL_XISC
|
|
tristate "ATMEL eXtended Image Sensor Controller (XISC) support"
|
|
depends on VIDEO_V4L2 && COMMON_CLK && VIDEO_V4L2_SUBDEV_API
|
|
depends on ARCH_AT91 || COMPILE_TEST
|
|
select VIDEOBUF2_DMA_CONTIG
|
|
select REGMAP_MMIO
|
|
select V4L2_FWNODE
|
|
select VIDEO_ATMEL_ISC_BASE
|
|
help
|
|
This module makes the ATMEL eXtended Image Sensor Controller
|
|
available as a v4l2 device.
|
|
|
|
config VIDEO_ATMEL_ISC_BASE
|
|
tristate
|
|
default n
|
|
help
|
|
ATMEL ISC and XISC common code base.
|
|
|
|
config VIDEO_ATMEL_ISI
|
|
tristate "ATMEL Image Sensor Interface (ISI) support"
|
|
depends on VIDEO_V4L2 && OF
|
|
depends on ARCH_AT91 || COMPILE_TEST
|
|
select VIDEOBUF2_DMA_CONTIG
|
|
select V4L2_FWNODE
|
|
help
|
|
This module makes the ATMEL Image Sensor Interface available
|
|
as a v4l2 device.
|