272fdc0c45
kernel test robot reports over 200 build errors and warnings
that are due to this Kconfig problem when CARL9170=m,
MAC80211=y, and LEDS_CLASS=m.
WARNING: unmet direct dependencies detected for MAC80211_LEDS
Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y])
Selected by [m]:
- CARL9170_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && CARL9170 [=m]
CARL9170_LEDS selects MAC80211_LEDS even though its kconfig
dependencies are not met. This happens because 'select' does not follow
any Kconfig dependency chains.
Fix this by making CARL9170_LEDS depend on MAC80211_LEDS, where
the latter supplies any needed dependencies on LEDS_CLASS.
Fixes: 1d7e1e6b1b ("carl9170: Makefile, Kconfig files and MAINTAINERS")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Suggested-by: Christian Lamparter <chunkeey@googlemail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210530031134.23274-1-rdunlap@infradead.org
53 lines
1.5 KiB
Text
53 lines
1.5 KiB
Text
# SPDX-License-Identifier: GPL-2.0-only
|
|
config CARL9170
|
|
tristate "Linux Community AR9170 802.11n USB support"
|
|
depends on USB && MAC80211
|
|
select ATH_COMMON
|
|
select FW_LOADER
|
|
select CRC32
|
|
help
|
|
This is the mainline driver for the Atheros "otus" 802.11n USB devices.
|
|
|
|
It needs a special firmware (carl9170-1.fw), which can be downloaded
|
|
from our wiki here:
|
|
<https://wireless.wiki.kernel.org/en/users/Drivers/carl9170>
|
|
|
|
If you choose to build a module, it'll be called carl9170.
|
|
|
|
config CARL9170_LEDS
|
|
bool "SoftLED Support"
|
|
default y
|
|
depends on CARL9170
|
|
depends on MAC80211_LEDS
|
|
help
|
|
This option is necessary, if you want your device's LEDs to blink.
|
|
|
|
Say Y, unless you need the LEDs for firmware debugging.
|
|
|
|
config CARL9170_DEBUGFS
|
|
bool "DebugFS Support"
|
|
depends on CARL9170 && DEBUG_FS && MAC80211_DEBUGFS
|
|
default n
|
|
help
|
|
Export several driver and device internals to user space.
|
|
|
|
Say N.
|
|
|
|
config CARL9170_WPC
|
|
bool
|
|
depends on CARL9170 && (INPUT = y || INPUT = CARL9170)
|
|
default y
|
|
|
|
config CARL9170_HWRNG
|
|
bool "Random number generator"
|
|
depends on CARL9170 && (HW_RANDOM = y || HW_RANDOM = CARL9170)
|
|
default n
|
|
help
|
|
Provides a hardware random number generator to the kernel.
|
|
|
|
SECURITY WARNING: It's relatively easy to eavesdrop all
|
|
generated random numbers from the transport stream with
|
|
usbmon [software] or special usb sniffer hardware.
|
|
|
|
Say N, unless your setup[i.e.: embedded system] has no
|
|
other rng source and you can afford to take the risk.
|