1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/phy/mscc
Vladimir Oltean 528a08bcd8 net: phy: mscc: fix packet loss due to RGMII delays
Two deadly typos break RX and TX traffic on the VSC8502 PHY using RGMII
if phy-mode = "rgmii-id" or "rgmii-txid", and no "tx-internal-delay-ps"
override exists. The negative error code from phy_get_internal_delay()
does not get overridden with the delay deduced from the phy-mode, and
later gets committed to hardware. Also, the rx_delay gets overridden by
what should have been the tx_delay.

Fixes: dbb050d2bf ("phy: mscc: Add support for RGMII delay configuration")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Harini Katakam <harini.katakam@amd.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230627134235.3453358-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-06-27 09:31:51 -07:00
..
Makefile net: phy: mscc: improved serdes calibration applied to VSC8514 2021-02-16 14:06:18 -08:00
mscc.h phy: mscc: Use PHY_ID_MATCH_VENDOR to minimize PHY ID table 2023-05-31 22:33:45 -07:00
mscc_fc_buffer.h net: phy: mscc: fix copyright and author information in MACsec 2020-06-24 14:33:16 -07:00
mscc_mac.h net: phy: mscc: fix copyright and author information in MACsec 2020-06-24 14:33:16 -07:00
mscc_macsec.c net: phy: mscc: macsec: do not copy encryption keys 2022-11-18 09:17:42 +00:00
mscc_macsec.h net: phy: mscc: macsec: do not copy encryption keys 2022-11-18 09:17:42 +00:00
mscc_main.c net: phy: mscc: fix packet loss due to RGMII delays 2023-06-27 09:31:51 -07:00
mscc_ptp.c net: phy: Use netif_rx(). 2022-03-06 11:05:31 +00:00
mscc_ptp.h net: phy: mscc: use new PTP_MSGTYPE_* defines 2020-11-25 12:23:21 -08:00
mscc_serdes.c net: phy: mscc: improved serdes calibration applied to VSC8514 2021-02-16 14:06:18 -08:00
mscc_serdes.h net: phy: mscc: improved serdes calibration applied to VSC8514 2021-02-16 14:06:18 -08:00