The current SMN index used for the driver probe seems to be meant
for the BIOS pair and there are potential concurrency problems that can
occur with an inopportune SMI.
It is been advised to use SMN_INDEX_0 instead of SMN_INDEX_2, which is
what amd_nb.c provides and this function has protections to ensure that
only one caller can use it at a time.
Fixes: 156ec4731c
("platform/x86: amd-pmc: Add AMD platform support for S2Idle")
Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20230409185348.556161-6-Shyam-sundar.S-k@amd.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
34 lines
1.1 KiB
Text
34 lines
1.1 KiB
Text
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# AMD x86 Platform Specific Drivers
|
|
#
|
|
|
|
source "drivers/platform/x86/amd/pmf/Kconfig"
|
|
|
|
config AMD_PMC
|
|
tristate "AMD SoC PMC driver"
|
|
depends on ACPI && PCI && RTC_CLASS && AMD_NB
|
|
select SERIO
|
|
help
|
|
The driver provides support for AMD Power Management Controller
|
|
primarily responsible for S2Idle transactions that are driven from
|
|
a platform firmware running on SMU. This driver also provides a debug
|
|
mechanism to investigate the S2Idle transactions and failures.
|
|
|
|
Say Y or M here if you have a notebook powered by AMD RYZEN CPU/APU.
|
|
|
|
If you choose to compile this driver as a module the module will be
|
|
called amd-pmc.
|
|
|
|
config AMD_HSMP
|
|
tristate "AMD HSMP Driver"
|
|
depends on AMD_NB && X86_64
|
|
help
|
|
The driver provides a way for user space tools to monitor and manage
|
|
system management functionality on EPYC server CPUs from AMD.
|
|
|
|
Host System Management Port (HSMP) interface is a mailbox interface
|
|
between the x86 core and the System Management Unit (SMU) firmware.
|
|
|
|
If you choose to compile this driver as a module the module will be
|
|
called amd_hsmp.
|