1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/ethernet/intel/fm10k
Ahmed Zaki fb6e30a725 net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops
The get/set_rxfh ethtool ops currently takes the rxfh (RSS) parameters
as direct function arguments. This will force us to change the API (and
all drivers' functions) every time some new parameters are added.

This is part 1/2 of the fix, as suggested in [1]:

- First simplify the code by always providing a pointer to all params
   (indir, key and func); the fact that some of them may be NULL seems
   like a weird historic thing or a premature optimization.
   It will simplify the drivers if all pointers are always present.

 - Then make the functions take a dev pointer, and a pointer to a
   single struct wrapping all arguments. The set_* should also take
   an extack.

Link: https://lore.kernel.org/netdev/20231121152906.2dd5f487@kernel.org/ [1]
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Suggested-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
Link: https://lore.kernel.org/r/20231213003321.605376-2-ahmed.zaki@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-12-13 22:07:16 -08:00
..
fm10k.h fm10k: convert to new udp_tunnel_nic infra 2020-07-14 17:04:27 -07:00
fm10k_common.c net: intel: Cleanup the copyright/license headers 2018-04-27 14:00:04 -04:00
fm10k_common.h net: intel: Cleanup the copyright/license headers 2018-04-27 14:00:04 -04:00
fm10k_dcbnl.c intel: clean up mismatched header comments 2021-03-23 11:34:02 -07:00
fm10k_debugfs.c intel: clean up mismatched header comments 2021-03-23 11:34:02 -07:00
fm10k_ethtool.c net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops 2023-12-13 22:07:16 -08:00
fm10k_iov.c fm10k: add support for ndo_get_vf_stats operation 2019-11-04 13:12:14 -08:00
fm10k_main.c fm10k: Fix error handling in fm10k_init_module() 2022-11-23 08:36:55 -08:00
fm10k_mbx.c fm10k: remove unexpected word "the" 2022-06-30 10:42:00 -07:00
fm10k_mbx.h net: intel: Cleanup the copyright/license headers 2018-04-27 14:00:04 -04:00
fm10k_netdev.c net: Remove the obsolte u64_stats_fetch_*_irq() users (drivers). 2022-10-28 20:13:54 -07:00
fm10k_pci.c fm10k: Remove unnecessary aer.h include 2023-03-08 23:34:39 -08:00
fm10k_pf.c intel: clean up mismatched header comments 2021-03-23 11:34:02 -07:00
fm10k_pf.h net: intel: Cleanup the copyright/license headers 2018-04-27 14:00:04 -04:00
fm10k_tlv.c intel/fm10k:fix repeated words in comments 2022-06-30 10:56:01 -07:00
fm10k_tlv.h fm10k: add missing field initializers to TLV attributes) 2019-11-04 13:12:14 -08:00
fm10k_type.h fm10k: add support for ndo_get_vf_stats operation 2019-11-04 13:12:14 -08:00
fm10k_vf.c fm10k: mark unused parameters with __always_unused 2019-08-04 04:36:49 -07:00
fm10k_vf.h net: intel: Cleanup the copyright/license headers 2018-04-27 14:00:04 -04:00
Makefile net: intel: Cleanup the copyright/license headers 2018-04-27 14:00:04 -04:00