Maciej Fijalkowski b830c96423 ice: xsk: disable txq irq before flushing hw ... ice_qp_dis() intends to stop a given queue pair that is a target of xsk pool attach/detach. One of the steps is to disable interrupts on these queues. It currently is broken in a way that txq irq is turned off *after* HW flush which in turn takes no effect. ice_qp_dis(): -> ice_qvec_dis_irq() --> disable rxq irq --> flush hw -> ice_vsi_stop_tx_ring() -->disable txq irq Below splat can be triggered by following steps: - start xdpsock WITHOUT loading xdp prog - run xdp_rxq_info with XDP_TX action on this interface - start traffic - terminate xdpsock [ 256.312485] BUG: kernel NULL pointer dereference, address: 0000000000000018 [ 256.319560] #PF: supervisor read access in kernel mode [ 256.324775] #PF: error_code(0x0000) - not-present page [ 256.329994] PGD 0 P4D 0 [ 256.332574] Oops: 0000 [#1] PREEMPT SMP NOPTI [ 256.337006] CPU: 3 PID: 32 Comm: ksoftirqd/3 Tainted: G OE 6.2.0-rc5+ #51 [ 256.345218] Hardware name: Intel Corporation S2600WFT/S2600WFT, BIOS SE5C620.86B.02.01.0008.031920191559 03/19/2019 [ 256.355807] RIP: 0010:ice_clean_rx_irq_zc+0x9c/0x7d0 [ice] [ 256.361423] Code: b7 8f 8a 00 00 00 66 39 ca 0f 84 f1 04 00 00 49 8b 47 40 4c 8b 24 d0 41 0f b7 45 04 66 25 ff 3f 66 89 04 24 0f 84 85 02 00 00 <49> 8b 44 24 18 0f b7 14 24 48 05 00 01 00 00 49 89 04 24 49 89 44 [ 256.380463] RSP: 0018:ffffc900088bfd20 EFLAGS: 00010206 [ 256.385765] RAX: 000000000000003c RBX: 0000000000000035 RCX: 000000000000067f [ 256.393012] RDX: 0000000000000775 RSI: 0000000000000000 RDI: ffff8881deb3ac80 [ 256.400256] RBP: 000000000000003c R08: ffff889847982710 R09: 0000000000010000 [ 256.407500] R10: ffffffff82c060c0 R11: 0000000000000004 R12: 0000000000000000 [ 256.414746] R13: ffff88811165eea0 R14: ffffc9000d255000 R15: ffff888119b37600 [ 256.421990] FS: 0000000000000000(0000) GS:ffff8897e0cc0000(0000) knlGS:0000000000000000 [ 256.430207] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 256.436036] CR2: 0000000000000018 CR3: 0000000005c0a006 CR4: 00000000007706e0 [ 256.443283] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 256.450527] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 256.457770] PKRU: 55555554 [ 256.460529] Call Trace: [ 256.463015] <TASK> [ 256.465157] ? ice_xmit_zc+0x6e/0x150 [ice] [ 256.469437] ice_napi_poll+0x46d/0x680 [ice] [ 256.473815] ? _raw_spin_unlock_irqrestore+0x1b/0x40 [ 256.478863] __napi_poll+0x29/0x160 [ 256.482409] net_rx_action+0x136/0x260 [ 256.486222] __do_softirq+0xe8/0x2e5 [ 256.489853] ? smpboot_thread_fn+0x2c/0x270 [ 256.494108] run_ksoftirqd+0x2a/0x50 [ 256.497747] smpboot_thread_fn+0x1c1/0x270 [ 256.501907] ? __pfx_smpboot_thread_fn+0x10/0x10 [ 256.506594] kthread+0xea/0x120 [ 256.509785] ? __pfx_kthread+0x10/0x10 [ 256.513597] ret_from_fork+0x29/0x50 [ 256.517238] </TASK> In fact, irqs were not disabled and napi managed to be scheduled and run while xsk_pool pointer was still valid, but SW ring of xdp_buff pointers was already freed. To fix this, call ice_qvec_dis_irq() after ice_vsi_stop_tx_ring(). Also while at it, remove redundant ice_clean_rx_ring() call - this is handled in ice_qp_clean_rings(). Fixes: 2d4238f556 ("ice: Add support for AF_XDP") Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com> Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worker at Intel) Acked-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2023-03-16 17:36:58 +00:00
..
ice.h	ice: avoid bonding causing auxiliary plug/unplug under RTNL lock	2023-03-15 00:02:26 -07:00
ice_adminq_cmd.h	ice: Add 'Execute Pending LLDP MIB' Admin Queue command	2023-01-19 08:18:03 -08:00
ice_arfs.c	ice: arfs: fix use-after-free when freeing @rx_cpu_rmap	2022-04-08 09:08:36 -07:00
ice_arfs.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_base.c	ice: Add support for XDP multi-buffer on Rx side	2023-02-01 23:30:27 +01:00
ice_base.h	ice: split ice_ring onto Tx/Rx separate structs	2021-10-15 07:39:02 -07:00
ice_cgu_regs.h	ice: ensure the hardware Clock Generation Unit is configured	2021-12-21 09:11:40 -08:00
ice_common.c	ice: Add GPIO pin support for E823 products	2023-02-14 13:08:02 -08:00
ice_common.h	ice: Add GPIO pin support for E823 products	2023-02-14 13:08:02 -08:00
ice_controlq.c	ice: Cleanup after ice_status removal	2021-12-14 10:19:13 -08:00
ice_controlq.h	ice: add support for sideband messages	2021-06-11 07:38:00 -07:00
ice_dcb.c	ice: Fix DSCP PFC TLV creation	2023-03-07 13:02:01 -08:00
ice_dcb.h	ice: Handle LLDP MIB Pending change	2023-01-19 08:18:03 -08:00
ice_dcb_lib.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-02-02 14:49:55 -08:00
ice_dcb_lib.h	ice: Prevent set_channel from changing queues while RDMA active	2023-01-27 11:32:18 -08:00
ice_dcb_nl.c	ice: Fix problems with DSCP QoS implementation	2021-12-07 13:21:01 -08:00
ice_dcb_nl.h	ice: use static inline for dummy functions	2021-06-07 08:59:01 -07:00
ice_ddp.c	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_ddp.h	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_devids.h	ice: support features on new E810T variants	2022-09-28 11:40:57 -07:00
ice_devlink.c	Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net	2023-02-17 11:06:39 +00:00
ice_devlink.h	ice: Prevent ADQ, DCB coexistence with Custom Tx scheduler	2022-11-17 21:41:28 -08:00
ice_eswitch.c	ice: remove unnecessary virtchnl_ether_addr struct use	2023-02-06 09:47:48 -08:00
ice_eswitch.h	ice: allow creating VFs for !CONFIG_NET_SWITCHDEV	2022-04-14 08:19:54 -07:00
ice_ethtool.c	ice: copy last block omitted in ice_get_module_eeprom()	2023-03-03 08:25:29 +00:00
ice_ethtool_fdir.c	ice: Use correct order for the parameters of devm_kcalloc()	2022-06-08 08:55:13 -07:00
ice_fdir.c	ice: Cleanup after ice_status removal	2021-12-14 10:19:13 -08:00
ice_fdir.h	ice: Add flow director support for channel mode	2021-12-30 13:16:07 +00:00
ice_flex_pipe.c	ice: Reduce scope of variables	2023-01-19 08:18:03 -08:00
ice_flex_pipe.h	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_flex_type.h	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_flow.c	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_flow.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_fltr.c	ice: sync netdev filters after clearing VSI	2023-02-03 09:54:18 -08:00
ice_fltr.h	ice: Introduce ice_vlan struct	2022-02-09 09:24:45 -08:00
ice_fw_update.c	ice: handle E822 generic device ID in PLDM header	2022-07-12 09:25:34 -07:00
ice_fw_update.h	ice: support immediate firmware activation via devlink reload	2021-12-15 08:40:38 -08:00
ice_gnss.c	ice: use GNSS subsystem instead of TTY	2023-01-20 13:27:17 +00:00
ice_gnss.h	ice: remove unnecessary CONFIG_ICE_GNSS	2023-02-26 14:53:09 +00:00
ice_hw_autogen.h	ice: Add support Flex RXD	2022-10-27 13:23:43 +02:00
ice_idc.c	ice: alloc id for RDMA using xa_array	2023-02-03 09:54:18 -08:00
ice_idc_int.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_lag.c	ice: remove non-inclusive language	2022-08-18 08:26:11 -07:00
ice_lag.h	ice: remove non-inclusive language	2022-08-18 08:26:11 -07:00
ice_lan_tx_rx.h	ice: Remove and replace ice speed defines with ethtool.h versions	2022-11-23 08:59:42 -08:00
ice_lib.c	ice: don't ignore return codes in VSI related code	2023-03-07 13:02:01 -08:00
ice_lib.h	ice: refactor VSI setup to use parameter structure	2023-02-06 09:37:31 -08:00
ice_main.c	ice: avoid bonding causing auxiliary plug/unplug under RTNL lock	2023-03-15 00:02:26 -07:00
ice_nvm.c	ice: Remove cppcheck suppressions	2023-01-19 08:18:03 -08:00
ice_nvm.h	ice: Add additional flags to ice_nvm_write_activate	2022-08-24 08:45:54 -07:00
ice_osdep.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_pf_vsi_vlan_ops.c	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_pf_vsi_vlan_ops.h	ice: Add outer_vlan_ops and VSI specific VLAN ops implementations	2022-02-09 09:24:45 -08:00
ice_protocol_type.h	ice: Add L2TPv3 hardware offload support	2022-09-20 09:13:38 +02:00
ice_ptp.c	ice/ptp: fix the PTP worker retrying indefinitely if the link went down	2023-02-14 13:08:02 -08:00
ice_ptp.h	ice: handle flushing stale Tx timestamps in ice_ptp_tx_tstamp	2022-12-08 13:15:03 -08:00
ice_ptp_consts.h	ice: ensure the hardware Clock Generation Unit is configured	2021-12-21 09:11:40 -08:00
ice_ptp_hw.c	ice: make Tx and Rx vernier offset calibration independent	2022-12-08 13:15:03 -08:00
ice_ptp_hw.h	ice: make Tx and Rx vernier offset calibration independent	2022-12-08 13:15:03 -08:00
ice_repr.c	ice: Accumulate ring statistics over reset	2022-11-23 08:59:43 -08:00
ice_repr.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_sbq_cmd.h	ice: add support for sideband messages	2021-06-11 07:38:00 -07:00
ice_sched.c	ice: Reduce scope of variables	2023-01-19 08:18:03 -08:00
ice_sched.h	ice: Add an option to pre-allocate memory for ice_sched_node	2022-11-17 21:41:28 -08:00
ice_sriov.c	ice: remove unnecessary virtchnl_ether_addr struct use	2023-02-06 09:47:48 -08:00
ice_sriov.h	ice: introduce ice_virtchnl.c and ice_virtchnl.h	2022-03-15 13:23:10 -07:00
ice_switch.c	ice: switch: fix potential memleak in ice_add_adv_recipe()	2023-02-06 15:13:02 -08:00
ice_switch.h	ice: Introduce enabling promiscuous mode on multiple VF's	2022-07-28 11:44:22 -07:00
ice_tc_lib.c	ethernet: ice: avoid gcc-9 integer overflow warning	2023-03-07 13:02:01 -08:00
ice_tc_lib.h	ice: Support drop action	2023-01-19 08:18:03 -08:00
ice_trace.h	ice: add trace events for tx timestamps	2022-03-16 10:38:15 -07:00
ice_txrx.c	bpf-next-for-netdev	2023-02-20 16:31:14 -08:00
ice_txrx.h	ice: Fix freeing XDP frames backed by Page Pool	2023-02-13 19:13:12 +01:00
ice_txrx_lib.c	ice: Micro-optimize .ndo_xdp_xmit() path	2023-02-13 19:13:13 +01:00
ice_txrx_lib.h	ice: Micro-optimize .ndo_xdp_xmit() path	2023-02-13 19:13:13 +01:00
ice_type.h	ice: Prevent ADQ, DCB coexistence with Custom Tx scheduler	2022-11-17 21:41:28 -08:00
ice_vf_lib.c	ice: remove unnecessary virtchnl_ether_addr struct use	2023-02-06 09:47:48 -08:00
ice_vf_lib.h	ice: remove unnecessary virtchnl_ether_addr struct use	2023-02-06 09:47:48 -08:00
ice_vf_lib_private.h	ice: introduce ice_vf_init_host_cfg function	2023-02-06 09:41:56 -08:00
ice_vf_mbx.c	ice: fix out-of-bounds KASAN warning in virtchnl	2023-02-06 15:13:02 -08:00
ice_vf_mbx.h	ice: rename ice_sriov.c to ice_vf_mbx.c	2022-03-14 17:22:58 -07:00
ice_vf_vsi_vlan_ops.c	ice: Fix disabling Rx VLAN filtering with port VLAN enabled	2023-02-06 15:13:02 -08:00
ice_vf_vsi_vlan_ops.h	ice: Add support for VIRTCHNL_VF_OFFLOAD_VLAN_V2	2022-02-09 09:24:45 -08:00
ice_virtchnl.c	ice: remove unnecessary virtchnl_ether_addr struct use	2023-02-06 09:47:48 -08:00
ice_virtchnl.h	ice: virtchnl rss hena support	2022-11-14 10:44:38 +00:00
ice_virtchnl_allowlist.c	ice: Add support Flex RXD	2022-10-27 13:23:43 +02:00
ice_virtchnl_allowlist.h	ice: Allow ignoring opcodes on specific VF	2021-04-22 09:26:22 -07:00
ice_virtchnl_fdir.c	ice: Add more usage of existing function ice_get_vf_vsi(vf)	2023-02-06 09:33:12 -08:00
ice_virtchnl_fdir.h	ice: introduce ice_vf_lib.c, ice_vf_lib.h, and ice_vf_lib_private.h	2022-03-15 13:22:13 -07:00
ice_vlan.h	ice: Use the proto argument for VLAN ops	2022-02-09 09:24:45 -08:00
ice_vlan_mode.c	ice: Add support for VLAN TPID filters in switchdev	2022-06-30 13:53:33 -07:00
ice_vlan_mode.h	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_lib.c	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_lib.h	ice: Add outer_vlan_ops and VSI specific VLAN ops implementations	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_ops.c	ice: Add outer_vlan_ops and VSI specific VLAN ops implementations	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_ops.h	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_xsk.c	ice: xsk: disable txq irq before flushing hw	2023-03-16 17:36:58 +00:00
ice_xsk.h	ice: xsk: change batched Tx descriptor cleaning	2022-09-27 08:11:02 -07:00
Makefile	ice: remove unnecessary CONFIG_ICE_GNSS	2023-02-26 14:53:09 +00:00