Previously, we assumed we could use mutex_trylock() within an atomic context, falling back to a worker if contended. However, such trickery is illegal inside interrupt context, and so we need to always use a worker under such circumstances. As we normally are in process context, we can typically use a plain mutex, and only defer to a work when we know we are being called from an interrupt path. Fixes:51fbd8de87
("drm/i915/pmu: Atomically acquire the gt_pm wakeref") References:a0855d24fc
("locking/mutex: Complain upon mutex API misuse in IRQ contexts") References: https://bugs.freedesktop.org/show_bug.cgi?id=111626 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20191120125433.3767149-1-chris@chris-wilson.co.uk (cherry picked from commit07779a76ee
) Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
46 lines
1 KiB
C
46 lines
1 KiB
C
/*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Copyright © 2019 Intel Corporation
|
|
*/
|
|
|
|
#ifndef INTEL_ENGINE_PM_H
|
|
#define INTEL_ENGINE_PM_H
|
|
|
|
#include "intel_engine_types.h"
|
|
#include "intel_wakeref.h"
|
|
|
|
static inline bool
|
|
intel_engine_pm_is_awake(const struct intel_engine_cs *engine)
|
|
{
|
|
return intel_wakeref_is_active(&engine->wakeref);
|
|
}
|
|
|
|
static inline void intel_engine_pm_get(struct intel_engine_cs *engine)
|
|
{
|
|
intel_wakeref_get(&engine->wakeref);
|
|
}
|
|
|
|
static inline bool intel_engine_pm_get_if_awake(struct intel_engine_cs *engine)
|
|
{
|
|
return intel_wakeref_get_if_active(&engine->wakeref);
|
|
}
|
|
|
|
static inline void intel_engine_pm_put(struct intel_engine_cs *engine)
|
|
{
|
|
intel_wakeref_put(&engine->wakeref);
|
|
}
|
|
|
|
static inline void intel_engine_pm_put_async(struct intel_engine_cs *engine)
|
|
{
|
|
intel_wakeref_put_async(&engine->wakeref);
|
|
}
|
|
|
|
static inline void intel_engine_pm_flush(struct intel_engine_cs *engine)
|
|
{
|
|
intel_wakeref_unlock_wait(&engine->wakeref);
|
|
}
|
|
|
|
void intel_engine_init__pm(struct intel_engine_cs *engine);
|
|
|
|
#endif /* INTEL_ENGINE_PM_H */
|