Someone on IRC once asked an innocent enough sounding question: Why with xf86-video-modesetting is es2gears limited at 120fps. So I broke out the perfetto tracing mesa MR and took a look. It turns out the problem was drm_atomic_helper_dirtyfb(), which would end up waiting for vblank.. es2gears would rapidly push two frames to Xorg, which would blit them to screen and in idle hook (I assume) call the DIRTYFB ioctl. Which in turn would do an atomic update to flush the dirty rects, which would stall until the next vblank. And then the whole process would repeat. But this is a bit silly, we only need dirtyfb for command mode DSI panels. So track in plane state whether dirtyfb is required, and track in the fb how many attached planes require dirtyfb so that we can skip it when not required. (Note, mdp4 does not actually have cmd mode support.) Signed-off-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20220223191118.881321-1-robdclark@gmail.com Signed-off-by: Rob Clark <robdclark@chromium.org>
274 lines
6.8 KiB
C
274 lines
6.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2013 Red Hat
|
|
* Author: Rob Clark <robdclark@gmail.com>
|
|
*/
|
|
|
|
#include <drm/drm_crtc.h>
|
|
#include <drm/drm_damage_helper.h>
|
|
#include <drm/drm_file.h>
|
|
#include <drm/drm_fourcc.h>
|
|
#include <drm/drm_gem_framebuffer_helper.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
|
|
#include "msm_drv.h"
|
|
#include "msm_kms.h"
|
|
#include "msm_gem.h"
|
|
|
|
struct msm_framebuffer {
|
|
struct drm_framebuffer base;
|
|
const struct msm_format *format;
|
|
|
|
/* Count of # of attached planes which need dirtyfb: */
|
|
refcount_t dirtyfb;
|
|
};
|
|
#define to_msm_framebuffer(x) container_of(x, struct msm_framebuffer, base)
|
|
|
|
static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev,
|
|
const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_object **bos);
|
|
|
|
static int msm_framebuffer_dirtyfb(struct drm_framebuffer *fb,
|
|
struct drm_file *file_priv, unsigned int flags,
|
|
unsigned int color, struct drm_clip_rect *clips,
|
|
unsigned int num_clips)
|
|
{
|
|
struct msm_framebuffer *msm_fb = to_msm_framebuffer(fb);
|
|
|
|
/* If this fb is not used on any display requiring pixel data to be
|
|
* flushed, then skip dirtyfb
|
|
*/
|
|
if (refcount_read(&msm_fb->dirtyfb) == 0)
|
|
return 0;
|
|
|
|
return drm_atomic_helper_dirtyfb(fb, file_priv, flags, color,
|
|
clips, num_clips);
|
|
}
|
|
|
|
static const struct drm_framebuffer_funcs msm_framebuffer_funcs = {
|
|
.create_handle = drm_gem_fb_create_handle,
|
|
.destroy = drm_gem_fb_destroy,
|
|
.dirty = msm_framebuffer_dirtyfb,
|
|
};
|
|
|
|
#ifdef CONFIG_DEBUG_FS
|
|
void msm_framebuffer_describe(struct drm_framebuffer *fb, struct seq_file *m)
|
|
{
|
|
struct msm_gem_stats stats = {};
|
|
int i, n = fb->format->num_planes;
|
|
|
|
seq_printf(m, "fb: %dx%d@%4.4s (%2d, ID:%d)\n",
|
|
fb->width, fb->height, (char *)&fb->format->format,
|
|
drm_framebuffer_read_refcount(fb), fb->base.id);
|
|
|
|
for (i = 0; i < n; i++) {
|
|
seq_printf(m, " %d: offset=%d pitch=%d, obj: ",
|
|
i, fb->offsets[i], fb->pitches[i]);
|
|
msm_gem_describe(fb->obj[i], m, &stats);
|
|
}
|
|
}
|
|
#endif
|
|
|
|
/* prepare/pin all the fb's bo's for scanout.
|
|
*/
|
|
int msm_framebuffer_prepare(struct drm_framebuffer *fb,
|
|
struct msm_gem_address_space *aspace,
|
|
bool needs_dirtyfb)
|
|
{
|
|
struct msm_framebuffer *msm_fb = to_msm_framebuffer(fb);
|
|
int ret, i, n = fb->format->num_planes;
|
|
uint64_t iova;
|
|
|
|
if (needs_dirtyfb)
|
|
refcount_inc(&msm_fb->dirtyfb);
|
|
|
|
for (i = 0; i < n; i++) {
|
|
ret = msm_gem_get_and_pin_iova(fb->obj[i], aspace, &iova);
|
|
drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)", fb->base.id, i, iova, ret);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
void msm_framebuffer_cleanup(struct drm_framebuffer *fb,
|
|
struct msm_gem_address_space *aspace,
|
|
bool needed_dirtyfb)
|
|
{
|
|
struct msm_framebuffer *msm_fb = to_msm_framebuffer(fb);
|
|
int i, n = fb->format->num_planes;
|
|
|
|
if (needed_dirtyfb)
|
|
refcount_dec(&msm_fb->dirtyfb);
|
|
|
|
for (i = 0; i < n; i++)
|
|
msm_gem_unpin_iova(fb->obj[i], aspace);
|
|
}
|
|
|
|
uint32_t msm_framebuffer_iova(struct drm_framebuffer *fb,
|
|
struct msm_gem_address_space *aspace, int plane)
|
|
{
|
|
if (!fb->obj[plane])
|
|
return 0;
|
|
return msm_gem_iova(fb->obj[plane], aspace) + fb->offsets[plane];
|
|
}
|
|
|
|
struct drm_gem_object *msm_framebuffer_bo(struct drm_framebuffer *fb, int plane)
|
|
{
|
|
return drm_gem_fb_get_obj(fb, plane);
|
|
}
|
|
|
|
const struct msm_format *msm_framebuffer_format(struct drm_framebuffer *fb)
|
|
{
|
|
struct msm_framebuffer *msm_fb = to_msm_framebuffer(fb);
|
|
return msm_fb->format;
|
|
}
|
|
|
|
struct drm_framebuffer *msm_framebuffer_create(struct drm_device *dev,
|
|
struct drm_file *file, const struct drm_mode_fb_cmd2 *mode_cmd)
|
|
{
|
|
const struct drm_format_info *info = drm_get_format_info(dev,
|
|
mode_cmd);
|
|
struct drm_gem_object *bos[4] = {0};
|
|
struct drm_framebuffer *fb;
|
|
int ret, i, n = info->num_planes;
|
|
|
|
for (i = 0; i < n; i++) {
|
|
bos[i] = drm_gem_object_lookup(file, mode_cmd->handles[i]);
|
|
if (!bos[i]) {
|
|
ret = -ENXIO;
|
|
goto out_unref;
|
|
}
|
|
}
|
|
|
|
fb = msm_framebuffer_init(dev, mode_cmd, bos);
|
|
if (IS_ERR(fb)) {
|
|
ret = PTR_ERR(fb);
|
|
goto out_unref;
|
|
}
|
|
|
|
return fb;
|
|
|
|
out_unref:
|
|
for (i = 0; i < n; i++)
|
|
drm_gem_object_put(bos[i]);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev,
|
|
const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_object **bos)
|
|
{
|
|
const struct drm_format_info *info = drm_get_format_info(dev,
|
|
mode_cmd);
|
|
struct msm_drm_private *priv = dev->dev_private;
|
|
struct msm_kms *kms = priv->kms;
|
|
struct msm_framebuffer *msm_fb = NULL;
|
|
struct drm_framebuffer *fb;
|
|
const struct msm_format *format;
|
|
int ret, i, n;
|
|
|
|
drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)",
|
|
mode_cmd, mode_cmd->width, mode_cmd->height,
|
|
(char *)&mode_cmd->pixel_format);
|
|
|
|
n = info->num_planes;
|
|
format = kms->funcs->get_format(kms, mode_cmd->pixel_format,
|
|
mode_cmd->modifier[0]);
|
|
if (!format) {
|
|
DRM_DEV_ERROR(dev->dev, "unsupported pixel format: %4.4s\n",
|
|
(char *)&mode_cmd->pixel_format);
|
|
ret = -EINVAL;
|
|
goto fail;
|
|
}
|
|
|
|
msm_fb = kzalloc(sizeof(*msm_fb), GFP_KERNEL);
|
|
if (!msm_fb) {
|
|
ret = -ENOMEM;
|
|
goto fail;
|
|
}
|
|
|
|
fb = &msm_fb->base;
|
|
|
|
msm_fb->format = format;
|
|
|
|
if (n > ARRAY_SIZE(fb->obj)) {
|
|
ret = -EINVAL;
|
|
goto fail;
|
|
}
|
|
|
|
for (i = 0; i < n; i++) {
|
|
unsigned int width = mode_cmd->width / (i ? info->hsub : 1);
|
|
unsigned int height = mode_cmd->height / (i ? info->vsub : 1);
|
|
unsigned int min_size;
|
|
|
|
min_size = (height - 1) * mode_cmd->pitches[i]
|
|
+ width * info->cpp[i]
|
|
+ mode_cmd->offsets[i];
|
|
|
|
if (bos[i]->size < min_size) {
|
|
ret = -EINVAL;
|
|
goto fail;
|
|
}
|
|
|
|
msm_fb->base.obj[i] = bos[i];
|
|
}
|
|
|
|
drm_helper_mode_fill_fb_struct(dev, fb, mode_cmd);
|
|
|
|
ret = drm_framebuffer_init(dev, fb, &msm_framebuffer_funcs);
|
|
if (ret) {
|
|
DRM_DEV_ERROR(dev->dev, "framebuffer init failed: %d\n", ret);
|
|
goto fail;
|
|
}
|
|
|
|
drm_dbg_state(dev, "create: FB ID: %d (%p)", fb->base.id, fb);
|
|
|
|
return fb;
|
|
|
|
fail:
|
|
kfree(msm_fb);
|
|
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
struct drm_framebuffer *
|
|
msm_alloc_stolen_fb(struct drm_device *dev, int w, int h, int p, uint32_t format)
|
|
{
|
|
struct drm_mode_fb_cmd2 mode_cmd = {
|
|
.pixel_format = format,
|
|
.width = w,
|
|
.height = h,
|
|
.pitches = { p },
|
|
};
|
|
struct drm_gem_object *bo;
|
|
struct drm_framebuffer *fb;
|
|
int size;
|
|
|
|
/* allocate backing bo */
|
|
size = mode_cmd.pitches[0] * mode_cmd.height;
|
|
DBG("allocating %d bytes for fb %d", size, dev->primary->index);
|
|
bo = msm_gem_new(dev, size, MSM_BO_SCANOUT | MSM_BO_WC | MSM_BO_STOLEN);
|
|
if (IS_ERR(bo)) {
|
|
dev_warn(dev->dev, "could not allocate stolen bo\n");
|
|
/* try regular bo: */
|
|
bo = msm_gem_new(dev, size, MSM_BO_SCANOUT | MSM_BO_WC);
|
|
}
|
|
if (IS_ERR(bo)) {
|
|
DRM_DEV_ERROR(dev->dev, "failed to allocate buffer object\n");
|
|
return ERR_CAST(bo);
|
|
}
|
|
|
|
msm_gem_object_set_name(bo, "stolenfb");
|
|
|
|
fb = msm_framebuffer_init(dev, &mode_cmd, &bo);
|
|
if (IS_ERR(fb)) {
|
|
DRM_DEV_ERROR(dev->dev, "failed to allocate fb\n");
|
|
/* note: if fb creation failed, we can't rely on fb destroy
|
|
* to unref the bo:
|
|
*/
|
|
drm_gem_object_put(bo);
|
|
return ERR_CAST(fb);
|
|
}
|
|
|
|
return fb;
|
|
}
|