1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/ethernet/qlogic
Nathan Chancellor d3a315795b qed: Avoid implicit enum conversion in qed_roce_mode_to_flavor
Clang warns when one enumerated type is implicitly converted to another.

drivers/net/ethernet/qlogic/qed/qed_roce.c:153:12: warning: implicit
conversion from enumeration type 'enum roce_mode' to different
enumeration type 'enum roce_flavor' [-Wenum-conversion]
                flavor = ROCE_V2_IPV6;
                       ~ ^~~~~~~~~~~~
drivers/net/ethernet/qlogic/qed/qed_roce.c:156:12: warning: implicit
conversion from enumeration type 'enum roce_mode' to different
enumeration type 'enum roce_flavor' [-Wenum-conversion]
                flavor = MAX_ROCE_MODE;
                       ~ ^~~~~~~~~~~~~
2 warnings generated.

Use the appropriate values from the expected type, roce_flavor:

ROCE_V2_IPV6 = RROCE_IPV6 = 2
MAX_ROCE_MODE = MAX_ROCE_FLAVOR = 3

While we're add it, ditch the local variable flavor, we can just return
the value directly from the switch statement.

Link: https://github.com/ClangBuiltLinux/linux/issues/125
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-09-26 20:18:44 -07:00
..
netxen netxen_nic: Mark expected switch fall-throughs 2018-08-07 17:54:20 -07:00
qed qed: Avoid implicit enum conversion in qed_roce_mode_to_flavor 2018-09-26 20:18:44 -07:00
qede net_sched: remove list_head from tc_action 2018-08-21 12:45:44 -07:00
qlcnic ethernet/qlogic: remove unused array msi_tgt_status 2018-08-09 14:16:51 -07:00
qlge qlge: Fix netdev features configuration. 2018-08-25 17:37:38 -07:00
Kconfig qed*: Utilize FW 8.33.1.0 2018-01-02 13:59:16 -05:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
qla3xxx.c net: qla3xxx: Eliminate duplicate barriers on weakly-ordered archs 2018-03-26 12:47:55 -04:00
qla3xxx.h