An errant disk backup on my desktop got into debugfs and triggered the
following deadlock scenario in the amdgpu debugfs files. The machine
also hard-resets immediately after those lines are printed (although I
wasn't able to reproduce that part when reading by hand):
[ 1318.016074][ T1082] ======================================================
[ 1318.016607][ T1082] WARNING: possible circular locking dependency detected
[ 1318.017107][ T1082] 6.8.0-rc7-00015-ge0c8221b72c0 #17 Not tainted
[ 1318.017598][ T1082] ------------------------------------------------------
[ 1318.018096][ T1082] tar/1082 is trying to acquire lock:
[ 1318.018585][ T1082] ffff98c44175d6a0 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0x40/0x80
[ 1318.019084][ T1082]
[ 1318.019084][ T1082] but task is already holding lock:
[ 1318.020052][ T1082] ffff98c4c13f55f8 (reservation_ww_class_mutex){+.+.}-{3:3}, at: amdgpu_debugfs_mqd_read+0x6a/0x250 [amdgpu]
[ 1318.020607][ T1082]
[ 1318.020607][ T1082] which lock already depends on the new lock.
[ 1318.020607][ T1082]
[ 1318.022081][ T1082]
[ 1318.022081][ T1082] the existing dependency chain (in reverse order) is:
[ 1318.023083][ T1082]
[ 1318.023083][ T1082] -> #2 (reservation_ww_class_mutex){+.+.}-{3:3}:
[ 1318.024114][ T1082] __ww_mutex_lock.constprop.0+0xe0/0x12f0
[ 1318.024639][ T1082] ww_mutex_lock+0x32/0x90
[ 1318.025161][ T1082] dma_resv_lockdep+0x18a/0x330
[ 1318.025683][ T1082] do_one_initcall+0x6a/0x350
[ 1318.026210][ T1082] kernel_init_freeable+0x1a3/0x310
[ 1318.026728][ T1082] kernel_init+0x15/0x1a0
[ 1318.027242][ T1082] ret_from_fork+0x2c/0x40
[ 1318.027759][ T1082] ret_from_fork_asm+0x11/0x20
[ 1318.028281][ T1082]
[ 1318.028281][ T1082] -> #1 (reservation_ww_class_acquire){+.+.}-{0:0}:
[ 1318.029297][ T1082] dma_resv_lockdep+0x16c/0x330
[ 1318.029790][ T1082] do_one_initcall+0x6a/0x350
[ 1318.030263][ T1082] kernel_init_freeable+0x1a3/0x310
[ 1318.030722][ T1082] kernel_init+0x15/0x1a0
[ 1318.031168][ T1082] ret_from_fork+0x2c/0x40
[ 1318.031598][ T1082] ret_from_fork_asm+0x11/0x20
[ 1318.032011][ T1082]
[ 1318.032011][ T1082] -> #0 (&mm->mmap_lock){++++}-{3:3}:
[ 1318.032778][ T1082] __lock_acquire+0x14bf/0x2680
[ 1318.033141][ T1082] lock_acquire+0xcd/0x2c0
[ 1318.033487][ T1082] __might_fault+0x58/0x80
[ 1318.033814][ T1082] amdgpu_debugfs_mqd_read+0x103/0x250 [amdgpu]
[ 1318.034181][ T1082] full_proxy_read+0x55/0x80
[ 1318.034487][ T1082] vfs_read+0xa7/0x360
[ 1318.034788][ T1082] ksys_read+0x70/0xf0
[ 1318.035085][ T1082] do_syscall_64+0x94/0x180
[ 1318.035375][ T1082] entry_SYSCALL_64_after_hwframe+0x46/0x4e
[ 1318.035664][ T1082]
[ 1318.035664][ T1082] other info that might help us debug this:
[ 1318.035664][ T1082]
[ 1318.036487][ T1082] Chain exists of:
[ 1318.036487][ T1082] &mm->mmap_lock --> reservation_ww_class_acquire --> reservation_ww_class_mutex
[ 1318.036487][ T1082]
[ 1318.037310][ T1082] Possible unsafe locking scenario:
[ 1318.037310][ T1082]
[ 1318.037838][ T1082] CPU0 CPU1
[ 1318.038101][ T1082] ---- ----
[ 1318.038350][ T1082] lock(reservation_ww_class_mutex);
[ 1318.038590][ T1082] lock(reservation_ww_class_acquire);
[ 1318.038839][ T1082] lock(reservation_ww_class_mutex);
[ 1318.039083][ T1082] rlock(&mm->mmap_lock);
[ 1318.039328][ T1082]
[ 1318.039328][ T1082] *** DEADLOCK ***
[ 1318.039328][ T1082]
[ 1318.040029][ T1082] 1 lock held by tar/1082:
[ 1318.040259][ T1082] #0: ffff98c4c13f55f8 (reservation_ww_class_mutex){+.+.}-{3:3}, at: amdgpu_debugfs_mqd_read+0x6a/0x250 [amdgpu]
[ 1318.040560][ T1082]
[ 1318.040560][ T1082] stack backtrace:
[ 1318.041053][ T1082] CPU: 22 PID: 1082 Comm: tar Not tainted 6.8.0-rc7-00015-ge0c8221b72c0 #17 3316c85d50e282c5643b075d1f01a4f6365e39c2
[ 1318.041329][ T1082] Hardware name: Gigabyte Technology Co., Ltd. B650 AORUS PRO AX/B650 AORUS PRO AX, BIOS F20 12/14/2023
[ 1318.041614][ T1082] Call Trace:
[ 1318.041895][ T1082] <TASK>
[ 1318.042175][ T1082] dump_stack_lvl+0x4a/0x80
[ 1318.042460][ T1082] check_noncircular+0x145/0x160
[ 1318.042743][ T1082] __lock_acquire+0x14bf/0x2680
[ 1318.043022][ T1082] lock_acquire+0xcd/0x2c0
[ 1318.043301][ T1082] ? __might_fault+0x40/0x80
[ 1318.043580][ T1082] ? __might_fault+0x40/0x80
[ 1318.043856][ T1082] __might_fault+0x58/0x80
[ 1318.044131][ T1082] ? __might_fault+0x40/0x80
[ 1318.044408][ T1082] amdgpu_debugfs_mqd_read+0x103/0x250 [amdgpu 8fe2afaa910cbd7654c8cab23563a94d6caebaab]
[ 1318.044749][ T1082] full_proxy_read+0x55/0x80
[ 1318.045042][ T1082] vfs_read+0xa7/0x360
[ 1318.045333][ T1082] ksys_read+0x70/0xf0
[ 1318.045623][ T1082] do_syscall_64+0x94/0x180
[ 1318.045913][ T1082] ? do_syscall_64+0xa0/0x180
[ 1318.046201][ T1082] ? lockdep_hardirqs_on+0x7d/0x100
[ 1318.046487][ T1082] ? do_syscall_64+0xa0/0x180
[ 1318.046773][ T1082] ? do_syscall_64+0xa0/0x180
[ 1318.047057][ T1082] ? do_syscall_64+0xa0/0x180
[ 1318.047337][ T1082] ? do_syscall_64+0xa0/0x180
[ 1318.047611][ T1082] entry_SYSCALL_64_after_hwframe+0x46/0x4e
[ 1318.047887][ T1082] RIP: 0033:0x7f480b70a39d
[ 1318.048162][ T1082] Code: 91 ba 0d 00 f7 d8 64 89 02 b8 ff ff ff ff eb b2 e8 18 a3 01 00 0f 1f 84 00 00 00 00 00 80 3d a9 3c 0e 00 00 74 17 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 5b c3 66 2e 0f 1f 84 00 00 00 00 00 53 48 83
[ 1318.048769][ T1082] RSP: 002b:00007ffde77f5c68 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
[ 1318.049083][ T1082] RAX: ffffffffffffffda RBX: 0000000000000800 RCX: 00007f480b70a39d
[ 1318.049392][ T1082] RDX: 0000000000000800 RSI: 000055c9f2120c00 RDI: 0000000000000008
[ 1318.049703][ T1082] RBP: 0000000000000800 R08: 000055c9f2120a94 R09: 0000000000000007
[ 1318.050011][ T1082] R10: 0000000000000000 R11: 0000000000000246 R12: 000055c9f2120c00
[ 1318.050324][ T1082] R13: 0000000000000008 R14: 0000000000000008 R15: 0000000000000800
[ 1318.050638][ T1082] </TASK>
amdgpu_debugfs_mqd_read() holds a reservation when it calls
put_user(), which may fault and acquire the mmap_sem. This violates
the established locking order.
Bounce the mqd data through a kernel buffer to get put_user() out of
the illegal section.
Fixes: 445d85e3c1
("drm/amdgpu: add debugfs interface for reading MQDs")
Cc: stable@vger.kernel.org # v6.5+
Reviewed-by: Shashank Sharma <shashank.sharma@amd.com>
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
743 lines
19 KiB
C
743 lines
19 KiB
C
/*
|
|
* Copyright 2008 Advanced Micro Devices, Inc.
|
|
* Copyright 2008 Red Hat Inc.
|
|
* Copyright 2009 Jerome Glisse.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* Authors: Dave Airlie
|
|
* Alex Deucher
|
|
* Jerome Glisse
|
|
* Christian König
|
|
*/
|
|
#include <linux/seq_file.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/uaccess.h>
|
|
#include <linux/debugfs.h>
|
|
|
|
#include <drm/amdgpu_drm.h>
|
|
#include "amdgpu.h"
|
|
#include "atom.h"
|
|
|
|
/*
|
|
* Rings
|
|
* Most engines on the GPU are fed via ring buffers. Ring
|
|
* buffers are areas of GPU accessible memory that the host
|
|
* writes commands into and the GPU reads commands out of.
|
|
* There is a rptr (read pointer) that determines where the
|
|
* GPU is currently reading, and a wptr (write pointer)
|
|
* which determines where the host has written. When the
|
|
* pointers are equal, the ring is idle. When the host
|
|
* writes commands to the ring buffer, it increments the
|
|
* wptr. The GPU then starts fetching commands and executes
|
|
* them until the pointers are equal again.
|
|
*/
|
|
|
|
/**
|
|
* amdgpu_ring_max_ibs - Return max IBs that fit in a single submission.
|
|
*
|
|
* @type: ring type for which to return the limit.
|
|
*/
|
|
unsigned int amdgpu_ring_max_ibs(enum amdgpu_ring_type type)
|
|
{
|
|
switch (type) {
|
|
case AMDGPU_RING_TYPE_GFX:
|
|
/* Need to keep at least 192 on GFX7+ for old radv. */
|
|
return 192;
|
|
case AMDGPU_RING_TYPE_COMPUTE:
|
|
return 125;
|
|
case AMDGPU_RING_TYPE_VCN_JPEG:
|
|
return 16;
|
|
default:
|
|
return 49;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* amdgpu_ring_alloc - allocate space on the ring buffer
|
|
*
|
|
* @ring: amdgpu_ring structure holding ring information
|
|
* @ndw: number of dwords to allocate in the ring buffer
|
|
*
|
|
* Allocate @ndw dwords in the ring buffer (all asics).
|
|
* Returns 0 on success, error on failure.
|
|
*/
|
|
int amdgpu_ring_alloc(struct amdgpu_ring *ring, unsigned int ndw)
|
|
{
|
|
/* Align requested size with padding so unlock_commit can
|
|
* pad safely */
|
|
ndw = (ndw + ring->funcs->align_mask) & ~ring->funcs->align_mask;
|
|
|
|
/* Make sure we aren't trying to allocate more space
|
|
* than the maximum for one submission
|
|
*/
|
|
if (WARN_ON_ONCE(ndw > ring->max_dw))
|
|
return -ENOMEM;
|
|
|
|
ring->count_dw = ndw;
|
|
ring->wptr_old = ring->wptr;
|
|
|
|
if (ring->funcs->begin_use)
|
|
ring->funcs->begin_use(ring);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/** amdgpu_ring_insert_nop - insert NOP packets
|
|
*
|
|
* @ring: amdgpu_ring structure holding ring information
|
|
* @count: the number of NOP packets to insert
|
|
*
|
|
* This is the generic insert_nop function for rings except SDMA
|
|
*/
|
|
void amdgpu_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < count; i++)
|
|
amdgpu_ring_write(ring, ring->funcs->nop);
|
|
}
|
|
|
|
/**
|
|
* amdgpu_ring_generic_pad_ib - pad IB with NOP packets
|
|
*
|
|
* @ring: amdgpu_ring structure holding ring information
|
|
* @ib: IB to add NOP packets to
|
|
*
|
|
* This is the generic pad_ib function for rings except SDMA
|
|
*/
|
|
void amdgpu_ring_generic_pad_ib(struct amdgpu_ring *ring, struct amdgpu_ib *ib)
|
|
{
|
|
while (ib->length_dw & ring->funcs->align_mask)
|
|
ib->ptr[ib->length_dw++] = ring->funcs->nop;
|
|
}
|
|
|
|
/**
|
|
* amdgpu_ring_commit - tell the GPU to execute the new
|
|
* commands on the ring buffer
|
|
*
|
|
* @ring: amdgpu_ring structure holding ring information
|
|
*
|
|
* Update the wptr (write pointer) to tell the GPU to
|
|
* execute new commands on the ring buffer (all asics).
|
|
*/
|
|
void amdgpu_ring_commit(struct amdgpu_ring *ring)
|
|
{
|
|
uint32_t count;
|
|
|
|
/* We pad to match fetch size */
|
|
count = ring->funcs->align_mask + 1 -
|
|
(ring->wptr & ring->funcs->align_mask);
|
|
count %= ring->funcs->align_mask + 1;
|
|
ring->funcs->insert_nop(ring, count);
|
|
|
|
mb();
|
|
amdgpu_ring_set_wptr(ring);
|
|
|
|
if (ring->funcs->end_use)
|
|
ring->funcs->end_use(ring);
|
|
}
|
|
|
|
/**
|
|
* amdgpu_ring_undo - reset the wptr
|
|
*
|
|
* @ring: amdgpu_ring structure holding ring information
|
|
*
|
|
* Reset the driver's copy of the wptr (all asics).
|
|
*/
|
|
void amdgpu_ring_undo(struct amdgpu_ring *ring)
|
|
{
|
|
ring->wptr = ring->wptr_old;
|
|
|
|
if (ring->funcs->end_use)
|
|
ring->funcs->end_use(ring);
|
|
}
|
|
|
|
#define amdgpu_ring_get_gpu_addr(ring, offset) \
|
|
(ring->is_mes_queue ? \
|
|
(ring->mes_ctx->meta_data_gpu_addr + offset) : \
|
|
(ring->adev->wb.gpu_addr + offset * 4))
|
|
|
|
#define amdgpu_ring_get_cpu_addr(ring, offset) \
|
|
(ring->is_mes_queue ? \
|
|
(void *)((uint8_t *)(ring->mes_ctx->meta_data_ptr) + offset) : \
|
|
(&ring->adev->wb.wb[offset]))
|
|
|
|
/**
|
|
* amdgpu_ring_init - init driver ring struct.
|
|
*
|
|
* @adev: amdgpu_device pointer
|
|
* @ring: amdgpu_ring structure holding ring information
|
|
* @max_dw: maximum number of dw for ring alloc
|
|
* @irq_src: interrupt source to use for this ring
|
|
* @irq_type: interrupt type to use for this ring
|
|
* @hw_prio: ring priority (NORMAL/HIGH)
|
|
* @sched_score: optional score atomic shared with other schedulers
|
|
*
|
|
* Initialize the driver information for the selected ring (all asics).
|
|
* Returns 0 on success, error on failure.
|
|
*/
|
|
int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
|
|
unsigned int max_dw, struct amdgpu_irq_src *irq_src,
|
|
unsigned int irq_type, unsigned int hw_prio,
|
|
atomic_t *sched_score)
|
|
{
|
|
int r;
|
|
int sched_hw_submission = amdgpu_sched_hw_submission;
|
|
u32 *num_sched;
|
|
u32 hw_ip;
|
|
unsigned int max_ibs_dw;
|
|
|
|
/* Set the hw submission limit higher for KIQ because
|
|
* it's used for a number of gfx/compute tasks by both
|
|
* KFD and KGD which may have outstanding fences and
|
|
* it doesn't really use the gpu scheduler anyway;
|
|
* KIQ tasks get submitted directly to the ring.
|
|
*/
|
|
if (ring->funcs->type == AMDGPU_RING_TYPE_KIQ)
|
|
sched_hw_submission = max(sched_hw_submission, 256);
|
|
else if (ring == &adev->sdma.instance[0].page)
|
|
sched_hw_submission = 256;
|
|
|
|
if (ring->adev == NULL) {
|
|
if (adev->num_rings >= AMDGPU_MAX_RINGS)
|
|
return -EINVAL;
|
|
|
|
ring->adev = adev;
|
|
ring->num_hw_submission = sched_hw_submission;
|
|
ring->sched_score = sched_score;
|
|
ring->vmid_wait = dma_fence_get_stub();
|
|
|
|
if (!ring->is_mes_queue) {
|
|
ring->idx = adev->num_rings++;
|
|
adev->rings[ring->idx] = ring;
|
|
}
|
|
|
|
r = amdgpu_fence_driver_init_ring(ring);
|
|
if (r)
|
|
return r;
|
|
}
|
|
|
|
if (ring->is_mes_queue) {
|
|
ring->rptr_offs = amdgpu_mes_ctx_get_offs(ring,
|
|
AMDGPU_MES_CTX_RPTR_OFFS);
|
|
ring->wptr_offs = amdgpu_mes_ctx_get_offs(ring,
|
|
AMDGPU_MES_CTX_WPTR_OFFS);
|
|
ring->fence_offs = amdgpu_mes_ctx_get_offs(ring,
|
|
AMDGPU_MES_CTX_FENCE_OFFS);
|
|
ring->trail_fence_offs = amdgpu_mes_ctx_get_offs(ring,
|
|
AMDGPU_MES_CTX_TRAIL_FENCE_OFFS);
|
|
ring->cond_exe_offs = amdgpu_mes_ctx_get_offs(ring,
|
|
AMDGPU_MES_CTX_COND_EXE_OFFS);
|
|
} else {
|
|
r = amdgpu_device_wb_get(adev, &ring->rptr_offs);
|
|
if (r) {
|
|
dev_err(adev->dev, "(%d) ring rptr_offs wb alloc failed\n", r);
|
|
return r;
|
|
}
|
|
|
|
r = amdgpu_device_wb_get(adev, &ring->wptr_offs);
|
|
if (r) {
|
|
dev_err(adev->dev, "(%d) ring wptr_offs wb alloc failed\n", r);
|
|
return r;
|
|
}
|
|
|
|
r = amdgpu_device_wb_get(adev, &ring->fence_offs);
|
|
if (r) {
|
|
dev_err(adev->dev, "(%d) ring fence_offs wb alloc failed\n", r);
|
|
return r;
|
|
}
|
|
|
|
r = amdgpu_device_wb_get(adev, &ring->trail_fence_offs);
|
|
if (r) {
|
|
dev_err(adev->dev, "(%d) ring trail_fence_offs wb alloc failed\n", r);
|
|
return r;
|
|
}
|
|
|
|
r = amdgpu_device_wb_get(adev, &ring->cond_exe_offs);
|
|
if (r) {
|
|
dev_err(adev->dev, "(%d) ring cond_exec_polling wb alloc failed\n", r);
|
|
return r;
|
|
}
|
|
}
|
|
|
|
ring->fence_gpu_addr =
|
|
amdgpu_ring_get_gpu_addr(ring, ring->fence_offs);
|
|
ring->fence_cpu_addr =
|
|
amdgpu_ring_get_cpu_addr(ring, ring->fence_offs);
|
|
|
|
ring->rptr_gpu_addr =
|
|
amdgpu_ring_get_gpu_addr(ring, ring->rptr_offs);
|
|
ring->rptr_cpu_addr =
|
|
amdgpu_ring_get_cpu_addr(ring, ring->rptr_offs);
|
|
|
|
ring->wptr_gpu_addr =
|
|
amdgpu_ring_get_gpu_addr(ring, ring->wptr_offs);
|
|
ring->wptr_cpu_addr =
|
|
amdgpu_ring_get_cpu_addr(ring, ring->wptr_offs);
|
|
|
|
ring->trail_fence_gpu_addr =
|
|
amdgpu_ring_get_gpu_addr(ring, ring->trail_fence_offs);
|
|
ring->trail_fence_cpu_addr =
|
|
amdgpu_ring_get_cpu_addr(ring, ring->trail_fence_offs);
|
|
|
|
ring->cond_exe_gpu_addr =
|
|
amdgpu_ring_get_gpu_addr(ring, ring->cond_exe_offs);
|
|
ring->cond_exe_cpu_addr =
|
|
amdgpu_ring_get_cpu_addr(ring, ring->cond_exe_offs);
|
|
|
|
/* always set cond_exec_polling to CONTINUE */
|
|
*ring->cond_exe_cpu_addr = 1;
|
|
|
|
r = amdgpu_fence_driver_start_ring(ring, irq_src, irq_type);
|
|
if (r) {
|
|
dev_err(adev->dev, "failed initializing fences (%d).\n", r);
|
|
return r;
|
|
}
|
|
|
|
max_ibs_dw = ring->funcs->emit_frame_size +
|
|
amdgpu_ring_max_ibs(ring->funcs->type) * ring->funcs->emit_ib_size;
|
|
max_ibs_dw = (max_ibs_dw + ring->funcs->align_mask) & ~ring->funcs->align_mask;
|
|
|
|
if (WARN_ON(max_ibs_dw > max_dw))
|
|
max_dw = max_ibs_dw;
|
|
|
|
ring->ring_size = roundup_pow_of_two(max_dw * 4 * sched_hw_submission);
|
|
|
|
ring->buf_mask = (ring->ring_size / 4) - 1;
|
|
ring->ptr_mask = ring->funcs->support_64bit_ptrs ?
|
|
0xffffffffffffffff : ring->buf_mask;
|
|
|
|
/* Allocate ring buffer */
|
|
if (ring->is_mes_queue) {
|
|
int offset = 0;
|
|
|
|
BUG_ON(ring->ring_size > PAGE_SIZE*4);
|
|
|
|
offset = amdgpu_mes_ctx_get_offs(ring,
|
|
AMDGPU_MES_CTX_RING_OFFS);
|
|
ring->gpu_addr = amdgpu_mes_ctx_get_offs_gpu_addr(ring, offset);
|
|
ring->ring = amdgpu_mes_ctx_get_offs_cpu_addr(ring, offset);
|
|
amdgpu_ring_clear_ring(ring);
|
|
|
|
} else if (ring->ring_obj == NULL) {
|
|
r = amdgpu_bo_create_kernel(adev, ring->ring_size + ring->funcs->extra_dw, PAGE_SIZE,
|
|
AMDGPU_GEM_DOMAIN_GTT,
|
|
&ring->ring_obj,
|
|
&ring->gpu_addr,
|
|
(void **)&ring->ring);
|
|
if (r) {
|
|
dev_err(adev->dev, "(%d) ring create failed\n", r);
|
|
return r;
|
|
}
|
|
amdgpu_ring_clear_ring(ring);
|
|
}
|
|
|
|
ring->max_dw = max_dw;
|
|
ring->hw_prio = hw_prio;
|
|
|
|
if (!ring->no_scheduler) {
|
|
hw_ip = ring->funcs->type;
|
|
num_sched = &adev->gpu_sched[hw_ip][hw_prio].num_scheds;
|
|
adev->gpu_sched[hw_ip][hw_prio].sched[(*num_sched)++] =
|
|
&ring->sched;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* amdgpu_ring_fini - tear down the driver ring struct.
|
|
*
|
|
* @ring: amdgpu_ring structure holding ring information
|
|
*
|
|
* Tear down the driver information for the selected ring (all asics).
|
|
*/
|
|
void amdgpu_ring_fini(struct amdgpu_ring *ring)
|
|
{
|
|
|
|
/* Not to finish a ring which is not initialized */
|
|
if (!(ring->adev) ||
|
|
(!ring->is_mes_queue && !(ring->adev->rings[ring->idx])))
|
|
return;
|
|
|
|
ring->sched.ready = false;
|
|
|
|
if (!ring->is_mes_queue) {
|
|
amdgpu_device_wb_free(ring->adev, ring->rptr_offs);
|
|
amdgpu_device_wb_free(ring->adev, ring->wptr_offs);
|
|
|
|
amdgpu_device_wb_free(ring->adev, ring->cond_exe_offs);
|
|
amdgpu_device_wb_free(ring->adev, ring->fence_offs);
|
|
|
|
amdgpu_bo_free_kernel(&ring->ring_obj,
|
|
&ring->gpu_addr,
|
|
(void **)&ring->ring);
|
|
} else {
|
|
kfree(ring->fence_drv.fences);
|
|
}
|
|
|
|
dma_fence_put(ring->vmid_wait);
|
|
ring->vmid_wait = NULL;
|
|
ring->me = 0;
|
|
|
|
if (!ring->is_mes_queue)
|
|
ring->adev->rings[ring->idx] = NULL;
|
|
}
|
|
|
|
/**
|
|
* amdgpu_ring_emit_reg_write_reg_wait_helper - ring helper
|
|
*
|
|
* @ring: ring to write to
|
|
* @reg0: register to write
|
|
* @reg1: register to wait on
|
|
* @ref: reference value to write/wait on
|
|
* @mask: mask to wait on
|
|
*
|
|
* Helper for rings that don't support write and wait in a
|
|
* single oneshot packet.
|
|
*/
|
|
void amdgpu_ring_emit_reg_write_reg_wait_helper(struct amdgpu_ring *ring,
|
|
uint32_t reg0, uint32_t reg1,
|
|
uint32_t ref, uint32_t mask)
|
|
{
|
|
amdgpu_ring_emit_wreg(ring, reg0, ref);
|
|
amdgpu_ring_emit_reg_wait(ring, reg1, mask, mask);
|
|
}
|
|
|
|
/**
|
|
* amdgpu_ring_soft_recovery - try to soft recover a ring lockup
|
|
*
|
|
* @ring: ring to try the recovery on
|
|
* @vmid: VMID we try to get going again
|
|
* @fence: timedout fence
|
|
*
|
|
* Tries to get a ring proceeding again when it is stuck.
|
|
*/
|
|
bool amdgpu_ring_soft_recovery(struct amdgpu_ring *ring, unsigned int vmid,
|
|
struct dma_fence *fence)
|
|
{
|
|
unsigned long flags;
|
|
ktime_t deadline;
|
|
|
|
if (unlikely(ring->adev->debug_disable_soft_recovery))
|
|
return false;
|
|
|
|
deadline = ktime_add_us(ktime_get(), 10000);
|
|
|
|
if (amdgpu_sriov_vf(ring->adev) || !ring->funcs->soft_recovery || !fence)
|
|
return false;
|
|
|
|
spin_lock_irqsave(fence->lock, flags);
|
|
if (!dma_fence_is_signaled_locked(fence))
|
|
dma_fence_set_error(fence, -ENODATA);
|
|
spin_unlock_irqrestore(fence->lock, flags);
|
|
|
|
atomic_inc(&ring->adev->gpu_reset_counter);
|
|
while (!dma_fence_is_signaled(fence) &&
|
|
ktime_to_ns(ktime_sub(deadline, ktime_get())) > 0)
|
|
ring->funcs->soft_recovery(ring, vmid);
|
|
|
|
return dma_fence_is_signaled(fence);
|
|
}
|
|
|
|
/*
|
|
* Debugfs info
|
|
*/
|
|
#if defined(CONFIG_DEBUG_FS)
|
|
|
|
/* Layout of file is 12 bytes consisting of
|
|
* - rptr
|
|
* - wptr
|
|
* - driver's copy of wptr
|
|
*
|
|
* followed by n-words of ring data
|
|
*/
|
|
static ssize_t amdgpu_debugfs_ring_read(struct file *f, char __user *buf,
|
|
size_t size, loff_t *pos)
|
|
{
|
|
struct amdgpu_ring *ring = file_inode(f)->i_private;
|
|
int r, i;
|
|
uint32_t value, result, early[3];
|
|
|
|
if (*pos & 3 || size & 3)
|
|
return -EINVAL;
|
|
|
|
result = 0;
|
|
|
|
if (*pos < 12) {
|
|
early[0] = amdgpu_ring_get_rptr(ring) & ring->buf_mask;
|
|
early[1] = amdgpu_ring_get_wptr(ring) & ring->buf_mask;
|
|
early[2] = ring->wptr & ring->buf_mask;
|
|
for (i = *pos / 4; i < 3 && size; i++) {
|
|
r = put_user(early[i], (uint32_t *)buf);
|
|
if (r)
|
|
return r;
|
|
buf += 4;
|
|
result += 4;
|
|
size -= 4;
|
|
*pos += 4;
|
|
}
|
|
}
|
|
|
|
while (size) {
|
|
if (*pos >= (ring->ring_size + 12))
|
|
return result;
|
|
|
|
value = ring->ring[(*pos - 12)/4];
|
|
r = put_user(value, (uint32_t *)buf);
|
|
if (r)
|
|
return r;
|
|
buf += 4;
|
|
result += 4;
|
|
size -= 4;
|
|
*pos += 4;
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
static const struct file_operations amdgpu_debugfs_ring_fops = {
|
|
.owner = THIS_MODULE,
|
|
.read = amdgpu_debugfs_ring_read,
|
|
.llseek = default_llseek
|
|
};
|
|
|
|
static ssize_t amdgpu_debugfs_mqd_read(struct file *f, char __user *buf,
|
|
size_t size, loff_t *pos)
|
|
{
|
|
struct amdgpu_ring *ring = file_inode(f)->i_private;
|
|
volatile u32 *mqd;
|
|
u32 *kbuf;
|
|
int r, i;
|
|
uint32_t value, result;
|
|
|
|
if (*pos & 3 || size & 3)
|
|
return -EINVAL;
|
|
|
|
kbuf = kmalloc(ring->mqd_size, GFP_KERNEL);
|
|
if (!kbuf)
|
|
return -ENOMEM;
|
|
|
|
r = amdgpu_bo_reserve(ring->mqd_obj, false);
|
|
if (unlikely(r != 0))
|
|
goto err_free;
|
|
|
|
r = amdgpu_bo_kmap(ring->mqd_obj, (void **)&mqd);
|
|
if (r)
|
|
goto err_unreserve;
|
|
|
|
/*
|
|
* Copy to local buffer to avoid put_user(), which might fault
|
|
* and acquire mmap_sem, under reservation_ww_class_mutex.
|
|
*/
|
|
for (i = 0; i < ring->mqd_size/sizeof(u32); i++)
|
|
kbuf[i] = mqd[i];
|
|
|
|
amdgpu_bo_kunmap(ring->mqd_obj);
|
|
amdgpu_bo_unreserve(ring->mqd_obj);
|
|
|
|
result = 0;
|
|
while (size) {
|
|
if (*pos >= ring->mqd_size)
|
|
break;
|
|
|
|
value = kbuf[*pos/4];
|
|
r = put_user(value, (uint32_t *)buf);
|
|
if (r)
|
|
goto err_free;
|
|
buf += 4;
|
|
result += 4;
|
|
size -= 4;
|
|
*pos += 4;
|
|
}
|
|
|
|
kfree(kbuf);
|
|
return result;
|
|
|
|
err_unreserve:
|
|
amdgpu_bo_unreserve(ring->mqd_obj);
|
|
err_free:
|
|
kfree(kbuf);
|
|
return r;
|
|
}
|
|
|
|
static const struct file_operations amdgpu_debugfs_mqd_fops = {
|
|
.owner = THIS_MODULE,
|
|
.read = amdgpu_debugfs_mqd_read,
|
|
.llseek = default_llseek
|
|
};
|
|
|
|
static int amdgpu_debugfs_ring_error(void *data, u64 val)
|
|
{
|
|
struct amdgpu_ring *ring = data;
|
|
|
|
amdgpu_fence_driver_set_error(ring, val);
|
|
return 0;
|
|
}
|
|
|
|
DEFINE_DEBUGFS_ATTRIBUTE_SIGNED(amdgpu_debugfs_error_fops, NULL,
|
|
amdgpu_debugfs_ring_error, "%lld\n");
|
|
|
|
#endif
|
|
|
|
void amdgpu_debugfs_ring_init(struct amdgpu_device *adev,
|
|
struct amdgpu_ring *ring)
|
|
{
|
|
#if defined(CONFIG_DEBUG_FS)
|
|
struct drm_minor *minor = adev_to_drm(adev)->primary;
|
|
struct dentry *root = minor->debugfs_root;
|
|
char name[32];
|
|
|
|
sprintf(name, "amdgpu_ring_%s", ring->name);
|
|
debugfs_create_file_size(name, S_IFREG | 0444, root, ring,
|
|
&amdgpu_debugfs_ring_fops,
|
|
ring->ring_size + 12);
|
|
|
|
if (ring->mqd_obj) {
|
|
sprintf(name, "amdgpu_mqd_%s", ring->name);
|
|
debugfs_create_file_size(name, S_IFREG | 0444, root, ring,
|
|
&amdgpu_debugfs_mqd_fops,
|
|
ring->mqd_size);
|
|
}
|
|
|
|
sprintf(name, "amdgpu_error_%s", ring->name);
|
|
debugfs_create_file(name, 0200, root, ring,
|
|
&amdgpu_debugfs_error_fops);
|
|
|
|
#endif
|
|
}
|
|
|
|
/**
|
|
* amdgpu_ring_test_helper - tests ring and set sched readiness status
|
|
*
|
|
* @ring: ring to try the recovery on
|
|
*
|
|
* Tests ring and set sched readiness status
|
|
*
|
|
* Returns 0 on success, error on failure.
|
|
*/
|
|
int amdgpu_ring_test_helper(struct amdgpu_ring *ring)
|
|
{
|
|
struct amdgpu_device *adev = ring->adev;
|
|
int r;
|
|
|
|
r = amdgpu_ring_test_ring(ring);
|
|
if (r)
|
|
DRM_DEV_ERROR(adev->dev, "ring %s test failed (%d)\n",
|
|
ring->name, r);
|
|
else
|
|
DRM_DEV_DEBUG(adev->dev, "ring test on %s succeeded\n",
|
|
ring->name);
|
|
|
|
ring->sched.ready = !r;
|
|
|
|
return r;
|
|
}
|
|
|
|
static void amdgpu_ring_to_mqd_prop(struct amdgpu_ring *ring,
|
|
struct amdgpu_mqd_prop *prop)
|
|
{
|
|
struct amdgpu_device *adev = ring->adev;
|
|
bool is_high_prio_compute = ring->funcs->type == AMDGPU_RING_TYPE_COMPUTE &&
|
|
amdgpu_gfx_is_high_priority_compute_queue(adev, ring);
|
|
bool is_high_prio_gfx = ring->funcs->type == AMDGPU_RING_TYPE_GFX &&
|
|
amdgpu_gfx_is_high_priority_graphics_queue(adev, ring);
|
|
|
|
memset(prop, 0, sizeof(*prop));
|
|
|
|
prop->mqd_gpu_addr = ring->mqd_gpu_addr;
|
|
prop->hqd_base_gpu_addr = ring->gpu_addr;
|
|
prop->rptr_gpu_addr = ring->rptr_gpu_addr;
|
|
prop->wptr_gpu_addr = ring->wptr_gpu_addr;
|
|
prop->queue_size = ring->ring_size;
|
|
prop->eop_gpu_addr = ring->eop_gpu_addr;
|
|
prop->use_doorbell = ring->use_doorbell;
|
|
prop->doorbell_index = ring->doorbell_index;
|
|
|
|
/* map_queues packet doesn't need activate the queue,
|
|
* so only kiq need set this field.
|
|
*/
|
|
prop->hqd_active = ring->funcs->type == AMDGPU_RING_TYPE_KIQ;
|
|
|
|
prop->allow_tunneling = is_high_prio_compute;
|
|
if (is_high_prio_compute || is_high_prio_gfx) {
|
|
prop->hqd_pipe_priority = AMDGPU_GFX_PIPE_PRIO_HIGH;
|
|
prop->hqd_queue_priority = AMDGPU_GFX_QUEUE_PRIORITY_MAXIMUM;
|
|
}
|
|
}
|
|
|
|
int amdgpu_ring_init_mqd(struct amdgpu_ring *ring)
|
|
{
|
|
struct amdgpu_device *adev = ring->adev;
|
|
struct amdgpu_mqd *mqd_mgr;
|
|
struct amdgpu_mqd_prop prop;
|
|
|
|
amdgpu_ring_to_mqd_prop(ring, &prop);
|
|
|
|
ring->wptr = 0;
|
|
|
|
if (ring->funcs->type == AMDGPU_RING_TYPE_KIQ)
|
|
mqd_mgr = &adev->mqds[AMDGPU_HW_IP_COMPUTE];
|
|
else
|
|
mqd_mgr = &adev->mqds[ring->funcs->type];
|
|
|
|
return mqd_mgr->init_mqd(adev, ring->mqd_ptr, &prop);
|
|
}
|
|
|
|
void amdgpu_ring_ib_begin(struct amdgpu_ring *ring)
|
|
{
|
|
if (ring->is_sw_ring)
|
|
amdgpu_sw_ring_ib_begin(ring);
|
|
}
|
|
|
|
void amdgpu_ring_ib_end(struct amdgpu_ring *ring)
|
|
{
|
|
if (ring->is_sw_ring)
|
|
amdgpu_sw_ring_ib_end(ring);
|
|
}
|
|
|
|
void amdgpu_ring_ib_on_emit_cntl(struct amdgpu_ring *ring)
|
|
{
|
|
if (ring->is_sw_ring)
|
|
amdgpu_sw_ring_ib_mark_offset(ring, AMDGPU_MUX_OFFSET_TYPE_CONTROL);
|
|
}
|
|
|
|
void amdgpu_ring_ib_on_emit_ce(struct amdgpu_ring *ring)
|
|
{
|
|
if (ring->is_sw_ring)
|
|
amdgpu_sw_ring_ib_mark_offset(ring, AMDGPU_MUX_OFFSET_TYPE_CE);
|
|
}
|
|
|
|
void amdgpu_ring_ib_on_emit_de(struct amdgpu_ring *ring)
|
|
{
|
|
if (ring->is_sw_ring)
|
|
amdgpu_sw_ring_ib_mark_offset(ring, AMDGPU_MUX_OFFSET_TYPE_DE);
|
|
}
|
|
|
|
bool amdgpu_ring_sched_ready(struct amdgpu_ring *ring)
|
|
{
|
|
if (!ring)
|
|
return false;
|
|
|
|
if (ring->no_scheduler || !drm_sched_wqueue_ready(&ring->sched))
|
|
return false;
|
|
|
|
return true;
|
|
}
|