301daa346f
Commit77acc6b55a("riscv: add support for kernel-mode FPU") and commita28e4b672f("drm/amd/display: use ARCH_HAS_KERNEL_FPU_SUPPORT") enabled support for CONFIG_DRM_AMD_DC_FP with RISC-V. Unfortunately, this exposed -Wframe-larger-than warnings (which become fatal with CONFIG_WERROR=y) when building ARCH=riscv allmodconfig with clang: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:58:13: error: stack frame size (2448) exceeds limit (2048) in 'DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerformanceCalculation' [-Werror,-Wframe-larger-than] 58 | static void DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerformanceCalculation( | ^ 1 error generated. Many functions in this file use a large number of parameters, which must be passed on the stack at a certain pointer due to register exhaustion, which can cause high stack usage when inlining and issues with stack slot analysis get involved. While the compiler can and should do better (as GCC uses less than half the amount of stack space for the same function), it is not as simple as a fix as adjusting the functions not to take a large number of parameters. Unfortunately, modifying these files to avoid the problem is a difficult to justify approach because any revisions to the files in the kernel tree never make it back to the original source (so copies of the code for newer hardware revisions just reintroduce the issue) and the files are hard to read/modify due to being "gcc-parsable HW gospel, coming straight from HW engineers". Avoid building the problematic code for RISC-V by modifying the existing condition for arm64 that exists for the same reason. Factor out the logical not to make the condition a little more readable naturally. Fixes:a28e4b672f("drm/amd/display: use ARCH_HAS_KERNEL_FPU_SUPPORT") Reported-by: Palmer Dabbelt <palmer@rivosinc.com> Closes: https://lore.kernel.org/20240530145741.7506-2-palmer@rivosinc.com/ Reviewed-by: Harry Wentland <harry.wentland@amd.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
54 lines
1.8 KiB
Text
54 lines
1.8 KiB
Text
# SPDX-License-Identifier: MIT
|
|
menu "Display Engine Configuration"
|
|
depends on DRM && DRM_AMDGPU
|
|
|
|
config DRM_AMD_DC
|
|
bool "AMD DC - Enable new display engine"
|
|
default y
|
|
depends on BROKEN || !CC_IS_CLANG || ARM64 || RISCV || SPARC64 || X86_64
|
|
select SND_HDA_COMPONENT if SND_HDA_CORE
|
|
# !CC_IS_CLANG: https://github.com/ClangBuiltLinux/linux/issues/1752
|
|
select DRM_AMD_DC_FP if ARCH_HAS_KERNEL_FPU_SUPPORT && !(CC_IS_CLANG && (ARM64 || RISCV))
|
|
help
|
|
Choose this option if you want to use the new display engine
|
|
support for AMDGPU. This adds required support for Vega and
|
|
Raven ASICs.
|
|
|
|
calculate_bandwidth() is presently broken on all !(X86_64 || SPARC64 || ARM64)
|
|
architectures built with Clang (all released versions), whereby the stack
|
|
frame gets blown up to well over 5k. This would cause an immediate kernel
|
|
panic on most architectures. We'll revert this when the following bug report
|
|
has been resolved: https://github.com/llvm/llvm-project/issues/41896.
|
|
|
|
config DRM_AMD_DC_FP
|
|
def_bool n
|
|
help
|
|
Floating point support, required for DCN-based SoCs
|
|
|
|
config DRM_AMD_DC_SI
|
|
bool "AMD DC support for Southern Islands ASICs"
|
|
depends on DRM_AMDGPU_SI
|
|
depends on DRM_AMD_DC
|
|
help
|
|
Choose this option to enable new AMD DC support for SI asics
|
|
by default. This includes Tahiti, Pitcairn, Cape Verde, Oland.
|
|
Hainan is not supported by AMD DC and it has no physical DCE6.
|
|
|
|
config DEBUG_KERNEL_DC
|
|
bool "Enable kgdb break in DC"
|
|
depends on DRM_AMD_DC
|
|
depends on KGDB
|
|
help
|
|
Choose this option if you want to hit kdgb_break in assert.
|
|
|
|
config DRM_AMD_SECURE_DISPLAY
|
|
bool "Enable secure display support"
|
|
depends on DEBUG_FS
|
|
depends on DRM_AMD_DC_FP
|
|
help
|
|
Choose this option if you want to support secure display
|
|
|
|
This option enables the calculation of crc of specific region via
|
|
debugfs. Cooperate with specific DMCU FW.
|
|
|
|
endmenu
|