2c92ca849f
With the rework of how the __string() handles dynamic strings where it
saves off the source string in field in the helper structure[1], the
assignment of that value to the trace event field is stored in the helper
value and does not need to be passed in again.
This means that with:
__string(field, mystring)
Which use to be assigned with __assign_str(field, mystring), no longer
needs the second parameter and it is unused. With this, __assign_str()
will now only get a single parameter.
There's over 700 users of __assign_str() and because coccinelle does not
handle the TRACE_EVENT() macro I ended up using the following sed script:
git grep -l __assign_str | while read a ; do
sed -e 's/\(__assign_str([^,]*[^ ,]\) *,[^;]*/\1)/' $a > /tmp/test-file;
mv /tmp/test-file $a;
done
I then searched for __assign_str() that did not end with ';' as those
were multi line assignments that the sed script above would fail to catch.
Note, the same updates will need to be done for:
__assign_str_len()
__assign_rel_str()
__assign_rel_str_len()
I tested this with both an allmodconfig and an allyesconfig (build only for both).
[1] https://lore.kernel.org/linux-trace-kernel/20240222211442.634192653@goodmis.org/
Link: https://lore.kernel.org/linux-trace-kernel/20240516133454.681ba6a0@rorschach.local.home
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Christian König <christian.koenig@amd.com> for the amdgpu parts.
Acked-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> #for
Acked-by: Rafael J. Wysocki <rafael@kernel.org> # for thermal
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Darrick J. Wong <djwong@kernel.org> # xfs
Tested-by: Guenter Roeck <linux@roeck-us.net>
115 lines
3 KiB
C
115 lines
3 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0-or-later */
|
|
/*
|
|
* Copyright 2013-2015 Freescale Semiconductor Inc.
|
|
*/
|
|
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM dpaa_eth
|
|
|
|
#if !defined(_DPAA_ETH_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _DPAA_ETH_TRACE_H
|
|
|
|
#include <linux/skbuff.h>
|
|
#include <linux/netdevice.h>
|
|
#include "dpaa_eth.h"
|
|
#include <linux/tracepoint.h>
|
|
|
|
#define fd_format_name(format) { qm_fd_##format, #format }
|
|
#define fd_format_list \
|
|
fd_format_name(contig), \
|
|
fd_format_name(sg)
|
|
|
|
/* This is used to declare a class of events.
|
|
* individual events of this type will be defined below.
|
|
*/
|
|
|
|
/* Store details about a frame descriptor and the FQ on which it was
|
|
* transmitted/received.
|
|
*/
|
|
DECLARE_EVENT_CLASS(dpaa_eth_fd,
|
|
/* Trace function prototype */
|
|
TP_PROTO(struct net_device *netdev,
|
|
struct qman_fq *fq,
|
|
const struct qm_fd *fd),
|
|
|
|
/* Repeat argument list here */
|
|
TP_ARGS(netdev, fq, fd),
|
|
|
|
/* A structure containing the relevant information we want to record.
|
|
* Declare name and type for each normal element, name, type and size
|
|
* for arrays. Use __string for variable length strings.
|
|
*/
|
|
TP_STRUCT__entry(
|
|
__field(u32, fqid)
|
|
__field(u64, fd_addr)
|
|
__field(u8, fd_format)
|
|
__field(u16, fd_offset)
|
|
__field(u32, fd_length)
|
|
__field(u32, fd_status)
|
|
__string(name, netdev->name)
|
|
),
|
|
|
|
/* The function that assigns values to the above declared fields */
|
|
TP_fast_assign(
|
|
__entry->fqid = fq->fqid;
|
|
__entry->fd_addr = qm_fd_addr_get64(fd);
|
|
__entry->fd_format = qm_fd_get_format(fd);
|
|
__entry->fd_offset = qm_fd_get_offset(fd);
|
|
__entry->fd_length = qm_fd_get_length(fd);
|
|
__entry->fd_status = fd->status;
|
|
__assign_str(name);
|
|
),
|
|
|
|
/* This is what gets printed when the trace event is triggered */
|
|
TP_printk("[%s] fqid=%d, fd: addr=0x%llx, format=%s, off=%u, len=%u, status=0x%08x",
|
|
__get_str(name), __entry->fqid, __entry->fd_addr,
|
|
__print_symbolic(__entry->fd_format, fd_format_list),
|
|
__entry->fd_offset, __entry->fd_length, __entry->fd_status)
|
|
);
|
|
|
|
/* Now declare events of the above type. Format is:
|
|
* DEFINE_EVENT(class, name, proto, args), with proto and args same as for class
|
|
*/
|
|
|
|
/* Tx (egress) fd */
|
|
DEFINE_EVENT(dpaa_eth_fd, dpaa_tx_fd,
|
|
|
|
TP_PROTO(struct net_device *netdev,
|
|
struct qman_fq *fq,
|
|
const struct qm_fd *fd),
|
|
|
|
TP_ARGS(netdev, fq, fd)
|
|
);
|
|
|
|
/* Rx fd */
|
|
DEFINE_EVENT(dpaa_eth_fd, dpaa_rx_fd,
|
|
|
|
TP_PROTO(struct net_device *netdev,
|
|
struct qman_fq *fq,
|
|
const struct qm_fd *fd),
|
|
|
|
TP_ARGS(netdev, fq, fd)
|
|
);
|
|
|
|
/* Tx confirmation fd */
|
|
DEFINE_EVENT(dpaa_eth_fd, dpaa_tx_conf_fd,
|
|
|
|
TP_PROTO(struct net_device *netdev,
|
|
struct qman_fq *fq,
|
|
const struct qm_fd *fd),
|
|
|
|
TP_ARGS(netdev, fq, fd)
|
|
);
|
|
|
|
/* If only one event of a certain type needs to be declared, use TRACE_EVENT().
|
|
* The syntax is the same as for DECLARE_EVENT_CLASS().
|
|
*/
|
|
|
|
#endif /* _DPAA_ETH_TRACE_H */
|
|
|
|
/* This must be outside ifdef _DPAA_ETH_TRACE_H */
|
|
#undef TRACE_INCLUDE_PATH
|
|
#define TRACE_INCLUDE_PATH .
|
|
#undef TRACE_INCLUDE_FILE
|
|
#define TRACE_INCLUDE_FILE dpaa_eth_trace
|
|
#include <trace/define_trace.h>
|