e346e231b4
Here we've got to a situation when tasklet called usleep_range() in PTT
acquire logic, thus welcome to the "scheduling while atomic" BUG().
BUG: scheduling while atomic: swapper/24/0/0x00000100
[<ffffffffb41c6199>] schedule+0x29/0x70
[<ffffffffb41c5512>] schedule_hrtimeout_range_clock+0xb2/0x150
[<ffffffffb41c55c3>] schedule_hrtimeout_range+0x13/0x20
[<ffffffffb41c3bcf>] usleep_range+0x4f/0x70
[<ffffffffc08d3e58>] qed_ptt_acquire+0x38/0x100 [qed]
[<ffffffffc08eac48>] _qed_get_vport_stats+0x458/0x580 [qed]
[<ffffffffc08ead8c>] qed_get_vport_stats+0x1c/0xd0 [qed]
[<ffffffffc08dffd3>] qed_get_protocol_stats+0x93/0x100 [qed]
qed_mcp_send_protocol_stats
case MFW_DRV_MSG_GET_LAN_STATS:
case MFW_DRV_MSG_GET_FCOE_STATS:
case MFW_DRV_MSG_GET_ISCSI_STATS:
case MFW_DRV_MSG_GET_RDMA_STATS:
[<ffffffffc08e36d8>] qed_mcp_handle_events+0x2d8/0x890 [qed]
qed_int_assertion
qed_int_attentions
[<ffffffffc08d9490>] qed_int_sp_dpc+0xa50/0xdc0 [qed]
[<ffffffffb3aa7623>] tasklet_action+0x83/0x140
[<ffffffffb41d9125>] __do_softirq+0x125/0x2bb
[<ffffffffb41d560c>] call_softirq+0x1c/0x30
[<ffffffffb3a30645>] do_softirq+0x65/0xa0
[<ffffffffb3aa78d5>] irq_exit+0x105/0x110
[<ffffffffb41d8996>] do_IRQ+0x56/0xf0
Fix this by making caller to provide the context whether it could be in
atomic context flow or not when getting stats from QED driver.
QED driver based on the context provided decide to schedule out or not
when acquiring the PTT BAR window.
We faced the BUG_ON() while getting vport stats, but according to the
code same issue could happen for fcoe and iscsi statistics as well, so
fixing them too.
Fixes: 6c75424612 ("qed: Add support for NCSI statistics.")
Fixes: 1e128c8129 ("qed: Add support for hardware offloaded FCoE.")
Fixes: 2f2b2614e8 ("qed: Provide iSCSI statistics to management")
Cc: Sudarsana Kalluru <skalluru@marvell.com>
Cc: David Miller <davem@davemloft.net>
Cc: Manish Chopra <manishc@marvell.com>
Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
61 lines
1.6 KiB
C
61 lines
1.6 KiB
C
/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
|
|
/* QLogic qed NIC Driver
|
|
* Copyright (c) 2015-2017 QLogic Corporation
|
|
* Copyright (c) 2019-2020 Marvell International Ltd.
|
|
*/
|
|
|
|
#ifndef _QED_FCOE_H
|
|
#define _QED_FCOE_H
|
|
#include <linux/types.h>
|
|
#include <linux/list.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/qed/qed_fcoe_if.h>
|
|
#include <linux/qed/qed_chain.h>
|
|
#include "qed.h"
|
|
#include "qed_hsi.h"
|
|
#include "qed_mcp.h"
|
|
#include "qed_sp.h"
|
|
|
|
struct qed_fcoe_info {
|
|
spinlock_t lock; /* Connection resources. */
|
|
struct list_head free_list;
|
|
};
|
|
|
|
#if IS_ENABLED(CONFIG_QED_FCOE)
|
|
int qed_fcoe_alloc(struct qed_hwfn *p_hwfn);
|
|
|
|
void qed_fcoe_setup(struct qed_hwfn *p_hwfn);
|
|
|
|
void qed_fcoe_free(struct qed_hwfn *p_hwfn);
|
|
/**
|
|
* qed_get_protocol_stats_fcoe(): Fills provided statistics
|
|
* struct with statistics.
|
|
*
|
|
* @cdev: Qed dev pointer.
|
|
* @stats: Points to struct that will be filled with statistics.
|
|
* @is_atomic: Hint from the caller - if the func can sleep or not.
|
|
*
|
|
* Context: The function should not sleep in case is_atomic == true.
|
|
* Return: Void.
|
|
*/
|
|
void qed_get_protocol_stats_fcoe(struct qed_dev *cdev,
|
|
struct qed_mcp_fcoe_stats *stats,
|
|
bool is_atomic);
|
|
#else /* CONFIG_QED_FCOE */
|
|
static inline int qed_fcoe_alloc(struct qed_hwfn *p_hwfn)
|
|
{
|
|
return -EINVAL;
|
|
}
|
|
|
|
static inline void qed_fcoe_setup(struct qed_hwfn *p_hwfn) {}
|
|
static inline void qed_fcoe_free(struct qed_hwfn *p_hwfn) {}
|
|
|
|
static inline void qed_get_protocol_stats_fcoe(struct qed_dev *cdev,
|
|
struct qed_mcp_fcoe_stats *stats,
|
|
bool is_atomic)
|
|
{
|
|
}
|
|
#endif /* CONFIG_QED_FCOE */
|
|
|
|
#endif /* _QED_FCOE_H */
|