int3472 now fails to link when the LED support is disabled:
x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_register_pled':
led.c:(.text+0xf4): undefined reference to `led_classdev_register_ext'
x86_64-linux-ld: led.c:(.text+0x131): undefined reference to `led_add_lookup'
x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_unregister_pled':
led.c:(.text+0x16b): undefined reference to `led_remove_lookup'
x86_64-linux-ld: led.c:(.text+0x177): undefined reference to `led_classdev_unregister'
Add an explicit Kconfig dependency.
Fixes: 5ae20a8050
("platform/x86: int3472/discrete: Create a LED class device for the privacy LED")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://lore.kernel.org/r/20230208163658.2129009-1-arnd@kernel.org
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
31 lines
1.2 KiB
Text
31 lines
1.2 KiB
Text
config INTEL_SKL_INT3472
|
|
tristate "Intel SkyLake ACPI INT3472 Driver"
|
|
depends on ACPI
|
|
depends on COMMON_CLK
|
|
depends on I2C
|
|
depends on GPIOLIB
|
|
depends on LEDS_CLASS
|
|
depends on REGULATOR
|
|
select MFD_CORE
|
|
select REGMAP_I2C
|
|
help
|
|
This driver adds power controller support for the Intel SkyCam
|
|
devices found on the Intel SkyLake platforms.
|
|
|
|
The INT3472 is a camera power controller, a logical device found on
|
|
Intel Skylake-based systems that can map to different hardware
|
|
devices depending on the platform. On machines designed for Chrome OS
|
|
it maps to a TPS68470 camera PMIC. On machines designed for Windows,
|
|
it maps to either a TP68470 camera PMIC, a uP6641Q sensor PMIC, or a
|
|
set of discrete GPIOs and power gates.
|
|
|
|
If your device was designed for Chrome OS, this driver will provide
|
|
an ACPI OpRegion, which must be available before any of the devices
|
|
using it are probed. For this reason, you should select Y if your
|
|
device was designed for ChromeOS. For the same reason the
|
|
I2C_DESIGNWARE_PLATFORM option must be set to Y too.
|
|
|
|
Say Y or M here if you have a SkyLake device designed for use
|
|
with Windows or ChromeOS. Say N here if you are not sure.
|
|
|
|
The module will be named "intel-skl-int3472".
|