1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/ethernet/intel/i40e
Ivan Vecera e620d24506 i40e: Delete unused and useless i40e_pf fields
Removed fields:
.fc_autoneg_status
    Since commit c56999f948 ("i40e/i40evf: Add set_fc and init of
    FC settings") write-only and otherwise unused
.eeprom_version
    Write-only and otherwise unused
.atr_sample_rate
    Has only one possible value (I40E_DEFAULT_ATR_SAMPLE_RATE). Remove
    it and replace its occurrences by I40E_DEFAULT_ATR_SAMPLE_RATE
.adminq_work_limit
    Has only one possible value (I40E_AQ_WORK_LIMIT). Remove it and
    replace its occurrences by I40E_AQ_WORK_LIMIT
.tx_sluggish_count
    Unused, never written
.pf_seid
    Used to store VSI downlink seid and it is referenced only once
    in the same codepath. There is no need to save it into i40e_pf.
    Remove it and use downlink_seid directly in the mentioned log
    message.
.instance
    Write only. Remove it as well as ugly static local variable
    'pfs_found' in i40e_probe.
.int_policy
.switch_kobj
.ptp_pps_work
.ptp_extts1_work
.ptp_pps_start
.pps_delay
.ptp_pin
.override_q_count
    All these unused at all

Prior the patch:
pahole -Ci40e_pf drivers/net/ethernet/intel/i40e/i40e.ko | tail -5
        /* size: 5368, cachelines: 84, members: 127 */
        /* sum members: 5297, holes: 20, sum holes: 71 */
        /* paddings: 6, sum paddings: 19 */
        /* last cacheline: 56 bytes */
};

After the patch:
pahole -Ci40e_pf drivers/net/ethernet/intel/i40e/i40e.ko | tail -5
        /* size: 4976, cachelines: 78, members: 112 */
        /* sum members: 4905, holes: 17, sum holes: 71 */
        /* paddings: 6, sum paddings: 19 */
        /* last cacheline: 48 bytes */
};

Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2023-11-27 09:18:42 -08:00
..
i40e.h i40e: Delete unused and useless i40e_pf fields 2023-11-27 09:18:42 -08:00
i40e_adminq.c i40e: Remove VF MAC types 2023-11-14 20:05:44 -08:00
i40e_adminq.h i40e: Split i40e_osdep.h 2023-10-05 09:13:43 -07:00
i40e_adminq_cmd.h i40e: Remove circular header dependencies and fix headers 2023-10-05 09:18:09 -07:00
i40e_alloc.h i40e: Move memory allocation structures to i40e_alloc.h 2023-10-05 09:13:42 -07:00
i40e_client.c i40e: Remove circular header dependencies and fix headers 2023-10-05 09:18:09 -07:00
i40e_common.c i40e: Use helpers to check running FW and AQ API versions 2023-11-14 20:05:44 -08:00
i40e_dcb.c i40e: Use helpers to check running FW and AQ API versions 2023-11-14 20:05:44 -08:00
i40e_dcb.h i40e: use int for i40e_status 2023-02-09 08:35:53 -08:00
i40e_dcb_nl.c i40e: Delete unused i40e_mac_info fields 2023-11-14 20:05:45 -08:00
i40e_ddp.c i40e: use scnprintf over strncpy+strncat 2023-10-18 18:10:17 -07:00
i40e_debug.h i40e: Initialize hardware capabilities at single place 2023-11-14 20:05:44 -08:00
i40e_debugfs.c i40e: Delete unused and useless i40e_pf fields 2023-11-27 09:18:42 -08:00
i40e_devids.h i40e: Add basic support for I710 devices 2022-09-06 12:49:00 -07:00
i40e_devlink.c i40e: Do not call devlink_port_type_clear() 2023-11-06 16:16:13 -08:00
i40e_devlink.h i40e: Add initial devlink support 2023-10-15 14:33:41 +01:00
i40e_diag.c i40e: remove i40e_status 2023-07-31 14:37:25 -07:00
i40e_diag.h i40e: Remove circular header dependencies and fix headers 2023-10-05 09:18:09 -07:00
i40e_ethtool.c i40e: Consolidate hardware capabilities 2023-11-14 20:05:44 -08:00
i40e_hmc.c i40e: Remove circular header dependencies and fix headers 2023-10-05 09:18:09 -07:00
i40e_hmc.h i40e: Remove circular header dependencies and fix headers 2023-10-05 09:18:09 -07:00
i40e_io.h i40e: Split i40e_osdep.h 2023-10-05 09:13:43 -07:00
i40e_lan_hmc.c i40e: Remove circular header dependencies and fix headers 2023-10-05 09:18:09 -07:00
i40e_lan_hmc.h i40e: Remove circular header dependencies and fix headers 2023-10-05 09:18:09 -07:00
i40e_main.c i40e: Delete unused and useless i40e_pf fields 2023-11-27 09:18:42 -08:00
i40e_nvm.c i40e: Use DECLARE_BITMAP for flags field in i40e_hw 2023-11-14 20:05:44 -08:00
i40e_prototype.h i40e: Move inline helpers to i40e_prototype.h 2023-11-14 20:05:45 -08:00
i40e_ptp.c i40e: Consolidate hardware capabilities 2023-11-14 20:05:44 -08:00
i40e_register.h i40e: Initialize hardware capabilities at single place 2023-11-14 20:05:44 -08:00
i40e_trace.h i40e: add xdp_buff to i40e_ring struct 2023-03-09 13:11:24 -08:00
i40e_txrx.c i40e: Use DECLARE_BITMAP for flags and hw_features fields in i40e_pf 2023-11-14 20:05:43 -08:00
i40e_txrx.h i40e: Consolidate hardware capabilities 2023-11-14 20:05:44 -08:00
i40e_txrx_common.h i40e: Remove circular header dependencies and fix headers 2023-10-05 09:18:09 -07:00
i40e_type.h i40e: Delete unused i40e_mac_info fields 2023-11-14 20:05:45 -08:00
i40e_virtchnl_pf.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-11-23 12:20:58 -08:00
i40e_virtchnl_pf.h i40e: Remove circular header dependencies and fix headers 2023-10-05 09:18:09 -07:00
i40e_xsk.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-10-26 13:46:28 -07:00
i40e_xsk.h i40e: Remove circular header dependencies and fix headers 2023-10-05 09:18:09 -07:00
Makefile i40e: Add initial devlink support 2023-10-15 14:33:41 +01:00