strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. ethtool_sprintf() is designed specifically for get_strings() usage. Let's replace strncpy() in favor of this more robust and easier to understand interface. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Signed-off-by: Justin Stitt <justinstitt@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20231011-strncpy-drivers-net-ethernet-microchip-sparx5-sparx5_ethtool-c-v1-1-410953d07f42@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
||
---|---|---|
.. | ||
lan966x | ||
sparx5 | ||
vcap | ||
enc28j60.c | ||
enc28j60_hw.h | ||
encx24j600-regmap.c | ||
encx24j600.c | ||
encx24j600_hw.h | ||
Kconfig | ||
lan743x_ethtool.c | ||
lan743x_ethtool.h | ||
lan743x_main.c | ||
lan743x_main.h | ||
lan743x_ptp.c | ||
lan743x_ptp.h | ||
Makefile |