On X1E80100, there is a hardware bug in the register logic of the IRQ_ENABLE_BANK register: While read accesses work on the normal address, all write accesses must be made to a shifted address. Without a workaround for this, the wrong interrupt gets enabled in the PDC and it is impossible to wakeup from deep suspend (CX collapse). This has not caused problems so far, because the deep suspend state was not enabled. A workaround is required now since work is ongoing to fix this. The PDC has multiple "DRV" regions, each one has a size of 0x10000 and provides the same set of registers for a particular client in the system. Linux is one the clients and uses DRV region 2 on X1E. Each "bank" inside the DRV region consists of 32 interrupt pins that can be enabled using the IRQ_ENABLE_BANK register: IRQ_ENABLE_BANK[bank] = base + IRQ_ENABLE_BANK + bank * sizeof(u32) On X1E, this works as intended for read access. However, write access to most banks is shifted by 2: IRQ_ENABLE_BANK_X1E[0] = IRQ_ENABLE_BANK[-2] IRQ_ENABLE_BANK_X1E[1] = IRQ_ENABLE_BANK[-1] IRQ_ENABLE_BANK_X1E[2] = IRQ_ENABLE_BANK[0] = IRQ_ENABLE_BANK[2 - 2] IRQ_ENABLE_BANK_X1E[3] = IRQ_ENABLE_BANK[1] = IRQ_ENABLE_BANK[3 - 2] IRQ_ENABLE_BANK_X1E[4] = IRQ_ENABLE_BANK[2] = IRQ_ENABLE_BANK[4 - 2] IRQ_ENABLE_BANK_X1E[5] = IRQ_ENABLE_BANK[5] (this one works as intended) The negative indexes underflow to banks of the previous DRV/client region: IRQ_ENABLE_BANK_X1E[drv 2][bank 0] = IRQ_ENABLE_BANK[drv 2][bank -2] = IRQ_ENABLE_BANK[drv 1][bank 5-2] = IRQ_ENABLE_BANK[drv 1][bank 3] = IRQ_ENABLE_BANK[drv 1][bank 0 + 3] IRQ_ENABLE_BANK_X1E[drv 2][bank 1] = IRQ_ENABLE_BANK[drv 2][bank -1] = IRQ_ENABLE_BANK[drv 1][bank 5-1] = IRQ_ENABLE_BANK[drv 1][bank 4] = IRQ_ENABLE_BANK[drv 1][bank 1 + 3] Introduce a workaround for the bug by matching the qcom,x1e80100-pdc compatible and apply the offsets as shown above: - Bank 0...1: previous DRV region, bank += 3 - Bank 1...4: our DRV region, bank -= 2 - Bank 5: our DRV region, no fixup required The PDC node in the device tree only describes the DRV region for the Linux client, but the workaround also requires to map parts of the previous DRV region to issue writes there. To maintain compatibility with old device trees, obtain the base address of the preceeding region by applying the -0x10000 offset. Note that this is also more correct from a conceptual point of view: It does not really make use of the other region; it just issues shifted writes that end up in the registers of the Linux associated DRV region 2. Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Tested-by: Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/all/20250218-x1e80100-pdc-hw-wa-v2-1-29be4c98e355@linaro.org
434 lines
11 KiB
C
434 lines
11 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
#include <linux/err.h>
|
|
#include <linux/init.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/irqchip.h>
|
|
#include <linux/irqdomain.h>
|
|
#include <linux/io.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/of_irq.h>
|
|
#include <linux/soc/qcom/irq.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/types.h>
|
|
|
|
#define PDC_MAX_GPIO_IRQS 256
|
|
#define PDC_DRV_OFFSET 0x10000
|
|
|
|
/* Valid only on HW version < 3.2 */
|
|
#define IRQ_ENABLE_BANK 0x10
|
|
#define IRQ_ENABLE_BANK_MAX (IRQ_ENABLE_BANK + BITS_TO_BYTES(PDC_MAX_GPIO_IRQS))
|
|
#define IRQ_i_CFG 0x110
|
|
|
|
/* Valid only on HW version >= 3.2 */
|
|
#define IRQ_i_CFG_IRQ_ENABLE 3
|
|
|
|
#define IRQ_i_CFG_TYPE_MASK GENMASK(2, 0)
|
|
|
|
#define PDC_VERSION_REG 0x1000
|
|
|
|
/* Notable PDC versions */
|
|
#define PDC_VERSION_3_2 0x30200
|
|
|
|
struct pdc_pin_region {
|
|
u32 pin_base;
|
|
u32 parent_base;
|
|
u32 cnt;
|
|
};
|
|
|
|
#define pin_to_hwirq(r, p) ((r)->parent_base + (p) - (r)->pin_base)
|
|
|
|
static DEFINE_RAW_SPINLOCK(pdc_lock);
|
|
static void __iomem *pdc_base;
|
|
static void __iomem *pdc_prev_base;
|
|
static struct pdc_pin_region *pdc_region;
|
|
static int pdc_region_cnt;
|
|
static unsigned int pdc_version;
|
|
static bool pdc_x1e_quirk;
|
|
|
|
static void pdc_base_reg_write(void __iomem *base, int reg, u32 i, u32 val)
|
|
{
|
|
writel_relaxed(val, base + reg + i * sizeof(u32));
|
|
}
|
|
|
|
static void pdc_reg_write(int reg, u32 i, u32 val)
|
|
{
|
|
pdc_base_reg_write(pdc_base, reg, i, val);
|
|
}
|
|
|
|
static u32 pdc_reg_read(int reg, u32 i)
|
|
{
|
|
return readl_relaxed(pdc_base + reg + i * sizeof(u32));
|
|
}
|
|
|
|
static void pdc_x1e_irq_enable_write(u32 bank, u32 enable)
|
|
{
|
|
void __iomem *base;
|
|
|
|
/* Remap the write access to work around a hardware bug on X1E */
|
|
switch (bank) {
|
|
case 0 ... 1:
|
|
/* Use previous DRV (client) region and shift to bank 3-4 */
|
|
base = pdc_prev_base;
|
|
bank += 3;
|
|
break;
|
|
case 2 ... 4:
|
|
/* Use our own region and shift to bank 0-2 */
|
|
base = pdc_base;
|
|
bank -= 2;
|
|
break;
|
|
case 5:
|
|
/* No fixup required for bank 5 */
|
|
base = pdc_base;
|
|
break;
|
|
default:
|
|
WARN_ON(1);
|
|
return;
|
|
}
|
|
|
|
pdc_base_reg_write(base, IRQ_ENABLE_BANK, bank, enable);
|
|
}
|
|
|
|
static void __pdc_enable_intr(int pin_out, bool on)
|
|
{
|
|
unsigned long enable;
|
|
|
|
if (pdc_version < PDC_VERSION_3_2) {
|
|
u32 index, mask;
|
|
|
|
index = pin_out / 32;
|
|
mask = pin_out % 32;
|
|
|
|
enable = pdc_reg_read(IRQ_ENABLE_BANK, index);
|
|
__assign_bit(mask, &enable, on);
|
|
|
|
if (pdc_x1e_quirk)
|
|
pdc_x1e_irq_enable_write(index, enable);
|
|
else
|
|
pdc_reg_write(IRQ_ENABLE_BANK, index, enable);
|
|
} else {
|
|
enable = pdc_reg_read(IRQ_i_CFG, pin_out);
|
|
__assign_bit(IRQ_i_CFG_IRQ_ENABLE, &enable, on);
|
|
pdc_reg_write(IRQ_i_CFG, pin_out, enable);
|
|
}
|
|
}
|
|
|
|
static void pdc_enable_intr(struct irq_data *d, bool on)
|
|
{
|
|
unsigned long flags;
|
|
|
|
raw_spin_lock_irqsave(&pdc_lock, flags);
|
|
__pdc_enable_intr(d->hwirq, on);
|
|
raw_spin_unlock_irqrestore(&pdc_lock, flags);
|
|
}
|
|
|
|
static void qcom_pdc_gic_disable(struct irq_data *d)
|
|
{
|
|
pdc_enable_intr(d, false);
|
|
irq_chip_disable_parent(d);
|
|
}
|
|
|
|
static void qcom_pdc_gic_enable(struct irq_data *d)
|
|
{
|
|
pdc_enable_intr(d, true);
|
|
irq_chip_enable_parent(d);
|
|
}
|
|
|
|
/*
|
|
* GIC does not handle falling edge or active low. To allow falling edge and
|
|
* active low interrupts to be handled at GIC, PDC has an inverter that inverts
|
|
* falling edge into a rising edge and active low into an active high.
|
|
* For the inverter to work, the polarity bit in the IRQ_CONFIG register has to
|
|
* set as per the table below.
|
|
* Level sensitive active low LOW
|
|
* Rising edge sensitive NOT USED
|
|
* Falling edge sensitive LOW
|
|
* Dual Edge sensitive NOT USED
|
|
* Level sensitive active High HIGH
|
|
* Falling Edge sensitive NOT USED
|
|
* Rising edge sensitive HIGH
|
|
* Dual Edge sensitive HIGH
|
|
*/
|
|
enum pdc_irq_config_bits {
|
|
PDC_LEVEL_LOW = 0b000,
|
|
PDC_EDGE_FALLING = 0b010,
|
|
PDC_LEVEL_HIGH = 0b100,
|
|
PDC_EDGE_RISING = 0b110,
|
|
PDC_EDGE_DUAL = 0b111,
|
|
};
|
|
|
|
/**
|
|
* qcom_pdc_gic_set_type: Configure PDC for the interrupt
|
|
*
|
|
* @d: the interrupt data
|
|
* @type: the interrupt type
|
|
*
|
|
* If @type is edge triggered, forward that as Rising edge as PDC
|
|
* takes care of converting falling edge to rising edge signal
|
|
* If @type is level, then forward that as level high as PDC
|
|
* takes care of converting falling edge to rising edge signal
|
|
*/
|
|
static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type)
|
|
{
|
|
enum pdc_irq_config_bits pdc_type;
|
|
enum pdc_irq_config_bits old_pdc_type;
|
|
int ret;
|
|
|
|
switch (type) {
|
|
case IRQ_TYPE_EDGE_RISING:
|
|
pdc_type = PDC_EDGE_RISING;
|
|
break;
|
|
case IRQ_TYPE_EDGE_FALLING:
|
|
pdc_type = PDC_EDGE_FALLING;
|
|
type = IRQ_TYPE_EDGE_RISING;
|
|
break;
|
|
case IRQ_TYPE_EDGE_BOTH:
|
|
pdc_type = PDC_EDGE_DUAL;
|
|
type = IRQ_TYPE_EDGE_RISING;
|
|
break;
|
|
case IRQ_TYPE_LEVEL_HIGH:
|
|
pdc_type = PDC_LEVEL_HIGH;
|
|
break;
|
|
case IRQ_TYPE_LEVEL_LOW:
|
|
pdc_type = PDC_LEVEL_LOW;
|
|
type = IRQ_TYPE_LEVEL_HIGH;
|
|
break;
|
|
default:
|
|
WARN_ON(1);
|
|
return -EINVAL;
|
|
}
|
|
|
|
old_pdc_type = pdc_reg_read(IRQ_i_CFG, d->hwirq);
|
|
pdc_type |= (old_pdc_type & ~IRQ_i_CFG_TYPE_MASK);
|
|
pdc_reg_write(IRQ_i_CFG, d->hwirq, pdc_type);
|
|
|
|
ret = irq_chip_set_type_parent(d, type);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/*
|
|
* When we change types the PDC can give a phantom interrupt.
|
|
* Clear it. Specifically the phantom shows up when reconfiguring
|
|
* polarity of interrupt without changing the state of the signal
|
|
* but let's be consistent and clear it always.
|
|
*
|
|
* Doing this works because we have IRQCHIP_SET_TYPE_MASKED so the
|
|
* interrupt will be cleared before the rest of the system sees it.
|
|
*/
|
|
if (old_pdc_type != pdc_type)
|
|
irq_chip_set_parent_state(d, IRQCHIP_STATE_PENDING, false);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct irq_chip qcom_pdc_gic_chip = {
|
|
.name = "PDC",
|
|
.irq_eoi = irq_chip_eoi_parent,
|
|
.irq_mask = irq_chip_mask_parent,
|
|
.irq_unmask = irq_chip_unmask_parent,
|
|
.irq_disable = qcom_pdc_gic_disable,
|
|
.irq_enable = qcom_pdc_gic_enable,
|
|
.irq_get_irqchip_state = irq_chip_get_parent_state,
|
|
.irq_set_irqchip_state = irq_chip_set_parent_state,
|
|
.irq_retrigger = irq_chip_retrigger_hierarchy,
|
|
.irq_set_type = qcom_pdc_gic_set_type,
|
|
.flags = IRQCHIP_MASK_ON_SUSPEND |
|
|
IRQCHIP_SET_TYPE_MASKED |
|
|
IRQCHIP_SKIP_SET_WAKE |
|
|
IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND,
|
|
.irq_set_vcpu_affinity = irq_chip_set_vcpu_affinity_parent,
|
|
.irq_set_affinity = irq_chip_set_affinity_parent,
|
|
};
|
|
|
|
static struct pdc_pin_region *get_pin_region(int pin)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < pdc_region_cnt; i++) {
|
|
if (pin >= pdc_region[i].pin_base &&
|
|
pin < pdc_region[i].pin_base + pdc_region[i].cnt)
|
|
return &pdc_region[i];
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static int qcom_pdc_alloc(struct irq_domain *domain, unsigned int virq,
|
|
unsigned int nr_irqs, void *data)
|
|
{
|
|
struct irq_fwspec *fwspec = data;
|
|
struct irq_fwspec parent_fwspec;
|
|
struct pdc_pin_region *region;
|
|
irq_hw_number_t hwirq;
|
|
unsigned int type;
|
|
int ret;
|
|
|
|
ret = irq_domain_translate_twocell(domain, fwspec, &hwirq, &type);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (hwirq == GPIO_NO_WAKE_IRQ)
|
|
return irq_domain_disconnect_hierarchy(domain, virq);
|
|
|
|
ret = irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
|
|
&qcom_pdc_gic_chip, NULL);
|
|
if (ret)
|
|
return ret;
|
|
|
|
region = get_pin_region(hwirq);
|
|
if (!region)
|
|
return irq_domain_disconnect_hierarchy(domain->parent, virq);
|
|
|
|
if (type & IRQ_TYPE_EDGE_BOTH)
|
|
type = IRQ_TYPE_EDGE_RISING;
|
|
|
|
if (type & IRQ_TYPE_LEVEL_MASK)
|
|
type = IRQ_TYPE_LEVEL_HIGH;
|
|
|
|
parent_fwspec.fwnode = domain->parent->fwnode;
|
|
parent_fwspec.param_count = 3;
|
|
parent_fwspec.param[0] = 0;
|
|
parent_fwspec.param[1] = pin_to_hwirq(region, hwirq);
|
|
parent_fwspec.param[2] = type;
|
|
|
|
return irq_domain_alloc_irqs_parent(domain, virq, nr_irqs,
|
|
&parent_fwspec);
|
|
}
|
|
|
|
static const struct irq_domain_ops qcom_pdc_ops = {
|
|
.translate = irq_domain_translate_twocell,
|
|
.alloc = qcom_pdc_alloc,
|
|
.free = irq_domain_free_irqs_common,
|
|
};
|
|
|
|
static int pdc_setup_pin_mapping(struct device_node *np)
|
|
{
|
|
int ret, n, i;
|
|
|
|
n = of_property_count_elems_of_size(np, "qcom,pdc-ranges", sizeof(u32));
|
|
if (n <= 0 || n % 3)
|
|
return -EINVAL;
|
|
|
|
pdc_region_cnt = n / 3;
|
|
pdc_region = kcalloc(pdc_region_cnt, sizeof(*pdc_region), GFP_KERNEL);
|
|
if (!pdc_region) {
|
|
pdc_region_cnt = 0;
|
|
return -ENOMEM;
|
|
}
|
|
|
|
for (n = 0; n < pdc_region_cnt; n++) {
|
|
ret = of_property_read_u32_index(np, "qcom,pdc-ranges",
|
|
n * 3 + 0,
|
|
&pdc_region[n].pin_base);
|
|
if (ret)
|
|
return ret;
|
|
ret = of_property_read_u32_index(np, "qcom,pdc-ranges",
|
|
n * 3 + 1,
|
|
&pdc_region[n].parent_base);
|
|
if (ret)
|
|
return ret;
|
|
ret = of_property_read_u32_index(np, "qcom,pdc-ranges",
|
|
n * 3 + 2,
|
|
&pdc_region[n].cnt);
|
|
if (ret)
|
|
return ret;
|
|
|
|
for (i = 0; i < pdc_region[n].cnt; i++)
|
|
__pdc_enable_intr(i + pdc_region[n].pin_base, 0);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
#define QCOM_PDC_SIZE 0x30000
|
|
|
|
static int qcom_pdc_init(struct device_node *node, struct device_node *parent)
|
|
{
|
|
struct irq_domain *parent_domain, *pdc_domain;
|
|
resource_size_t res_size;
|
|
struct resource res;
|
|
int ret;
|
|
|
|
/* compat with old sm8150 DT which had very small region for PDC */
|
|
if (of_address_to_resource(node, 0, &res))
|
|
return -EINVAL;
|
|
|
|
res_size = max_t(resource_size_t, resource_size(&res), QCOM_PDC_SIZE);
|
|
if (res_size > resource_size(&res))
|
|
pr_warn("%pOF: invalid reg size, please fix DT\n", node);
|
|
|
|
/*
|
|
* PDC has multiple DRV regions, each one provides the same set of
|
|
* registers for a particular client in the system. Due to a hardware
|
|
* bug on X1E, some writes to the IRQ_ENABLE_BANK register must be
|
|
* issued inside the previous region. This region belongs to
|
|
* a different client and is not described in the device tree. Map the
|
|
* region with the expected offset to preserve support for old DTs.
|
|
*/
|
|
if (of_device_is_compatible(node, "qcom,x1e80100-pdc")) {
|
|
pdc_prev_base = ioremap(res.start - PDC_DRV_OFFSET, IRQ_ENABLE_BANK_MAX);
|
|
if (!pdc_prev_base) {
|
|
pr_err("%pOF: unable to map previous PDC DRV region\n", node);
|
|
return -ENXIO;
|
|
}
|
|
|
|
pdc_x1e_quirk = true;
|
|
}
|
|
|
|
pdc_base = ioremap(res.start, res_size);
|
|
if (!pdc_base) {
|
|
pr_err("%pOF: unable to map PDC registers\n", node);
|
|
ret = -ENXIO;
|
|
goto fail;
|
|
}
|
|
|
|
pdc_version = pdc_reg_read(PDC_VERSION_REG, 0);
|
|
|
|
parent_domain = irq_find_host(parent);
|
|
if (!parent_domain) {
|
|
pr_err("%pOF: unable to find PDC's parent domain\n", node);
|
|
ret = -ENXIO;
|
|
goto fail;
|
|
}
|
|
|
|
ret = pdc_setup_pin_mapping(node);
|
|
if (ret) {
|
|
pr_err("%pOF: failed to init PDC pin-hwirq mapping\n", node);
|
|
goto fail;
|
|
}
|
|
|
|
pdc_domain = irq_domain_create_hierarchy(parent_domain,
|
|
IRQ_DOMAIN_FLAG_QCOM_PDC_WAKEUP,
|
|
PDC_MAX_GPIO_IRQS,
|
|
of_fwnode_handle(node),
|
|
&qcom_pdc_ops, NULL);
|
|
if (!pdc_domain) {
|
|
pr_err("%pOF: PDC domain add failed\n", node);
|
|
ret = -ENOMEM;
|
|
goto fail;
|
|
}
|
|
|
|
irq_domain_update_bus_token(pdc_domain, DOMAIN_BUS_WAKEUP);
|
|
|
|
return 0;
|
|
|
|
fail:
|
|
kfree(pdc_region);
|
|
iounmap(pdc_base);
|
|
iounmap(pdc_prev_base);
|
|
return ret;
|
|
}
|
|
|
|
IRQCHIP_PLATFORM_DRIVER_BEGIN(qcom_pdc)
|
|
IRQCHIP_MATCH("qcom,pdc", qcom_pdc_init)
|
|
IRQCHIP_PLATFORM_DRIVER_END(qcom_pdc)
|
|
MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Power Domain Controller");
|
|
MODULE_LICENSE("GPL v2");
|