Jakub Buchocki 24b454bc35 ice: Fix ice module unload ... Clearing the interrupt scheme before PFR reset, during the removal routine, could cause the hardware errors and possibly lead to system reboot, as the PF reset can cause the interrupt to be generated. Place the call for PFR reset inside ice_deinit_dev(), wait until reset and all pending transactions are done, then call ice_clear_interrupt_scheme(). This introduces a PFR reset to multiple error paths. Additionally, remove the call for the reset from ice_load() - it will be a part of ice_unload() now. Error example: [ 75.229328] ice 0000:ca:00.1: Failed to read Tx Scheduler Tree - User Selection data from flash [ 77.571315] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 1 [ 77.571418] {1}[Hardware Error]: event severity: recoverable [ 77.571459] {1}[Hardware Error]: Error 0, type: recoverable [ 77.571500] {1}[Hardware Error]: section_type: PCIe error [ 77.571540] {1}[Hardware Error]: port_type: 4, root port [ 77.571580] {1}[Hardware Error]: version: 3.0 [ 77.571615] {1}[Hardware Error]: command: 0x0547, status: 0x4010 [ 77.571661] {1}[Hardware Error]: device_id: 0000:c9:02.0 [ 77.571703] {1}[Hardware Error]: slot: 25 [ 77.571736] {1}[Hardware Error]: secondary_bus: 0xca [ 77.571773] {1}[Hardware Error]: vendor_id: 0x8086, device_id: 0x347a [ 77.571821] {1}[Hardware Error]: class_code: 060400 [ 77.571858] {1}[Hardware Error]: bridge: secondary_status: 0x2800, control: 0x0013 [ 77.572490] pcieport 0000:c9:02.0: AER: aer_status: 0x00200000, aer_mask: 0x00100020 [ 77.572870] pcieport 0000:c9:02.0: [21] ACSViol (First) [ 77.573222] pcieport 0000:c9:02.0: AER: aer_layer=Transaction Layer, aer_agent=Receiver ID [ 77.573554] pcieport 0000:c9:02.0: AER: aer_uncor_severity: 0x00463010 [ 77.691273] {2}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 1 [ 77.691738] {2}[Hardware Error]: event severity: recoverable [ 77.691971] {2}[Hardware Error]: Error 0, type: recoverable [ 77.692192] {2}[Hardware Error]: section_type: PCIe error [ 77.692403] {2}[Hardware Error]: port_type: 4, root port [ 77.692616] {2}[Hardware Error]: version: 3.0 [ 77.692825] {2}[Hardware Error]: command: 0x0547, status: 0x4010 [ 77.693032] {2}[Hardware Error]: device_id: 0000:c9:02.0 [ 77.693238] {2}[Hardware Error]: slot: 25 [ 77.693440] {2}[Hardware Error]: secondary_bus: 0xca [ 77.693641] {2}[Hardware Error]: vendor_id: 0x8086, device_id: 0x347a [ 77.693853] {2}[Hardware Error]: class_code: 060400 [ 77.694054] {2}[Hardware Error]: bridge: secondary_status: 0x0800, control: 0x0013 [ 77.719115] pci 0000:ca:00.1: AER: can't recover (no error_detected callback) [ 77.719140] pcieport 0000:c9:02.0: AER: device recovery failed [ 77.719216] pcieport 0000:c9:02.0: AER: aer_status: 0x00200000, aer_mask: 0x00100020 [ 77.719390] pcieport 0000:c9:02.0: [21] ACSViol (First) [ 77.719557] pcieport 0000:c9:02.0: AER: aer_layer=Transaction Layer, aer_agent=Receiver ID [ 77.719723] pcieport 0000:c9:02.0: AER: aer_uncor_severity: 0x00463010 Fixes: 5b246e533d ("ice: split probe into smaller functions") Signed-off-by: Jakub Buchocki <jakubx.buchocki@intel.com> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Link: https://lore.kernel.org/r/20230612171421.21570-1-anthony.l.nguyen@intel.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2023-06-14 22:43:36 -07:00
..
ice.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-03-17 16:29:25 -07:00
ice_adminq_cmd.h	ice: Add 'Execute Pending LLDP MIB' Admin Queue command	2023-01-19 08:18:03 -08:00
ice_arfs.c	ice: arfs: fix use-after-free when freeing @rx_cpu_rmap	2022-04-08 09:08:36 -07:00
ice_arfs.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_base.c	ice: Add support for XDP multi-buffer on Rx side	2023-02-01 23:30:27 +01:00
ice_base.h	ice: split ice_ring onto Tx/Rx separate structs	2021-10-15 07:39:02 -07:00
ice_cgu_regs.h	ice: ensure the hardware Clock Generation Unit is configured	2021-12-21 09:11:40 -08:00
ice_common.c	ice: make writes to /dev/gnssX synchronous	2023-06-07 10:51:58 +01:00
ice_common.h	ice: make writes to /dev/gnssX synchronous	2023-06-07 10:51:58 +01:00
ice_controlq.c	ice: sleep, don't busy-wait, for ICE_CTL_Q_SQ_CMD_TIMEOUT	2023-04-20 16:33:14 -07:00
ice_controlq.h	ice: sleep, don't busy-wait, for ICE_CTL_Q_SQ_CMD_TIMEOUT	2023-04-20 16:33:14 -07:00
ice_dcb.c	ice: Fix DSCP PFC TLV creation	2023-03-07 13:02:01 -08:00
ice_dcb.h	ice: Handle LLDP MIB Pending change	2023-01-19 08:18:03 -08:00
ice_dcb_lib.c	ice: Fix undersized tx_flags variable	2023-05-12 09:27:44 +01:00
ice_dcb_lib.h	ice: Prevent set_channel from changing queues while RDMA active	2023-01-27 11:32:18 -08:00
ice_dcb_nl.c	ice: Fix problems with DSCP QoS implementation	2021-12-07 13:21:01 -08:00
ice_dcb_nl.h	ice: use static inline for dummy functions	2021-06-07 08:59:01 -07:00
ice_ddp.c	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_ddp.h	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_devids.h	ice: support features on new E810T variants	2022-09-28 11:40:57 -07:00
ice_devlink.c	ice: remove comment about not supporting driver reinit	2023-03-30 09:35:07 -07:00
ice_devlink.h	ice: Prevent ADQ, DCB coexistence with Custom Tx scheduler	2022-11-17 21:41:28 -08:00
ice_eswitch.c	ice: remove unnecessary virtchnl_ether_addr struct use	2023-02-06 09:47:48 -08:00
ice_eswitch.h	ice: allow creating VFs for !CONFIG_NET_SWITCHDEV	2022-04-14 08:19:54 -07:00
ice_ethtool.c	ice: copy last block omitted in ice_get_module_eeprom()	2023-03-03 08:25:29 +00:00
ice_ethtool_fdir.c	ice: Use correct order for the parameters of devm_kcalloc()	2022-06-08 08:55:13 -07:00
ice_fdir.c	ice: Cleanup after ice_status removal	2021-12-14 10:19:13 -08:00
ice_fdir.h	ice: Add flow director support for channel mode	2021-12-30 13:16:07 +00:00
ice_flex_pipe.c	ice: Reduce scope of variables	2023-01-19 08:18:03 -08:00
ice_flex_pipe.h	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_flex_type.h	ice: Move support DDP code out of ice_flex_pipe.c	2023-01-19 08:18:03 -08:00
ice_flow.c	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_flow.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_fltr.c	ice: sync netdev filters after clearing VSI	2023-02-03 09:54:18 -08:00
ice_fltr.h	ice: Introduce ice_vlan struct	2022-02-09 09:24:45 -08:00
ice_fw_update.c	ice: handle E822 generic device ID in PLDM header	2022-07-12 09:25:34 -07:00
ice_fw_update.h	ice: support immediate firmware activation via devlink reload	2021-12-15 08:40:38 -08:00
ice_gnss.c	ice: Don't dereference NULL in ice_gnss_read error path	2023-06-08 08:38:56 -07:00
ice_gnss.h	ice: make writes to /dev/gnssX synchronous	2023-06-07 10:51:58 +01:00
ice_hw_autogen.h	ice: Add support Flex RXD	2022-10-27 13:23:43 +02:00
ice_idc.c	ice: alloc id for RDMA using xa_array	2023-02-03 09:54:18 -08:00
ice_idc_int.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_lag.c	ice: remove non-inclusive language	2022-08-18 08:26:11 -07:00
ice_lag.h	ice: remove non-inclusive language	2022-08-18 08:26:11 -07:00
ice_lan_tx_rx.h	ice: Remove and replace ice speed defines with ethtool.h versions	2022-11-23 08:59:42 -08:00
ice_lib.c	ice: Fix stats after PF reset	2023-05-16 09:51:40 -07:00
ice_lib.h	ice: refactor VSI setup to use parameter structure	2023-02-06 09:37:31 -08:00
ice_main.c	ice: Fix ice module unload	2023-06-14 22:43:36 -07:00
ice_nvm.c	ice: Remove cppcheck suppressions	2023-01-19 08:18:03 -08:00
ice_nvm.h	ice: Add additional flags to ice_nvm_write_activate	2022-08-24 08:45:54 -07:00
ice_osdep.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_pf_vsi_vlan_ops.c	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_pf_vsi_vlan_ops.h	ice: Add outer_vlan_ops and VSI specific VLAN ops implementations	2022-02-09 09:24:45 -08:00
ice_protocol_type.h	ice: Add L2TPv3 hardware offload support	2022-09-20 09:13:38 +02:00
ice_ptp.c	ice/ptp: fix the PTP worker retrying indefinitely if the link went down	2023-02-14 13:08:02 -08:00
ice_ptp.h	ice: handle flushing stale Tx timestamps in ice_ptp_tx_tstamp	2022-12-08 13:15:03 -08:00
ice_ptp_consts.h	ice: ensure the hardware Clock Generation Unit is configured	2021-12-21 09:11:40 -08:00
ice_ptp_hw.c	ice: make Tx and Rx vernier offset calibration independent	2022-12-08 13:15:03 -08:00
ice_ptp_hw.h	ice: make Tx and Rx vernier offset calibration independent	2022-12-08 13:15:03 -08:00
ice_repr.c	ice: Accumulate ring statistics over reset	2022-11-23 08:59:43 -08:00
ice_repr.h	ice: remove circular header dependencies on ice.h	2022-03-14 17:22:58 -07:00
ice_sbq_cmd.h	ice: add support for sideband messages	2021-06-11 07:38:00 -07:00
ice_sched.c	ice: fix invalid check for empty list in ice_sched_assoc_vsi_to_agg()	2023-03-28 09:48:49 -07:00
ice_sched.h	ice: Add an option to pre-allocate memory for ice_sched_node	2022-11-17 21:41:28 -08:00
ice_sriov.c	ice: Fix ice VF reset during iavf initialization	2023-05-16 09:51:41 -07:00
ice_sriov.h	ice: move ice_is_malicious_vf() to ice_virtchnl.c	2023-03-13 11:06:06 -07:00
ice_switch.c	ice: Fix ice_cfg_rdma_fltr() to only update relevant fields	2023-03-28 09:43:12 -07:00
ice_switch.h	ice: Introduce enabling promiscuous mode on multiple VF's	2022-07-28 11:44:22 -07:00
ice_tc_lib.c	ice: block LAN in case of VF to VF offload	2023-05-05 09:29:21 +01:00
ice_tc_lib.h	ice: Support drop action	2023-01-19 08:18:03 -08:00
ice_trace.h	ice: add trace events for tx timestamps	2022-03-16 10:38:15 -07:00
ice_txrx.c	ice: recycle/free all of the fragments from multi-buffer frame	2023-06-01 09:59:39 -07:00
ice_txrx.h	ice: Fix undersized tx_flags variable	2023-05-12 09:27:44 +01:00
ice_txrx_lib.c	ice: fix W=1 headers mismatch	2023-03-28 09:42:05 -07:00
ice_txrx_lib.h	ice: Micro-optimize .ndo_xdp_xmit() path	2023-02-13 19:13:13 +01:00
ice_type.h	ice: move VF overflow message count into struct ice_mbx_vf_info	2023-03-13 10:32:32 -07:00
ice_vf_lib.c	ice: Fix ice VF reset during iavf initialization	2023-05-16 09:51:41 -07:00
ice_vf_lib.h	ice: Fix ice VF reset during iavf initialization	2023-05-16 09:51:41 -07:00
ice_vf_lib_private.h	ice: introduce ice_vf_init_host_cfg function	2023-02-06 09:41:56 -08:00
ice_vf_mbx.c	ice: merge ice_mbx_report_malvf with ice_mbx_vf_state_handler	2023-03-13 11:00:10 -07:00
ice_vf_mbx.h	ice: initialize mailbox snapshot earlier in PF init	2023-03-13 11:06:05 -07:00
ice_vf_vsi_vlan_ops.c	ice: Fix disabling Rx VLAN filtering with port VLAN enabled	2023-02-06 15:13:02 -08:00
ice_vf_vsi_vlan_ops.h	ice: Add support for VIRTCHNL_VF_OFFLOAD_VLAN_V2	2022-02-09 09:24:45 -08:00
ice_virtchnl.c	ice: Fix ice VF reset during iavf initialization	2023-05-16 09:51:41 -07:00
ice_virtchnl.h	ice: call ice_is_malicious_vf() from ice_vc_process_vf_msg()	2023-03-13 11:06:06 -07:00
ice_virtchnl_allowlist.c	ice: Add support Flex RXD	2022-10-27 13:23:43 +02:00
ice_virtchnl_allowlist.h	ice: Allow ignoring opcodes on specific VF	2021-04-22 09:26:22 -07:00
ice_virtchnl_fdir.c	ice: Reset FDIR counter in FDIR init stage	2023-04-04 08:34:52 -07:00
ice_virtchnl_fdir.h	ice: introduce ice_vf_lib.c, ice_vf_lib.h, and ice_vf_lib_private.h	2022-03-15 13:22:13 -07:00
ice_vlan.h	ice: Use the proto argument for VLAN ops	2022-02-09 09:24:45 -08:00
ice_vlan_mode.c	ice: Add support for VLAN TPID filters in switchdev	2022-06-30 13:53:33 -07:00
ice_vlan_mode.h	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_lib.c	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_lib.h	ice: Add outer_vlan_ops and VSI specific VLAN ops implementations	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_ops.c	ice: Add outer_vlan_ops and VSI specific VLAN ops implementations	2022-02-09 09:24:45 -08:00
ice_vsi_vlan_ops.h	ice: Support configuring the device to Double VLAN Mode	2022-02-09 09:24:45 -08:00
ice_xsk.c	ice: xsk: disable txq irq before flushing hw	2023-03-16 17:36:58 +00:00
ice_xsk.h	ice: xsk: change batched Tx descriptor cleaning	2022-09-27 08:11:02 -07:00
Makefile	ice: remove unnecessary CONFIG_ICE_GNSS	2023-02-26 14:53:09 +00:00