a5f3171b13
Running shellcheck on probe_vfs_getname fails with below
warning:
In ./tools/perf/tests/shell/lib/probe_vfs_getname.sh line 1:
# Arnaldo Carvalho de Melo <acme@kernel.org>, 2017
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
In ./tools/perf/tests/shell/lib/probe_vfs_getname.sh line 14:
local verbose=$1
^-----------^ SC3043 (warning): In POSIX sh, 'local' is undefined.
Fix this:
- by adding shebang in the beginning of the file and
- rename variable verbose to "add_probe_verbose" after removing
local
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Disha Goel <disgoel@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org
Link: https://lore.kernel.org/r/20230709182800.53002-19-atrajeev@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
33 lines
1.1 KiB
Bash
33 lines
1.1 KiB
Bash
#!/bin/sh
|
|
# Arnaldo Carvalho de Melo <acme@kernel.org>, 2017
|
|
|
|
perf probe -l 2>&1 | grep -q probe:vfs_getname
|
|
had_vfs_getname=$?
|
|
|
|
cleanup_probe_vfs_getname() {
|
|
if [ $had_vfs_getname -eq 1 ] ; then
|
|
perf probe -q -d probe:vfs_getname*
|
|
fi
|
|
}
|
|
|
|
add_probe_vfs_getname() {
|
|
add_probe_verbose=$1
|
|
if [ $had_vfs_getname -eq 1 ] ; then
|
|
line=$(perf probe -L getname_flags 2>&1 | grep -E 'result.*=.*filename;' | sed -r 's/[[:space:]]+([[:digit:]]+)[[:space:]]+result->uptr.*/\1/')
|
|
perf probe -q "vfs_getname=getname_flags:${line} pathname=result->name:string" || \
|
|
perf probe $add_probe_verbose "vfs_getname=getname_flags:${line} pathname=filename:ustring"
|
|
fi
|
|
}
|
|
|
|
skip_if_no_debuginfo() {
|
|
add_probe_vfs_getname -v 2>&1 | grep -E -q "^(Failed to find the path for the kernel|Debuginfo-analysis is not supported)|(file has no debug information)" && return 2
|
|
return 1
|
|
}
|
|
|
|
# check if perf is compiled with libtraceevent support
|
|
skip_no_probe_record_support() {
|
|
if [ $had_vfs_getname -eq 1 ] ; then
|
|
perf record --dry-run -e $1 2>&1 | grep "libtraceevent is necessary for tracepoint support" && return 2
|
|
return 1
|
|
fi
|
|
}
|