38b3fa07f1
Running shellcheck on test_perf_data_converter_json.sh throws
below warning:
In tests/shell/test_perf_data_converter_json.sh line 42:
if [ $(cat "${result}" | wc -l) -gt "0" ] ; then
^------------------------^ SC2046 (warning): Quote this to prevent word splitting.
Fixed the warning by adding quotes to avoid word splitting.
ShellCheck result with patch:
# shellcheck -S warning test_perf_data_converter_json.sh
#
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Disha Goel <disgoel@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org
Link: https://lore.kernel.org/r/20230709182800.53002-9-atrajeev@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
72 lines
1.5 KiB
Bash
Executable file
72 lines
1.5 KiB
Bash
Executable file
#!/bin/bash
|
|
# 'perf data convert --to-json' command test
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
set -e
|
|
|
|
err=0
|
|
|
|
if [ "$PYTHON" = "" ] ; then
|
|
if which python3 > /dev/null ; then
|
|
PYTHON=python3
|
|
elif which python > /dev/null ; then
|
|
PYTHON=python
|
|
else
|
|
echo Skipping test, python not detected please set environment variable PYTHON.
|
|
exit 2
|
|
fi
|
|
fi
|
|
|
|
perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
|
|
result=$(mktemp /tmp/__perf_test.output.json.XXXXX)
|
|
|
|
cleanup()
|
|
{
|
|
rm -f "${perfdata}"
|
|
rm -f "${result}"
|
|
trap - exit term int
|
|
}
|
|
|
|
trap_cleanup()
|
|
{
|
|
cleanup
|
|
exit ${err}
|
|
}
|
|
trap trap_cleanup exit term int
|
|
|
|
test_json_converter_command()
|
|
{
|
|
echo "Testing Perf Data Convertion Command to JSON"
|
|
perf record -o "$perfdata" -F 99 -g -- perf test -w noploop > /dev/null 2>&1
|
|
perf data convert --to-json "$result" --force -i "$perfdata" >/dev/null 2>&1
|
|
if [ "$(cat ${result} | wc -l)" -gt "0" ] ; then
|
|
echo "Perf Data Converter Command to JSON [SUCCESS]"
|
|
else
|
|
echo "Perf Data Converter Command to JSON [FAILED]"
|
|
err=1
|
|
exit
|
|
fi
|
|
}
|
|
|
|
validate_json_format()
|
|
{
|
|
echo "Validating Perf Data Converted JSON file"
|
|
if [ -f "$result" ] ; then
|
|
if $PYTHON -c "import json; json.load(open('$result'))" >/dev/null 2>&1 ; then
|
|
echo "The file contains valid JSON format [SUCCESS]"
|
|
else
|
|
echo "The file does not contain valid JSON format [FAILED]"
|
|
err=1
|
|
exit
|
|
fi
|
|
else
|
|
echo "File not found [FAILED]"
|
|
err=2
|
|
exit
|
|
fi
|
|
}
|
|
|
|
test_json_converter_command
|
|
validate_json_format
|
|
|
|
exit ${err}
|