1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/tools/testing/selftests/net/mptcp
Paolo Abeni 7cefbe5e1d selftests: mptcp: fix fastclose with csum failure
Running the mp_join selftest manually with the following command line:

  ./mptcp_join.sh -z -C

leads to some failures:

  002 fastclose server test
  # ...
  rtx                                 [fail] got 1 MP_RST[s] TX expected 0
  # ...
  rstrx                               [fail] got 1 MP_RST[s] RX expected 0

The problem is really in the wrong expectations for the RST checks
implied by the csum validation. Note that the same check is repeated
explicitly in the same test-case, with the correct expectation and
pass successfully.

Address the issue explicitly setting the correct expectation for
the failing checks.

Reported-by: Xiumei Mu <xmu@redhat.com>
Fixes: 6bf41020b7 ("selftests: mptcp: update and extend fastclose test-cases")
Cc: stable@vger.kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Link: https://lore.kernel.org/r/20231114-upstream-net-20231113-mptcp-misc-fixes-6-7-rc2-v1-5-7b9cd6a7b7f4@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-11-14 20:10:21 -08:00
..
.gitignore selftests: mptcp: add inq test case 2021-12-07 11:36:30 -08:00
config selftests: mptcp: depend on SYN_COOKIES 2023-07-05 10:51:14 +01:00
diag.sh selftests: mptcp: diag: format subtests results in TAP 2023-07-19 11:10:52 +01:00
Makefile selftests: mptcp: connect: skip if MPTCP is not supported 2023-05-30 13:21:02 +02:00
mptcp_connect.c selftests: mptcp: remove duplicated entries in usage 2023-04-17 08:25:33 +01:00
mptcp_connect.sh selftests: mptcp: connect: format subtests results in TAP 2023-07-19 11:10:52 +01:00
mptcp_inq.c selftests: mptcp: Initialize variables to quiet gcc 12 warnings 2022-06-28 20:45:43 -07:00
mptcp_join.sh selftests: mptcp: fix fastclose with csum failure 2023-11-14 20:10:21 -08:00
mptcp_lib.sh selftests: mptcp: join: colored results 2023-07-31 20:11:53 -07:00
mptcp_sockopt.c selftests: mptcp: add MPTCP_FULL_INFO testcase 2023-06-21 22:45:58 -07:00
mptcp_sockopt.sh selftests: mptcp: sockopt: drop mptcp_connect var 2023-10-27 08:47:30 -07:00
pm_netlink.sh selftests: mptcp: pm_nl_ctl: always look for errors 2023-07-31 20:11:53 -07:00
pm_nl_ctl.c selftests: mptcp: pm_nl_ctl: always look for errors 2023-07-31 20:11:53 -07:00
settings selftests: mptcp: increase timeout to 20 minutes 2022-02-17 19:59:58 -08:00
simult_flows.sh selftests: mptcp: simult flows: format subtests results in TAP 2023-07-19 11:10:52 +01:00
userspace_pm.sh selftests: mptcp: userspace_pm: unmute unexpected errors 2023-07-31 20:11:53 -07:00