1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/ethernet/amd/xgbe
Ahmed Zaki fb6e30a725 net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops
The get/set_rxfh ethtool ops currently takes the rxfh (RSS) parameters
as direct function arguments. This will force us to change the API (and
all drivers' functions) every time some new parameters are added.

This is part 1/2 of the fix, as suggested in [1]:

- First simplify the code by always providing a pointer to all params
   (indir, key and func); the fact that some of them may be NULL seems
   like a weird historic thing or a premature optimization.
   It will simplify the drivers if all pointers are always present.

 - Then make the functions take a dev pointer, and a pointer to a
   single struct wrapping all arguments. The set_* should also take
   an extack.

Link: https://lore.kernel.org/netdev/20231121152906.2dd5f487@kernel.org/ [1]
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Suggested-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
Link: https://lore.kernel.org/r/20231213003321.605376-2-ahmed.zaki@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-12-13 22:07:16 -08:00
..
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
xgbe-common.h amd-xgbe: add support for rx-adaptation 2023-02-02 15:17:19 +01:00
xgbe-dcb.c amd-xgbe: fix clang -Wformat warnings 2022-07-11 19:53:51 -07:00
xgbe-debugfs.c xgbe: no need to check return value of debugfs_create functions 2019-08-10 15:25:47 -07:00
xgbe-desc.c net: Use skb accessors in network drivers 2019-07-22 20:47:56 -07:00
xgbe-dev.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-01-20 12:28:23 -08:00
xgbe-drv.c amd-xgbe: handle the corner-case during tx completion 2023-11-23 13:47:23 +01:00
xgbe-ethtool.c net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops 2023-12-13 22:07:16 -08:00
xgbe-i2c.c net: amd-xgbe: add missed tasklet_kill 2022-12-30 07:33:05 +00:00
xgbe-main.c ethernet: use eth_hw_addr_set() for dev->addr_len cases 2021-10-05 13:16:48 +01:00
xgbe-mdio.c amd-xgbe: handle corner-case during sfp hotplug 2023-11-23 13:47:23 +01:00
xgbe-pci.c amd-xgbe: Yellow carp devices do not need rrc 2022-10-21 22:40:21 -07:00
xgbe-phy-v1.c amd-xgbe: Convert to using the new link mode settings 2017-08-18 16:30:17 -07:00
xgbe-phy-v2.c amd-xgbe: extend 10Mbps support to MAC version 21H 2023-06-13 10:44:11 +01:00
xgbe-platform.c net: ethernet: Use device_get_match_data() 2023-10-13 10:04:53 +01:00
xgbe-ptp.c ptp: xgbe: convert to .adjfine and adjust_by_scaled_ppm 2022-10-31 11:14:16 +00:00
xgbe.h amd-xgbe: Avoid potential string truncation in name 2023-12-13 18:31:32 -08:00