1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/ethernet/huawei/hinic
Ahmed Zaki fb6e30a725 net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops
The get/set_rxfh ethtool ops currently takes the rxfh (RSS) parameters
as direct function arguments. This will force us to change the API (and
all drivers' functions) every time some new parameters are added.

This is part 1/2 of the fix, as suggested in [1]:

- First simplify the code by always providing a pointer to all params
   (indir, key and func); the fact that some of them may be NULL seems
   like a weird historic thing or a premature optimization.
   It will simplify the drivers if all pointers are always present.

 - Then make the functions take a dev pointer, and a pointer to a
   single struct wrapping all arguments. The set_* should also take
   an extack.

Link: https://lore.kernel.org/netdev/20231121152906.2dd5f487@kernel.org/ [1]
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Suggested-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
Link: https://lore.kernel.org/r/20231213003321.605376-2-ahmed.zaki@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-12-13 22:07:16 -08:00
..
hinic_common.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288 2019-06-05 17:36:37 +02:00
hinic_common.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288 2019-06-05 17:36:37 +02:00
hinic_debugfs.c net: hinic: fix memory leak when reading function table 2022-10-20 21:09:47 -07:00
hinic_debugfs.h net: hinic: remove unused macro 2022-09-22 17:41:27 -07:00
hinic_dev.h net: hinic: Set max_mtu/min_mtu directly to simplify the code. 2022-10-25 19:42:34 -07:00
hinic_devlink.c hinic: devlink health: use retained error fmsg API 2023-10-20 11:34:50 +01:00
hinic_devlink.h devlink: Make devlink_register to be void 2021-09-22 14:15:12 +01:00
hinic_ethtool.c net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops 2023-12-13 22:07:16 -08:00
hinic_hw_api_cmd.c net: huawei: hinic: Use devm_kcalloc() instead of devm_kzalloc() 2021-12-08 18:37:28 -08:00
hinic_hw_api_cmd.h hinic: add log in exception handling processes 2020-07-28 17:22:03 -07:00
hinic_hw_cmdq.c net: hinic: fix the issue of CMDQ memory leaks 2022-10-20 21:09:47 -07:00
hinic_hw_cmdq.h net: hinic: change type of function to be static 2022-09-22 17:41:26 -07:00
hinic_hw_csr.h net: hinic: remove unused macro 2022-09-22 17:41:27 -07:00
hinic_hw_dev.c net: hinic: fix incorrect assignment issue in hinic_set_interrupt_cfg() 2022-10-20 21:09:46 -07:00
hinic_hw_dev.h net: hinic: Add control command support for VF PMD driver in DPDK 2022-11-07 08:50:20 +00:00
hinic_hw_eqs.c net: huawei: hinic: Use devm_kcalloc() instead of devm_kzalloc() 2021-12-08 18:37:28 -08:00
hinic_hw_eqs.h hinic: modify irq name 2020-09-18 14:34:24 -07:00
hinic_hw_if.c net: hinic: remove unused functions 2022-09-22 17:41:26 -07:00
hinic_hw_if.h net: hinic: remove unused functions 2022-09-22 17:41:26 -07:00
hinic_hw_io.c net: hinic: Use devm_kcalloc() instead of devm_kzalloc() 2021-12-08 18:37:06 -08:00
hinic_hw_io.h hinic: add support to query sq info 2020-08-31 12:21:26 -07:00
hinic_hw_mbox.c net: hinic: remove unused macro 2022-09-22 17:41:27 -07:00
hinic_hw_mbox.h net: hinic: change type of function to be static 2022-09-22 17:41:26 -07:00
hinic_hw_mgmt.c net: hinic: add missing destroy_workqueue in hinic_pf_to_mgmt_init 2022-05-16 10:57:00 +01:00
hinic_hw_mgmt.h hinic: add generating mailbox random index support 2020-08-04 12:17:06 -07:00
hinic_hw_qp.c net: hinic: remove the unused input parameter prod_idx in sq_prepare_ctrl() 2022-09-22 17:41:28 -07:00
hinic_hw_qp.h net: hinic: remove the unused input parameter prod_idx in sq_prepare_ctrl() 2022-09-22 17:41:28 -07:00
hinic_hw_qp_ctxt.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2019-06-17 20:20:36 -07:00
hinic_hw_wq.c net: hinic: modify kernel doc comments 2022-09-22 17:41:26 -07:00
hinic_hw_wq.h hinic: add sriov feature support 2020-04-25 20:46:28 -07:00
hinic_hw_wqe.h net: hinic: remove unused enumerated value 2022-09-22 17:41:28 -07:00
hinic_main.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2022-11-17 18:30:39 -08:00
hinic_port.c net: hinic: Fix warning-hinic_set_vlan_fliter() warn: variable dereferenced before check 'hwdev' 2023-09-20 10:54:45 +01:00
hinic_port.h net: hinic: Add support for configuration of rx-vlan-filter by ethtool 2022-11-07 08:50:20 +00:00
hinic_rx.c net: Remove the obsolte u64_stats_fetch_*_irq() users (drivers). 2022-10-28 20:13:54 -07:00
hinic_rx.h net: hinic: change type of function to be static 2022-09-22 17:41:26 -07:00
hinic_sriov.c net: hinic: Add control command support for VF PMD driver in DPDK 2022-11-07 08:50:20 +00:00
hinic_sriov.h net: hinic: change type of function to be static 2022-09-22 17:41:26 -07:00
hinic_tx.c net: hinic: Use devm_kasprintf() 2023-09-13 12:21:09 +01:00
hinic_tx.h net: hinic: change type of function to be static 2022-09-22 17:41:26 -07:00
Kconfig net: hinic: fix DEVLINK build errors 2020-10-03 16:52:19 -07:00
Makefile hinic: add support to query sq info 2020-08-31 12:21:26 -07:00