0647ece381
Engine->id namespace is per-tile so struct igt_live_test->reset_engine[]
needs to be two-dimensional so engine reset counts from all tiles can be
stored with no aliasing. With aliasing, if we had a real multi-tile
platform, the reset counts would be incorrect for same engine instance on
different tiles.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: 0c29efa23f ("drm/i915/selftests: Consider multi-gt instead of to_gt()")
Reported-by: Alan Previn Teres Alexis <alan.previn.teres.alexis@intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231201122109.729006-1-tvrtko.ursulin@linux.intel.com
83 lines
1.8 KiB
C
83 lines
1.8 KiB
C
/*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Copyright © 2018 Intel Corporation
|
|
*/
|
|
|
|
#include "i915_drv.h"
|
|
#include "gt/intel_gt.h"
|
|
#include "gt/intel_gt_print.h"
|
|
|
|
#include "../i915_selftest.h"
|
|
#include "igt_flush_test.h"
|
|
#include "igt_live_test.h"
|
|
|
|
int igt_live_test_begin(struct igt_live_test *t,
|
|
struct drm_i915_private *i915,
|
|
const char *func,
|
|
const char *name)
|
|
{
|
|
struct intel_engine_cs *engine;
|
|
enum intel_engine_id id;
|
|
struct intel_gt *gt;
|
|
unsigned int i;
|
|
int err;
|
|
|
|
t->i915 = i915;
|
|
t->func = func;
|
|
t->name = name;
|
|
|
|
for_each_gt(gt, i915, i) {
|
|
|
|
err = intel_gt_wait_for_idle(gt, MAX_SCHEDULE_TIMEOUT);
|
|
if (err) {
|
|
gt_err(gt, "%s(%s): GT failed to idle before, with err=%d!",
|
|
func, name, err);
|
|
return err;
|
|
}
|
|
|
|
for_each_engine(engine, gt, id)
|
|
t->reset_engine[i][id] =
|
|
i915_reset_engine_count(&i915->gpu_error,
|
|
engine);
|
|
}
|
|
|
|
t->reset_global = i915_reset_count(&i915->gpu_error);
|
|
|
|
return 0;
|
|
}
|
|
|
|
int igt_live_test_end(struct igt_live_test *t)
|
|
{
|
|
struct drm_i915_private *i915 = t->i915;
|
|
struct intel_engine_cs *engine;
|
|
enum intel_engine_id id;
|
|
struct intel_gt *gt;
|
|
unsigned int i;
|
|
|
|
if (igt_flush_test(i915))
|
|
return -EIO;
|
|
|
|
if (t->reset_global != i915_reset_count(&i915->gpu_error)) {
|
|
pr_err("%s(%s): GPU was reset %d times!\n",
|
|
t->func, t->name,
|
|
i915_reset_count(&i915->gpu_error) - t->reset_global);
|
|
return -EIO;
|
|
}
|
|
|
|
for_each_gt(gt, i915, i) {
|
|
for_each_engine(engine, gt, id) {
|
|
if (t->reset_engine[i][id] ==
|
|
i915_reset_engine_count(&i915->gpu_error, engine))
|
|
continue;
|
|
|
|
gt_err(gt, "%s(%s): engine '%s' was reset %d times!\n",
|
|
t->func, t->name, engine->name,
|
|
i915_reset_engine_count(&i915->gpu_error, engine) -
|
|
t->reset_engine[i][id]);
|
|
return -EIO;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|