The new mdp3 driver uses 'select' to force-enable a couple of drivers it depends on. This is error-prone and likely to cause dependency loops as well as warnings like: WARNING: unmet direct dependencies detected for VIDEO_MEDIATEK_VPU Depends on [n]: MEDIA_SUPPORT [=m] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_MEM2MEM_DRIVERS [=n] && VIDEO_DEV [=m] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y]) Selected by [m]: - VIDEO_MEDIATEK_MDP3 [=m] && MEDIA_SUPPORT [=m] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && (MTK_IOMMU [=m] || COMPILE_TEST [=y]) && VIDEO_DEV [=m] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y]) && HAS_DMA [=y] && REMOTEPROC [=y] This specific warning was already addressed in a previous patch, but there are similar unnecessary 'select' statements, so turn those into 'depends on'. This also means the dependency on ARCH_MEDIATEK is redundant and can be dropped. Fixes:61890ccaef
("media: platform: mtk-mdp3: add MediaTek MDP3 driver") Fixes:9195a860ef
("media: platform: mtk-mdp3: remove unused VIDEO_MEDIATEK_VPU config") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
19 lines
559 B
Text
19 lines
559 B
Text
# SPDX-License-Identifier: GPL-2.0-only
|
|
config VIDEO_MEDIATEK_MDP3
|
|
tristate "MediaTek MDP v3 driver"
|
|
depends on MTK_IOMMU || COMPILE_TEST
|
|
depends on VIDEO_DEV
|
|
depends on HAS_DMA
|
|
depends on REMOTEPROC
|
|
depends on MTK_MMSYS
|
|
depends on MTK_CMDQ
|
|
depends on MTK_SCP
|
|
select VIDEOBUF2_DMA_CONTIG
|
|
select V4L2_MEM2MEM_DEV
|
|
default n
|
|
help
|
|
It is a v4l2 driver and present in MediaTek MT8183 SoC.
|
|
The driver supports scaling and color space conversion.
|
|
|
|
To compile this driver as a module, choose M here: the
|
|
module will be called mtk-mdp3.
|