1ad717c929
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). > ./drivers/scsi/fnic/fnic_attrs.c:17:8-16: WARNING: please use sysfs_emit > ./drivers/scsi/fnic/fnic_attrs.c:23:8-16: WARNING: please use sysfs_emit > ./drivers/scsi/fnic/fnic_attrs.c:31:8-16: WARNING: please use sysfs_emit No functional change intended CC: Satish Kharat <satishkh@cisco.com> CC: Sesidhar Baddela <sebaddel@cisco.com> CC: Karan Tilak Kumar <kartilak@cisco.com> CC: James E.J. Bottomley <jejb@linux.ibm.com> CC: Martin K. Petersen <martin.petersen@oracle.com> CC: linux-scsi@vger.kernel.org Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> Link: https://lore.kernel.org/r/20240116045151.3940401-20-lizhijian@fujitsu.com Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
52 lines
1.4 KiB
C
52 lines
1.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright 2008 Cisco Systems, Inc. All rights reserved.
|
|
* Copyright 2007 Nuova Systems, Inc. All rights reserved.
|
|
*/
|
|
#include <linux/string.h>
|
|
#include <linux/device.h>
|
|
#include <scsi/scsi_host.h>
|
|
#include "fnic.h"
|
|
|
|
static ssize_t fnic_show_state(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct fc_lport *lp = shost_priv(class_to_shost(dev));
|
|
struct fnic *fnic = lport_priv(lp);
|
|
|
|
return sysfs_emit(buf, "%s\n", fnic_state_str[fnic->state]);
|
|
}
|
|
|
|
static ssize_t fnic_show_drv_version(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
return sysfs_emit(buf, "%s\n", DRV_VERSION);
|
|
}
|
|
|
|
static ssize_t fnic_show_link_state(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct fc_lport *lp = shost_priv(class_to_shost(dev));
|
|
|
|
return sysfs_emit(buf, "%s\n", (lp->link_up) ? "Link Up" : "Link Down");
|
|
}
|
|
|
|
static DEVICE_ATTR(fnic_state, S_IRUGO, fnic_show_state, NULL);
|
|
static DEVICE_ATTR(drv_version, S_IRUGO, fnic_show_drv_version, NULL);
|
|
static DEVICE_ATTR(link_state, S_IRUGO, fnic_show_link_state, NULL);
|
|
|
|
static struct attribute *fnic_host_attrs[] = {
|
|
&dev_attr_fnic_state.attr,
|
|
&dev_attr_drv_version.attr,
|
|
&dev_attr_link_state.attr,
|
|
NULL,
|
|
};
|
|
|
|
static const struct attribute_group fnic_host_attr_group = {
|
|
.attrs = fnic_host_attrs
|
|
};
|
|
|
|
const struct attribute_group *fnic_host_groups[] = {
|
|
&fnic_host_attr_group,
|
|
NULL
|
|
};
|