niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity
linux/drivers/net/ethernet/microsoft/mana
History
Haiyang Zhang 18010ff776 net: mana: Fix race on per-CQ variable napi work_done 
After calling napi_complete_done(), the NAPIF_STATE_SCHED bit may be
cleared, and another CPU can start napi thread and access per-CQ variable,
cq->work_done. If the other thread (for example, from busy_poll) sets
it to a value >= budget, this thread will continue to run when it should
stop, and cause memory corruption and panic.

To fix this issue, save the per-CQ work_done variable in a local variable
before napi_complete_done(), so it won't be corrupted by a possible
concurrent thread after napi_complete_done().

Also, add a flag bit to advertise to the NIC firmware: the NAPI work_done
variable race is fixed, so the driver is able to reliably support features
like busy_poll.

Cc: stable@vger.kernel.org
Fixes: e1b5683ff6 ("net: mana: Move NAPI from EQ to CQ")
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Link: https://lore.kernel.org/r/1670010190-28595-1-git-send-email-haiyangz@microsoft.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2022-12-06 11:21:34 +01:00
..
gdma.h net: mana: Fix race on per-CQ variable napi work_done 2022-12-06 11:21:34 +01:00
gdma_main.c Including fixes from wifi, netfilter and can. 2022-09-22 10:58:13 -07:00
hw_channel.c net: mana: Add the Linux MANA PF driver 2022-06-16 10:40:25 +02:00
hw_channel.h net: mana: Add the Linux MANA PF driver 2022-06-16 10:40:25 +02:00
Makefile net: mana: Add XDP support 2021-11-22 13:20:19 +00:00
mana.h net: mana: Add support of XDP_REDIRECT action 2022-06-16 10:40:25 +02:00
mana_bpf.c net: mana: Add support of XDP_REDIRECT action 2022-06-16 10:40:25 +02:00
mana_en.c net: mana: Fix race on per-CQ variable napi work_done 2022-12-06 11:21:34 +01:00
mana_ethtool.c net: mana: Add support of XDP_REDIRECT action 2022-06-16 10:40:25 +02:00
shm_channel.c
shm_channel.h