a6e2af64a7
Display resolution change is implemented through drm modeset. Older
modeset (resolution) has to be disabled first before newer modeset
(resolution) can be enabled. Display disable will turn off both
pixel clock and main link clock so that main link have to be
re-trained during display enable to have new video stream flow
again. At current implementation, display enable function manually
kicks up irq_hpd_handle which will read panel link status and start
link training if link status is not in sync state.
However, there is rare case that a particular panel links status keep
staying in sync for some period of time after main link had been shut
down previously at display disabled. In this case, main link retraining
will not be executed by irq_hdp_handle(). Hence video stream of newer
display resolution will fail to be transmitted to panel due to main
link is not in sync between host and panel.
This patch will bypass irq_hpd_handle() in favor of directly call
dp_ctrl_on_stream() to always perform link training in regardless of
main link status. So that no unexpected exception resolution change
failure cases will happen. Also this implementation are more efficient
than manual kicking off irq_hpd_handle function.
Changes in v2:
-- set force_link_train flag on DP only (is_edp == false)
Changes in v3:
-- revise commit text
-- add Fixes tag
Changes in v4:
-- revise commit text
Changes in v5:
-- fix spelling at commit text
Changes in v6:
-- split dp_ctrl_on_stream() for phy test case
-- revise commit text for modeset
Changes in v7:
-- drop 0 assignment at local variable (ret = 0)
Changes in v8:
-- add patch to remove pixel_rate from dp_ctrl
Changes in v9:
-- forward declare dp_ctrl_on_stream_phy_test_report()
Fixes: 62671d2ef2 ("drm/msm/dp: fixes wrong connection state caused by failure of link train")
Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/489895/
Link: https://lore.kernel.org/r/1655411200-7255-1-git-send-email-quic_khsieh@quicinc.com
Signed-off-by: Rob Clark <robdclark@chromium.org>
41 lines
1.2 KiB
C
41 lines
1.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Copyright (c) 2012-2020, The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
#ifndef _DP_CTRL_H_
|
|
#define _DP_CTRL_H_
|
|
|
|
#include "dp_aux.h"
|
|
#include "dp_panel.h"
|
|
#include "dp_link.h"
|
|
#include "dp_parser.h"
|
|
#include "dp_power.h"
|
|
#include "dp_catalog.h"
|
|
|
|
struct dp_ctrl {
|
|
bool orientation;
|
|
atomic_t aborted;
|
|
u32 pixel_rate;
|
|
bool wide_bus_en;
|
|
};
|
|
|
|
int dp_ctrl_on_link(struct dp_ctrl *dp_ctrl);
|
|
int dp_ctrl_on_stream(struct dp_ctrl *dp_ctrl, bool force_link_train);
|
|
int dp_ctrl_off_link_stream(struct dp_ctrl *dp_ctrl);
|
|
int dp_ctrl_off_link(struct dp_ctrl *dp_ctrl);
|
|
int dp_ctrl_off(struct dp_ctrl *dp_ctrl);
|
|
void dp_ctrl_push_idle(struct dp_ctrl *dp_ctrl);
|
|
void dp_ctrl_isr(struct dp_ctrl *dp_ctrl);
|
|
void dp_ctrl_handle_sink_request(struct dp_ctrl *dp_ctrl);
|
|
struct dp_ctrl *dp_ctrl_get(struct device *dev, struct dp_link *link,
|
|
struct dp_panel *panel, struct drm_dp_aux *aux,
|
|
struct dp_power *power, struct dp_catalog *catalog,
|
|
struct dp_parser *parser);
|
|
|
|
void dp_ctrl_reset_irq_ctrl(struct dp_ctrl *dp_ctrl, bool enable);
|
|
void dp_ctrl_phy_init(struct dp_ctrl *dp_ctrl);
|
|
void dp_ctrl_phy_exit(struct dp_ctrl *dp_ctrl);
|
|
void dp_ctrl_irq_phy_exit(struct dp_ctrl *dp_ctrl);
|
|
|
|
#endif /* _DP_CTRL_H_ */
|