994a04a20b
32-bit processors cannot generally access 64-bit MMIO registers
atomically, and it is unknown in which order the two halves of
this registers would need to be read:
drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In function 'send_mbox_cmd':
drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:37: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]
79 | *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA));
| ^~~~~
| readl
The driver already does not build for anything other than x86,
so limit it further to x86-64.
Fixes: aeb58c860d ("thermal/drivers/int340x: processor_thermal: Suppot 64 bit RFIM responses")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
47 lines
1.6 KiB
Text
47 lines
1.6 KiB
Text
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# ACPI INT340x thermal drivers configuration
|
|
#
|
|
|
|
config INT340X_THERMAL
|
|
tristate "ACPI INT340X thermal drivers"
|
|
depends on X86_64 && ACPI && PCI
|
|
select THERMAL_GOV_USER_SPACE
|
|
select ACPI_THERMAL_REL
|
|
select ACPI_FAN
|
|
select INTEL_SOC_DTS_IOSF_CORE
|
|
select PROC_THERMAL_MMIO_RAPL if POWERCAP
|
|
help
|
|
Newer laptops and tablets that use ACPI may have thermal sensors and
|
|
other devices with thermal control capabilities outside the core
|
|
CPU/SOC, for thermal safety reasons.
|
|
They are exposed for the OS to use via the INT3400 ACPI device object
|
|
as the master, and INT3401~INT340B ACPI device objects as the slaves.
|
|
Enable this to expose the temperature information and cooling ability
|
|
from these objects to userspace via the normal thermal framework.
|
|
This means that a wide range of applications and GUI widgets can show
|
|
the information to the user or use this information for making
|
|
decisions. For example, the Intel Thermal Daemon can use this
|
|
information to allow the user to select his laptop to run without
|
|
turning on the fans.
|
|
|
|
config ACPI_THERMAL_REL
|
|
tristate
|
|
depends on ACPI
|
|
|
|
if INT340X_THERMAL
|
|
|
|
config INT3406_THERMAL
|
|
tristate "ACPI INT3406 display thermal driver"
|
|
depends on ACPI_VIDEO
|
|
help
|
|
The display thermal device represents the LED/LCD display panel
|
|
that may or may not include touch support. The main function of
|
|
the display thermal device is to allow control of the display
|
|
brightness in order to address a thermal condition or to reduce
|
|
power consumed by display device.
|
|
|
|
config PROC_THERMAL_MMIO_RAPL
|
|
tristate
|
|
select INTEL_RAPL_CORE
|
|
endif
|